test: add logging, reduce blocks, move sync_all in wallet_ groups #21411

pull jonatack wants to merge 2 commits into bitcoin:master from jonatack:wallet_groups-test changing 1 files +9 −7

jonatack commented at 9:19 PM on March 10, 2021: member
- add logging (particularly useful as the tests are somewhat slow)
- generate 101 blocks instead of 110
- move sync_all call into the loop, so fewer blocks are synced on each call, to hopefully see fewer CI timeouts as in https://bitcoinbuilds.org/index.php?ansilog=88eee99e-1727-44ed-b778-3b9c75c33928.log
```
L2742     File "/home/ubuntu/src/test/functional/wallet_groups.py", line 162, in run_test
L2743       self.sync_all()
test_framework.authproxy.JSONRPCException: 'syncwithvalidationinterfacequeue' RPC took longer than 960.000000 seconds. Consider using larger timeout for calls that take longer to return. (-344)
```
test: add missing logging to wallet_groups.py 3a16b5ef95
fanquake added the label Tests on Mar 10, 2021
MarcoFalke commented at 7:14 AM on March 11, 2021: member

The timeout happens in line 162, not in line 34. It can be fixed by moving the sync_all into the loop, so that less blocks are synced to the wallet on each call.

(Note that #20362 probably fixes this too)

test: use fewer blocks in wallet_groups and move sync call

- generate 101 blocks instead of 110

- move a sync_all call into the loop so that fewer blocks are
  synced on each call to hopefully see fewer timeouts

c62f9bc0e9

jonatack force-pushed on Mar 11, 2021
jonatack commented at 4:21 PM on March 11, 2021: member

Added to the second commit. I thought about moving the sync_all call into the loop; thanks for confirming. Will look at #20362 as well.
jonatack renamed this:
~~test: add logging, reduce blocks generated in wallet groups test~~
test: add logging, reduce blocks, move sync_all in wallet_ groups
on Mar 11, 2021
MarcoFalke commented at 4:58 PM on March 11, 2021: member

cr ACK c62f9bc0e931f65eef63041d2c53f9a294c0e8d6
MarcoFalke merged this on Mar 11, 2021
MarcoFalke closed this on Mar 11, 2021
jonatack deleted the branch on Mar 11, 2021
sidhujag referenced this in commit 6a70acf1f2 on Mar 11, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

jonatack

MarcoFalke

Labels

Tests