OutputDebugStringF code cleanup #2142

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:utilprint changing 2 files +57 −42

gavinandresen commented at 10:18 PM on January 1, 2013: contributor

There was a bunch of shed-painting about this before the 0.7.1 release, and I promised to tidy up the code, so:

Initialize the OutputDebugStringF mutex and file pointer using boost::call_once, to be thread-safe.

Make the return value of OutputDebugStringF really be the number of characters written (*printf() semantics).

Declare the fReopenDebugLog flag volatile, since it is changed from a signal handler.

And don't declare OutputDebugStringF() as inline.

OutputDebugStringF code cleanup

Initialize the OutputDebugStringF mutex and file pointer using
boost::call_once, to be thread-safe.
Make the return value of OutputDebugStringF really be the number of
characters written (*printf() semantics).
Declare the fReopenDebugLog flag volatile, since it is changed from
a signal handler.
And don't declare OutputDebugStringF() as inline.

ee3374234c

Diapolo commented at 3:05 PM on January 2, 2013: none

Compiles fine, no obvious weird behaviour, while doing IBD and such.
laanwj commented at 3:57 PM on January 2, 2013: member

ACK
BitcoinPullTester commented at 7:18 AM on January 3, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ee3374234c60aba2cc4c5cd5cac1c0aefc2d817c for binaries and test log.
sipa commented at 12:12 AM on January 6, 2013: member

ACK
gavinandresen referenced this in commit 40e31fd373 on Jan 14, 2013
gavinandresen merged this on Jan 14, 2013
gavinandresen closed this on Jan 14, 2013
laudney referenced this in commit 77b58c99ee on Mar 19, 2014
owlhooter referenced this in commit 5e1149a655 on Oct 11, 2018
DrahtBot locked this on Sep 8, 2021

Contributors