rpc: remove scantxoutset EXPERIMENTAL warning #21426

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:rm-scantxoutset-warning changing 1 files +0 −1
  1. jonatack commented at 8:13 pm on March 12, 2021: member

    Remove old warning per IRC wallet meeting discussion at http://www.erisian.com.au/bitcoin-core-dev/log-2021-03-12.html#l-467

    This RPC was merged 3 years ago in #12196.

  2. DrahtBot added the label RPC/REST/ZMQ on Mar 12, 2021
  3. DrahtBot commented at 2:48 am on March 13, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20556 (rpc: Properly document return values (submitblock, gettxout, getblocktemplate, scantxoutset) by MarcoFalke)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. unknown approved
  5. unknown commented at 5:30 am on March 13, 2021: none

    ACK https://github.com/bitcoin/bitcoin/pull/21426/commits/47930074268a0f4b940d47ea94456d4eda29c75d

    Someone had asked me this IRL recently and I had suggested to use it as long as it is helpful. I think this is the only RPC which can be used to get UTXO details if the address doesn’t belong to wallet(without importing).

  6. fjahr commented at 8:24 pm on March 14, 2021: member
    ACK 47930074268a0f4b940d47ea94456d4eda29c75d
  7. MarcoFalke commented at 8:19 am on March 15, 2021: member

    This RPC was merged 3 years ago in #12196.

    Just for completeness, the interface was broken to be descriptors-only some time after that.

    Concept ACK.

  8. DrahtBot commented at 8:20 am on March 15, 2021: member

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

  9. DrahtBot added the label Needs rebase on Mar 15, 2021
  10. sipa commented at 8:25 am on March 15, 2021: member
    @MarcoFalke The pre-descriptors version was never released AFAIK.
  11. MarcoFalke commented at 8:42 am on March 15, 2021: member
    Indeed. Both are in 0.17.0 (commit 151600bb4972f7bab4ed4a03d1f67c38e081fefe)
  12. rpc: remove scantxoutset EXPERIMENTAL warning 2f0b25a156
  13. jonatack force-pushed on Mar 15, 2021
  14. jonatack commented at 9:51 am on March 15, 2021: member
    rebased
  15. MarcoFalke commented at 10:12 am on March 15, 2021: member
    cr ACK 2f0b25a1564e275dc090e4ad6dafcfdf8701494e
  16. jonasschnelli approved
  17. jonasschnelli commented at 10:16 am on March 15, 2021: contributor
    ACK 2f0b25a1564e275dc090e4ad6dafcfdf8701494e
  18. MarcoFalke merged this on Mar 15, 2021
  19. MarcoFalke closed this on Mar 15, 2021

  20. jonatack deleted the branch on Mar 15, 2021
  21. sidhujag referenced this in commit 1bd24c7600 on Mar 15, 2021
  22. fanquake removed the label Needs rebase on May 31, 2021
  23. Fabcien referenced this in commit 022b780600 on Apr 13, 2022
  24. DrahtBot locked this on Aug 18, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 04:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me