update ThreadSafeMessageBox function to use strCaption #2143

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:ThreadSafeMessageBox_caption changing 1 files +2 −2

Diapolo commented at 2:13 PM on January 2, 2013: none
- ensure we use strCaption for printf and fprintf, as before it could happen to have an error message in the debug.log, which had no "Error" (or whatever) in front
- ensure ThreadSafeMessageBox() uses the same code (when guiref == NULL) as noui_ThreadSafeMessageBox()
BitcoinPullTester commented at 7:04 AM on January 3, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/5fb8d5275d519883bbae036d04c065d3ac68ad8c for binaries and test log.

update noui_ThreadSafeMessageBox function to use strCaption

- ensure we use strCaption for printf and fprintf, as before it could
  happen to have an error message in the debug.log, which had no "Error"
  (or whatever) in front

37f070f564

in src/qt/bitcoin.cpp:None in 5fb8d5275d outdated
```
  48 | @@ -49,8 +49,26 @@ static void ThreadSafeMessageBox(const std::string& message, const std::string&
  49 |      }
  50 |      else
  51 |      {
  52 | -        printf("%s: %s\n", caption.c_str(), message.c_str());
```
laanwj commented at 3:51 PM on January 5, 2013:

There is really no need to change this to more verbose code, AFAIK it isn't possible to reach this code at all, it's just there in case something is broken the message doesn't get completely discarded.

Diapolo commented at 2:44 AM on January 6, 2013:

I'll revert that then :).

Edit: Reverted!
BitcoinPullTester commented at 3:45 AM on January 6, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/37f070f564b425f62f95a76383d475eabb2b4aff for binaries and test log.
laanwj commented at 1:21 PM on January 6, 2013: member

ACK
laanwj referenced this in commit 13013f5044 on Jan 6, 2013
laanwj merged this on Jan 6, 2013
laanwj closed this on Jan 6, 2013
laudney referenced this in commit 7a3c1c16c9 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

BitcoinPullTester

laanwj