test: add -daemon and -daemonwait config arg tests #21439

1. 
   jonatack commented at 6:08 pm on March 14, 2021: member
2. test: add -daemon config arg tests 6c7e3bde1e
3. test: add -daemonwait config arg tests 841eabc325
4. jonatack force-pushed on Mar 14, 2021
5. DrahtBot added the label Tests on Mar 14, 2021
6. 
   0xB10C commented at 9:00 am on March 16, 2021: member

   Concept ACK
7. in test/functional/feature_daemon_config_args.py:64 in 841eabc325

   59+        self.log.debug('Test -nodaemonwait=1')
   60+        with self.nodes[0].assert_debug_log(expected_msgs=['Command-line arg: daemonwait=false\n']):
   61+            self.start_node(0, extra_args=['-nodaemonwait=1'])
   62+        self.stop_node(0)
   63+
   64+        self.log.debug('Test -daemonwait')
   

   ---

   ---

   

   laanwj commented at 6:00 pm on March 16, 2021:

   I wonder if we can somehow test the -daemonwait functionality here too, that RPC is available and initialized at the time it returns.

   ---

   

   jonatack commented at 6:11 pm on March 16, 2021:

   Agree. ATM the processes launched by -daemon and -daemonwait remain alive after the test cleanup, so it looks like the framework needs to be updated to deal with these.

   ---

   

   laanwj commented at 6:19 pm on March 16, 2021:

   Agree… Leaking processes is kind of bad. FWIW, one of my ideas in #21007 was to use -daemonwait in the test framework to avoid having to poll until RPC comes up. I’m not sure it’s actually useful for that (due to how we handle logging) though.
8. jonatack closed this on May 11, 2021

   ---

9. 
   jonatack commented at 10:06 am on May 11, 2021: member

   Am starting seminars and won’t come back to this patch for some time, so up for grabs.
10. laanwj added the label Up for grabs on May 11, 2021
11. 
    laanwj commented at 10:08 am on May 11, 2021: member

    Ok, added “up for grabs” label. Looks like this is more involved than expected.
12. DrahtBot locked this on Aug 18, 2022

Contributors
jonatack 0xB10C laanwj

Labels
Tests Up for grabs