doc: Address feedback from Transifex translator community #21463

1. 
   hebasto commented at 9:02 pm on March 17, 2021: member

   In this PR I collected all relevant open issues on https://www.transifex.com/bitcoin.
2. doc: Improve translatable strings after Transifex issues 4bce61519f
3. doc: Replace three dots with ellipsis in all of the translatable strings 9030e4b5a6
4. 
   hebasto commented at 9:02 pm on March 17, 2021: member

   cc @harding @jonatack @laanwj
5. DrahtBot added the label Docs on Mar 17, 2021
6. DrahtBot added the label GUI on Mar 17, 2021
7. DrahtBot added the label P2P on Mar 17, 2021
8. DrahtBot added the label RPC/REST/ZMQ on Mar 17, 2021
9. DrahtBot added the label Validation on Mar 17, 2021
10. DrahtBot added the label Wallet on Mar 17, 2021
11. 
    DrahtBot commented at 1:35 am on March 18, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #21523 (validation: run VerifyDB on all chainstates by jamesob)
    • #21009 (Remove RewindBlockIndex logic by dhruv)
    • #20773 (refactor: split CWallet::Create by S3RK)
    • #17211 (Allow fundrawtransaction and walletcreatefundedpsbt to take external inputs by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

12. MarcoFalke removed the label P2P on Mar 18, 2021
13. MarcoFalke removed the label RPC/REST/ZMQ on Mar 18, 2021
14. MarcoFalke removed the label Validation on Mar 18, 2021
15. MarcoFalke removed the label Wallet on Mar 18, 2021
16. 
    murali1999-tech commented at 4:05 pm on March 18, 2021: none

    Yes , I agree this needs to be done
17. in src/qt/paymentserver.cpp:240 in 4bce61519f outdated

    236@@ -237,7 +237,7 @@ void PaymentServer::handleURIOrFile(const QString& s)
    237                         Q_EMIT message(tr("URI handling"),
    238                             tr("Cannot process payment request because BIP70 is not supported.")+
    239                             tr("Due to widespread security flaws in BIP70 it's strongly recommended that any merchant instructions to switch wallets be ignored.")+
    240-                            tr("If you are receiving this error you should request the merchant provide a BIP21 compatible URI."),
    241+                            tr("If you are receiving this error, you should request from the merchant to provide a BIP21 compatible URI."),
    

    ---

    ---

    

    laanwj commented at 8:24 pm on March 18, 2021:

    I don’t think we should be making people re-translate the BIP70 deprecation message (another case below).
18. in src/qt/psbtoperationsdialog.cpp:144 in 4bce61519f outdated

    140@@ -141,7 +141,7 @@ void PSBTOperationsDialog::saveTransaction() {
    141     filename_suggestion.append(".psbt");
    142     QString filename = GUIUtil::getSaveFileName(this,
    143         tr("Save Transaction Data"), filename_suggestion,
    144-        tr("Partially Signed Transaction (Binary)", "Name of binary PSBT file format") + QLatin1String(" (*.psbt)"), &selected_filter);
    145+        tr("Partially Signed Bitcoin Transaction (Binary)", "Name of binary PSBT file format") + QLatin1String(" (*.psbt)"), &selected_filter);
    

    ---

    ---

    

    laanwj commented at 8:26 pm on March 18, 2021:

    -0 on adding “Bitcoin” everywhere here, as this is bitcoin-only software and we only have one type of transaction, the bitcoin transaction, I think the context is already pretty clear?
19. in src/banman.cpp:18 in 9030e4b5a6

    14@@ -15,7 +15,7 @@
    15 BanMan::BanMan(fs::path ban_file, CClientUIInterface* client_interface, int64_t default_ban_time)
    16     : m_client_interface(client_interface), m_ban_db(std::move(ban_file)), m_default_ban_time(default_ban_time)
    17 {
    18-    if (m_client_interface) m_client_interface->InitMessage(_("Loading banlist...").translated);
    19+    if (m_client_interface) m_client_interface->InitMessage(_("Loading banlist…").translated);
    

    ---

    ---

    

    laanwj commented at 8:29 pm on March 18, 2021:

    Mind that these messages also end up in the log. In principle the log is already UTF-8 (as are all strings and text in bitcoind). But, just noting, that it might make browsing the log a less pleasant experience on systems with misconfigured locale like some BSDs by default.
20. 
    DrahtBot commented at 5:59 am on March 29, 2021: member

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

21. DrahtBot added the label Needs rebase on Mar 29, 2021
22. 
    hebasto commented at 7:12 pm on May 2, 2021: member

    Closing in favor of #21836. Other changes will be moved to the GUI repo.
23. hebasto closed this on May 2, 2021

    ---

24. laanwj referenced this in commit f8176b768a on May 10, 2021
25. DrahtBot locked this on Aug 16, 2022

Contributors
hebasto DrahtBot murali1999-tech laanwj

Labels
GUI Docs Needs rebase