<=0.21: Invalid use of static constexpr members without explicit definition #21508

issue luke-jr opened this issue on March 22, 2021
  1. luke-jr commented at 10:44 PM on March 22, 2021: member

    C++11 and C++14 require static constexpr data members to have an explicit definition, however master has moved on to C++17 (which deprecates this), and most instances seem to build fine in practice (perhaps only with optimisations enabled?). The only time I have seen it cause a build failure, is with the new Speedy Trial activation code, and fixing the affected variables there would be trivial in comparison to fixing them throughout the whole codebase. So I'm not sure if it's worth the effort to fix this for 0.20/0.21.

  2. luke-jr added the label Bug on Mar 22, 2021
  3. bitcoin deleted a comment on Mar 24, 2021
  4. MarcoFalke commented at 2:54 PM on August 5, 2022: member

    The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

    Closing due to lack of interest. Pull requests with improvements are always welcome.

  5. MarcoFalke closed this on Aug 5, 2022

  6. bitcoin locked this on Aug 5, 2023
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me