0.21 #21518

pull avainlakech wants to merge 60 commits into bitcoin:master from bitcoin:0.21 changing 102 files +8537 −2370
  1. avainlakech commented at 1:09 AM on March 24, 2021: none

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. dfsdfdfs GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. build: Bump version for 0.21.0rc1
    Tree-SHA512: 5bfe150de6e808a6af499e1f01fbfde91fca3fd726e3d457172e94161c4a18fb508824a4b2a58a35ac582d505e4e9da1287a349b51be863dc5bd4fa858400863
    463b316822
  3. doc: Generate manual pages for 0.21.0rc1
    Tree-SHA512: d3e4f927d39f38317242b376f7cbd04ff3ab2b5795ffb5912a1e193b3bc27fa0e7fe55446b62c22df6a213509c2c489a66cde866992706a6ddd0ebbddc713303
    6cde7bb9b2
  4. build: Set msvc builds's CLIENT_VERSION_IS_RELEASE
    Of course, this one was in another place too.

Tree-SHA512: 87784829b1f700dcf5fd22daad0c920cfb25485ae17eff0b3e236513dc543c8643e568f39d418d43ea0eeb330fcac93ab2276cda8253ec6538d01e20d102d10c
    80496f9e81
  5. Merge #20431: [backport 0.21] tests: shrink feature_taproot transfer of funds tx
    7ffac12545328cadd92a3caec4f1c6ca7c127493 tests: shrink feature_taproot transfer of funds tx (Anthony Towns)

Pull request description:

  Github-Pull: #20428
  Rebased-From: 7ffac12545328cadd92a3caec4f1c6ca7c127493

Top commit has no ACKs.

Tree-SHA512: 4e6b37a44dca3e29d5168b7eb9238a7ce0bbb9b0924a21671537a7c534790fb6b05b1a30a404db434fade030b4f369adfc73694ef85d91884bb7349adddc5f6a
    bf9548bc59
  6. Fix QPainter non-determinism on macOS
    Aplies a patch to Qt that fixes the non-determinism by modifying Qt. The
source of the non-determinism is how LLVM 8 optimizes qt_intersect_spans
when compiling. The particular optimization that seems to be causing the
problems is that a temp variable is being added for spans->y. For some
reason, when it does this, it chooses different instructions to use when
making that variable. We bypass this problem by patching
qt_intersect_spans to always make and use this local variable.

Github-Pull: #20447
Rebased-From: 8f7d1b39efbe65ab2747c593cc3560d4a449a333
Tree-SHA512: 558da5c2bb0373e2a89f2c219170f802036e0e87cc8e808336b23d074152cb893007a440f46ec957156b0921355cd18502710f2d224f27bc26e934c50ebebc41
    ab23a83400
  7. Merge #20475: [backport] RPC: unloadwallet: Clarify docs/error when both the RPC endpoint and wallet_name parameter specify a wallet
    b1f59d55d920d2b35269b474762f94fec87bfb16 RPC/Wallet: unloadwallet: Clarify docs/error when both the RPC endpoint and wallet_name parameter specify a wallet (Luke Dashjr)

Pull request description:

  Github-Pull: #20462
  Rebased-From: b1f59d55d920d2b35269b474762f94fec87bfb16

Top commit has no ACKs.

Tree-SHA512: 2ee0a8a280f56baf196a3a48a59620f297075d23898e6aa3b3e677cdde74826688614d27a477a1448306234c2109fa39083946f691ced10d8bbc53006730784e
    3fae2f95f1
  8. Merge #20479: Fix QPainter non-determinism on macOS (0.21 backport)
    ab23a83400d5ad13137ce0f9697a51f0b70e9d29 Fix QPainter non-determinism on macOS (Andrew Chow)

Pull request description:

  Aplies a patch to Qt that fixes the non-determinism by modifying Qt. The
  source of the non-determinism is how LLVM 8 optimizes qt_intersect_spans
  when compiling. The particular optimization that seems to be causing the
  problems is that a temp variable is being added for spans->y. For some
  reason, when it does this, it chooses different instructions to use when
  making that variable. We bypass this problem by patching
  qt_intersect_spans to always make and use this local variable.

  Github-Pull: #20447
  Rebased-From: 8f7d1b39efbe65ab2747c593cc3560d4a449a333
  Tree-SHA512: 558da5c2bb0373e2a89f2c219170f802036e0e87cc8e808336b23d074152cb893007a440f46ec957156b0921355cd18502710f2d224f27bc26e934c50ebebc41

ACKs for top commit:
  jonasschnelli:
    codereview ACK ab23a83400d5ad13137ce0f9697a51f0b70e9d29
  achow101:
    ACK ab23a83400d5ad13137ce0f9697a51f0b70e9d29

Tree-SHA512: 10991fe2b5452b1393678c315281cfdca011e9bb2cd8094a002746e690890ace148ac2dbf39c5fbe5e7f4cd39eeebfa0a715c065cff150cf70e9733cb0ff32d6
    17294c1820
  9. build: Bump RC to rc2
    Tree-SHA512: 122ccac91708dda65a30aab6313c770008ccc0571402d92bc24fbefed578002626899c1754676118f5a456a63dbea84d1fe2fef46af57b77837f438c6e637b26
    ba19f9b490
  10. qt: Pre-rc2 translations update
    Tree-SHA512: 465a7b586f3eff476bd9648ff70e37e11f51e67f048dc1265ffcc1132c4e063515495ec6cbdf6ebb4abd5f5b08615595ce12273ce9abebc8ffef9c7b8375ac20
    7264bcd20f
  11. Merge #20486: [backport] test: Fix intermittent issue in mempool_compatibility
    fa05d19bd6ba619bb3f9aabc05c439cd18d34544 test: Fix intermittent issue in mempool_compatibility (MarcoFalke)

Pull request description:

  Github-Pull: #20456
  Rebased-From: fa05d19bd6ba619bb3f9aabc05c439cd18d34544

Top commit has no ACKs.

Tree-SHA512: c07ed3ffab315da2bf70427882e2da8216964fef97dd538d7c46c5d5b3563b0732626ffbe4b0e19537ad49a8542eedb3c08850cccacdef466f24582defe99d22
    4e964094db
  12. Merge #20485: [backport] wallet: Do not treat default constructed types as None-type
    fa69c2c78455fd0dc436018fece9ff7fc83a180d wallet: Do not treat default constructed types as None-type (MarcoFalke)
fac4e136fa3d0fab7fde900a6be921313e16e7a6 refactor: Change pointer to reference because it can not be null (MarcoFalke)

Pull request description:

  Github-Pull: #20410
  Rebased-From: fac4e136fa3d0fab7fde900a6be921313e16e7a6

  Github-Pull: #20410
  Rebased-From: fa69c2c78455fd0dc436018fece9ff7fc83a180d

Top commit has no ACKs.

Tree-SHA512: 05c3fe29677710b57dcc482fd529b0ab79475519f60f9cfde19f956c4e2212d09b042af458ec4f1272c581360ce841b735dca4df144e0798b3ccf16547de9cd0
    d47d16025e
  13. Merge #20490: [backport] wallet: upgradewallet fixes, improvements, test coverage
    ca8cd893bb56bf5d455154b0498b1f58f77d20ed wallet: fix and improve upgradewallet error responses (Jon Atack)
99d56e357159c7154f69f28cb5587c5ca20d6594 wallet: fix and improve upgradewallet result responses (Jon Atack)
2498b04ce88696a3216fc38b7d393906b733e8b1 Don't upgrade to HD split if it is already supported (Andrew Chow)
c46c18b788cb0862aafbb116fd37936cbed6a431 wallet: refactor GetClosestWalletFeature() (Jon Atack)

Pull request description:

  Github-Pull: #20403
  Rebased-From: c46c18b788cb0862aafbb116fd37936cbed6a431

  Github-Pull: #20403
  Rebased-From: 2498b04ce88696a3216fc38b7d393906b733e8b1

  Github-Pull: #20403
  Rebased-From: 99d56e357159c7154f69f28cb5587c5ca20d6594

  Github-Pull: #20403
  Rebased-From: ca8cd893bb56bf5d455154b0498b1f58f77d20ed

Top commit has no ACKs.

Tree-SHA512: b18a1d015c963298740c585385eaa056988464112c88a519fe619be22dc78a8f6a102365cf799c50b781a77a09bec82b58ce411ab007b48f8b5de876e9c75060
    9facca3ce0
  14. build: Avoid secp256k1.h include from system
    GitHub-Pull: #20469
Rebase-From: e95aaefe2540cb76969818fcc2ff77d33448ed5a
    01b647b1a2
  15. Allow zero-fee fundrawtxn and walletcreatefundedpsbt calls
    A check to raise an error on zero-fee txns was mistakenly extended in commit
a0d4957 from the bumpfee and send{toaddress, many} RPCs to also include
fundrawtransaction and walletcreatefundedpsbt.

This commit overrides zero fee rate checking for these two RPCs, not only for
the feeRate (BTC/kvB) arg to return to previous behavior, but also for the new
fee_rate (sat/vB) arg.

Github-Pull: #20426
Rebased-From: 1b3d7009280595108eb22ac1188bc43678
    54e1edcc2b
  16. Update feeRate (BTC/kvB) to fee_rate (sat/vB) in wallet_bumpfee
    as the feeRate argument should soon be deprecated.

Also loosen one test (and a similar one) that caused a one-off CI failure with:
expected message
'Insufficient total fee 0.00000141, must be at least 0.00001704 (oldFee 0.00000999 + incrementalFee 0.00000705)'
actual message
'Insufficient total fee 0.00000141, must be at least 0.00001712 (oldFee 0.00001007 + incrementalFee 0.00000705)'

Github-Pull: #20426
Rebased-From: 3f1e10b2b1cd11f7112fbad6355464bd4adbbc5c
    6e4969f76f
  17. Use the correct incremental fee constant in bumpfee help
    and remove redundant units ("Must be at least 1.000 sat/vB sat/vB" -> "1.00 sat vB")

Github-Pull: #20426
Rebased-From: 9f08780dd7946b63476e9736745131db8e7f4e93
    6313362553
  18. Merge #20505: [backport] build: Avoid secp256k1.h include from system
    01b647b1a20bbf1de2f5f4624c34b554ad3790f2 build: Avoid secp256k1.h include from system (Niklas Gögge)

Pull request description:

  Backports #20469 to the 0.21 branch.

ACKs for top commit:
  hebasto:
    ACK 01b647b1a20bbf1de2f5f4624c34b554ad3790f2, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: c098055b5e413be6f438d1d43e80c1943329ebb708531d8d82e72de402bddeb6f8b812303f9ae5a45abf62b3ff87fa909fbbf7fb56dca7959ecb9061febae4a1
    68bd88597a
  19. Merge #20510: [backport] wallet: allow zero-fee fundrawtransaction/walletcreatefundedpsbt and other fixes
    6313362553d91bddb75a43f62dffbec16065e4d6 Use the correct incremental fee constant in bumpfee help (Jon Atack)
6e4969f76f58518d47ce2f2cdfc4e3ef1f2228bd Update feeRate (BTC/kvB) to fee_rate (sat/vB) in wallet_bumpfee (Jon Atack)
54e1edcc2bca76f783170768e65bf0850b036b81 Allow zero-fee fundrawtxn and walletcreatefundedpsbt calls (Jon Atack)

Pull request description:

  Github-Pull: #20426
  Rebased-From: 1b3d7009280595108eb22ac1188bc4367804fc5d

  Github-Pull: #20426
  Rebased-From: 3f1e10b2b1cd11f7112fbad6355464bd4adbbc5c

  Github-Pull: #20426
  Rebased-From: 9f08780dd7946b63476e9736745131db8e7f4e93

Top commit has no ACKs.

Tree-SHA512: 89556f69ca4a36d86d6ab5df740b6d5de809f13d45b03450fb526362b1eabd3d2d5285f97c552dc0bcb07e17ac2e6c557ff46335962e6bcf366d36ad412f257c
    aa4b8ebfec
  20. Don't send 'sendaddrv2' to pre-70016 software
    Github-Pull: #20564
Rebased-From: c5a89196602e43ebb1cdc9cd4f08d153419c13e1
    9e806887a8
  21. Send and require SENDADDRV2 before VERACK
    See the corresponding BIP change: https://github.com/bitcoin/bips/pull/1043

Github-Pull: #20564
Rebased-From: 1583498fb6781c01ca2f33c09319ed793964c574
    bead935470
  22. wallet, bugfix: allow send to take string fee rate values
    Github-Pull: #20573
Rebased-From: ce207d6b93d35bc02fcd2dd28f1fd95869261d43
    06c84232b3
  23. test: add coverage for passing fee rate as a string
    Github-Pull: #20573
Rebased-From: 6fa72ceb8021c3b5aea62f6cfe92665c29212923
    0d3c140c4d
  24. Improve heuristic hex transaction decoding
    Whenever both encodings are permitted, try both, and if only one succeeds,
return that one. Otherwise prefer the one for which the heuristic sanity
check passes. If that is the case for neither or for both, return the
extended-permitting deserialization.

Github-Pull: #20595
Rebased-From: 39c42c442044aef611d03ee7053d2dd6df63deb7
    1caa32e3f2
  25. Add regression test for incorrect decoding
    Github-Pull: #20595
Rebased-From: 0f949cde3dff15170db7930b0f7345ff995c267d
    ce13b99020
  26. Don't set BDB flags when configuring without
    Github-Pull: #20478
Rebased-From: 982e548a9a78b1b0abad59b54c780b6b06570452
    61e316e661
  27. build: Check that Homebrew's berkeley-db4 package is actually installed
    Github-Pull: #20563
Rebased-From: d3ef947524a07f8d7fbad5b95781ab6cacb1cb49
    96124a2041
  28. build, refactor: Check that Homebrew's qt5 package is actually installed
    This change unifies Homebrew packages workflow, and does not change
behavior.

Github-Pull: #20527
Rebased-From: c96d1f65a552712f8476269ad64a415717ead50d
    48f8929aad
  29. build: Use Homebrew's sqlite package if it is available
    Github-Pull: #20527
Rebased-From: ee7b84e63cbeadd5e680d69ff0548275581e9241
    f51e1cb291
  30. doc: Update wallet database installation guide for macOS
    Github-Pull: #20527
Rebased-From: c932e0d67e4b369e4265267da6c8bebac2b6fb53
    48134a09ad
  31. Merge #20612: [0.21] final rc3 backports
    48134a09adef3b5302cdd6e95500db404c9ac961 doc: Update wallet database installation guide for macOS (Hennadii Stepanov)
f51e1cb2917bbd7b0966a7ad688e04fc3ce02ccf build: Use Homebrew's sqlite package if it is available (Hennadii Stepanov)
48f8929aade118469cb0014e78a15b4e71fdd17d build, refactor: Check that Homebrew's qt5 package is actually installed (Hennadii Stepanov)
96124a204193ed114ca9594df7d5151206990e91 build: Check that Homebrew's berkeley-db4 package is actually installed (Hennadii Stepanov)
61e316e66168be593fcc90b90217062fa9d993dc Don't set BDB flags when configuring without (Jonas Schnelli)
ce13b99020df8d46a9b594add3c49e38d4601b42 Add regression test for incorrect decoding (Pieter Wuille)
1caa32e3f2a74cd5700a4afe8ecf650f9020fb5c Improve heuristic hex transaction decoding (Pieter Wuille)
0d3c140c4db051fb33c2935ad9536f0f4aa2a8c5 test: add coverage for passing fee rate as a string (Jon Atack)
06c84232b310e6196c814894537ad935d773fe98 wallet, bugfix: allow send to take string fee rate values (Jon Atack)
bead93547067e4b62b44fba335f1d4697119c2d7 Send and require SENDADDRV2 before VERACK (Pieter Wuille)
9e806887a8f9ef63431b28d7dfd0470aa663dd02 Don't send 'sendaddrv2' to pre-70016 software (Pieter Wuille)

Pull request description:

ACKs for top commit:
  laanwj:
    ACK 48134a09adef3b5302cdd6e95500db404c9ac961

Tree-SHA512: 92f1199b96ab7775f88e882ec7fedf43118a4b8452d1c8d0b1cf072d8de153bbb601c7381bc1c5c80c93803c6f9942d54646e9c74e3a6703ce13854fb383fd5e
    3fee499bc3
  32. gui: pre-rc3 translations update
    Tree-SHA512: 2aba5a743ecc1f9e336b8db036640182eb3e85449d9ab4c883c97e6ac75466760939b29c18560205d25489d58091212f7f1dcf651388deb675f824703c943cbf
    e6d0fa3ef6
  33. build: Bump RC to rc3
    Tree-SHA512: a6d81259e17c6b55b33c638a9054eaee2f82322ce0482a73f85562cd56efeb73e2b19b3f7b44fd97e7caa6e757573a8c13ae8967b1e6492f2483d2e057d96c87
    9ae536d368
  34. Move signet onion seed from v2 to v3
    Github-Pull: #20660
Rebased-From: 3e6657a14d501c6315ab46ffe7d204684491c710
    8273ea3b8d
  35. This change to the appveyor CI config for msvc builds reverses a change introduced in #19960. It re-applies a setting to inform vcpkg to only build release vesions of the dependencies rather than the default of debug and release.
    It had been expected that the vcpkg manifest mechanism introduced in #19960 would do this automatically but it turns out not to be the case.

Github-Pull: #20489
Rebased-From: fa18e7cbc5ea6aaba94dca4ebdc850c9db141f89
    e7b53d4721
  36. Adjusted msvc compiler and linker settings to remove optimisations that are causing sporadic ABI issues on Visual Studio updates.
    Tidied up debug and release configuration blocks in common project file to avoid duplication.

Updated appveyor config to use latest Visual Studio 2019 image.

Changed appveyor config file hash to use a new version of Qt pre-compiled binaries built for Visual Studio 2019 v16.8.1.

Bumped vcpkg version to tag '2020.11-1' for binary caching feature.

See #20392 for related discussion.

Github-Pull: #20506
Rebased-From: 8b99e609e7da5dd3601e9214d8f869e96108fffe
    249d61a382
  37. Removed redundant git pull from appveyor config.
    Github-Pull: #20506
Rebased-From: 2c69381f3de5091e103cb8bef299aba321503e7c
    85dabd1249
  38. doc: Add warnings for http interfaces limitations
    Github-Pull: #19050
Rebased-From: 5c3eaf9983043db1b61a98c95d692a6958670b86
    e4440eb67b
  39. doc: warn that incoming conns are unlikely when not using default ports
    Github-Pull: #20668
Rebased-From: 010eed3ce03cf4fc622a48f40fc4d589383f7a44
    84e8d5467f
  40. doc: update tor.md address examples from onion v2 to v3
    Github-Pull: #19961
Rebased-From: e1765d8b04fe1fb775f3750e0fa59f13a58eb176
    0c1fa78af1
  41. doc: add tor.md section on how to get tor info via bitcoind
    Github-Pull: #19961
Rebased-From: dc8a591222f249da81c7eef8aa5961f8d7dd1e23
    2c8482d0a2
  42. doc: update -externalip documentation in tor.md
    Github-Pull: #19961
Rebased-From: a34eceb4cc054b4233e7321de927e8a7a2146301
    e70ccb0bc4
  43. Add patch to make codesign_allocate compatible with Apple's
    Github-Pull: #20644
Rebased-From: a4118c6e200e02e7560f8bc213697aa2909d95b1
    35a10e4ebc
  44. qt: Align layout of checkboxes
    Github-Pull: bitcoin-core/gui#155
Rebased-From: e71b656f317f38ef0ba0874736f116dae39efc67
    ef7a155cf0
  45. rpc: Add missing description of vout in getrawtransaction help text
    Github-Pull: #20731
Rebased-From: b23349b8804fb60c6b3d7d0e2a95927a0d1b49b9
    1fda7db64f
  46. [doc] Add permissions to the getpeerinfo help.
    This field was already being returned, but the RPCHelpMan did not indicate
this. So, this PR updates the help text to match.

Github-Pull: #20756
Rebased-From: 667d203687708390bc0f43f2dd3f4ab427b88338
    b1c0f97483
  47. Merge #20669: [0.21] final rc4 backports
    b1c0f97483f01f8836e5d83e98c881e44018cde5 [doc] Add permissions to the getpeerinfo help. (Amiti Uttarwar)
1fda7db64f0f30c23724f6db14f8a49d3975c716 rpc: Add missing description of vout in getrawtransaction help text (Ben Carman)
ef7a155cf06bf54fff4ff9fda9b28207fcc9adfb qt: Align layout of checkboxes (Hennadii Stepanov)
35a10e4ebc9da916c470d2a9e5b68c3cfc3efd02 Add patch to make codesign_allocate compatible with Apple's (Pieter Wuille)
e70ccb0bc4b695cd331aeda6d7aa405fa6d8f2e7 doc: update -externalip documentation in tor.md (Jon Atack)
2c8482d0a279d07a814eaaae231c90d3d2058e55 doc: add tor.md section on how to get tor info via bitcoind (Jon Atack)
0c1fa78af1c413c848359df76f4d55f819b9fad5 doc: update tor.md address examples from onion v2 to v3 (Jon Atack)
84e8d5467fcec3b7c8ce950cd7a3e7e7b24452a3 doc: warn that incoming conns are unlikely when not using default ports (Adam Jonas)
e4440eb67b339fdacb2c1476f8f909a009c6a47f doc: Add warnings for http interfaces limitations (Fabian Jahr)
85dabd12494a0d82a8f5883cee1c1ff29fb81b27 Removed redundant git pull from appveyor config. (Aaron Clauson)
249d61a382014c15025fe63025ac5f46d4721262 Adjusted msvc compiler and linker settings to remove optimisations that are causing sporadic ABI issues on Visual Studio updates. (Aaron Clauson)
e7b53d47218301790bfec44d50219561502922ad This change to the appveyor CI config for msvc builds reverses a change introduced in #19960. It re-applies a setting to inform vcpkg to only build release vesions of the dependencies rather than the default of debug and release. (Aaron Clauson)
8273ea3b8db1449b65cf369e541a1253c4490f45 Move signet onion seed from v2 to v3 (Sjors Provoost)

Pull request description:

  The remaining backports to get rc4 out. Currently only waiting on the macOS build fix.

ACKs for top commit:
  benthecarman:
    ACK b1c0f97483f01f8836e5d83e98c881e44018cde5
  Sjors:
    ACK b1c0f97

Tree-SHA512: 53eaecd531ba461678917cb630d67f1e6bb737d64022abe971eaced6eca366c9ed593e44276bd9c7ad7b3aebe3850d2d29282eb310e10b547986d10fe77a8482
    ac125e960f
  48. qt: Pre-rc4 translations update
    Tree-SHA512: 14259d2f469ea588f364f64fdd89b90cbcde8f66ddc011d96d656a06920584c0577e64fa15a41a1dc1c8c8a98a1f955748c61def6807b1bb71b0113bb28268f2
    93ce429f0e
  49. build: Bump RC to rc4
    Tree-SHA512: f22375573f1737d64b62351cdec58f0f3e17d9f21b044430f366cbf272514369b73f24cc34e499e2637f0a0fa57ce5b925dd2df8ba0265b1b9c37beb7c8b8e22
    212525337e
  50. doc: Generate manual pages for 0.21.0rc4
    Tree-SHA512: c2ff50dbb54c42db9d56f1fcb0d8a2ce9c89089254f1a6b6f2aa98959f47699cd72c7771b53490232938b45d9bb030ce7fe08707c62190e68ada0ddbd8b6e13a
    e6ad8a6220
  51. Revert "Add patch to make codesign_allocate compatible with Apple's"
    This reverts commit a4118c6e200e02e7560f8bc213697aa2909d95b1.

Github-Pull: #20855
Rebased-From: a0eb4c551ebf8adfacb8c38c4ce56641fe379667
    3308718a6b
  52. Merge #20850: [0.21] final rc5 backports
    3308718a6b41f09e9dd3c7caa9986cd6cb8f2eeb Revert "Add patch to make codesign_allocate compatible with Apple's" (Pieter Wuille)

Pull request description:

ACKs for top commit:
  jonasschnelli:
    ACK 3308718a6b41f09e9dd3c7caa9986cd6cb8f2eeb
  fanquake:
    ACK 3308718a6b41f09e9dd3c7caa9986cd6cb8f2eeb

Tree-SHA512: 2a1002499e6f0da6e9ac7ae393e478bd34e55390ff1a41c5b16b4e91e339fef4b82642237af6725507337cadf9ddc1f2f23b2512d8dd47e5a345770c6c0d1b02
    6e28714da3
  53. build: Bump RC to rc5
    Tree-SHA512: ed01a7a66e5d064c77c948b87afce832b33852005ec1dc556bf4fcc69fa3743aaa6dea4c03a5d2d520682d8de9c7596f1eec3db326caf754726d1ca4aab2cec3
    4e7b4ce7eb
  54. qt: Pre-rc5 translations update
    Tree-SHA512: f6986d00a9565ee7fbf8dd2766dca9c90af931e2dc2fdc0faf5734a2e9be1a0e0774031a20207aa2afa645f1d6229aac9751c84ada324a8dcb463497fb9f237f
    15877d160c
  55. doc: Move 0.21.0 release notes from wiki 66e6742a27
  56. Merge #20929: doc: Move 0.21.0 release notes from wiki
    66e6742a273796e9bdab37b4ad9e05cf18a99981 doc: Move 0.21.0 release notes from wiki (Wladimir J. van der Laan)

Pull request description:

  These were the contents of https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.21.0-Release-Notes-Draft, minus the paragraph about gauging how fast taproot can be deployed.

Top commit has no ACKs.

Tree-SHA512: d7bb61a76d87cb9d9e43602bf81b51ea463e3a098748e42440950d08e6f6e84bf6c02b07b297ac959f979aa72682775dd2ae2be6d30b22977ed60ed454b9c66d
    91f0632464
  57. build: Bump RC to 0 (-final)
    Tree-SHA512: 1a626b9bb7fb04ece4acb24ffcfed178cc5128d16af6860ed37097b6ed36be8b33797bd70a6da0364cd6a9246ebc02fbb83f9523abf5f8dc3c7a524a58416a8f
    95ea54ba08
  58. doc: Archive release notes, Add template for minor release b6d3502993
  59. Merge #20933: [0.21] doc: Archive release notes, Add template for minor release
    b6d35029932ef245e040723dc924be2db4928666 doc: Archive release notes, Add template for minor release (MarcoFalke)

Pull request description:

  Same as #20931, but also clearing the template

ACKs for top commit:
  laanwj:
    ACK b6d35029932ef245e040723dc924be2db4928666

Tree-SHA512: 929d2f774904b58d62dd60d4dcf8447f7e40d959596f3f97462076627d89549ad39dc39c56456f4c8861353cfdf6633abca0be3e84a783f174be1ee1b8d213a4
    7d8a10a6f4
  60. tests: Add fuzzing harness for versionbits
    Github-Pull: #21380
Rebased-From: 1639c3b76c3f2b74606f62ecd3ca725154e27f1b
    e775b0a6dd
  61. Merge #21490: [0.21] Backport versionbits tests
    e775b0a6dd8358df0e8921739faf15942027239e tests: Add fuzzing harness for versionbits (Anthony Towns)
0c471a5f306044cbd2eb230714571f05dd6aaf3c tests: check never active versionbits (Anthony Towns)
3ba9283a47ac358168db9db7840ae559f443486c tests: more helpful errors for failing versionbits tests (Anthony Towns)

Pull request description:

  Backport of unit test (#21334) and fuzz test (#21380) changes for versionbits.

Top commit has no ACKs.

Tree-SHA512: b68b570e48e0076bb2ade3b91c59612029235d2c9e39048d548aa141fa0906343fa492e9a981065fbdbbebecbbb3dcbaf39ec69228c7581178fcca567e8201b8
    1bad33f952
  62. fanquake closed this on Mar 24, 2021
  63. fanquake locked this on Mar 24, 2021
Contributors
avainlakech
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-29 03:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me