Bitcoin-Qt: display units in transaction list #2156

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:tx_units changing 1 files +1 −1

Diapolo commented at 8:28 PM on January 7, 2013: none

Displays e.g. 0.05604678 BTC instead of just 0.05604678 (uses the unit selected in the settings dialog).
Bitcoin-Qt: display units in transaction list bd8f72b29b
luke-jr commented at 8:42 PM on January 7, 2013: member

NACK, this wastes screen space for no benefit (since values are always shown with the same unit). An option might be okay, but I can't imagine why it would be enabled unless/until Bitcoin-Qt supports displaying mixed units in the transaction list. Note that Spesmilo had options for these, so I am speaking here from personal experience having had these options available for months before Bitcoin-Qt was created.
Diapolo commented at 8:49 PM on January 7, 2013: none

As always my pulls are offers, if they get discussed and NACKed / ACKed im fine, as long as there is some feedback :).
BitcoinPullTester commented at 8:53 PM on January 7, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/bd8f72b29b9ba4680b5596086eb167b4bbad9f5d for binaries and test log.
laanwj commented at 9:14 PM on January 7, 2013: member

If you want to show units in a table, add (btc) to the header, don't repeat it every row that's very cluttered.
Diapolo commented at 10:19 PM on January 7, 2013: none

@laanwj You are absolutely right, bad idea here :).
Diapolo closed this on Jan 7, 2013
DrahtBot locked this on Sep 8, 2021

Contributors