Display tx nLockTime correctly when set to block # #2159

pull petertodd wants to merge 1 commits into bitcoin:master from petertodd:display-nlocktime-correctly changing 4 files +6 −4

petertodd commented at 9:32 AM on January 9, 2013: contributor

Previously when a transaction was set to lock at a specific block the calculation was reversed, returning a negative number. This broke the UI and caused it to display %n in place of the actual number.

In addition the previous calculation would display "Open for 0 blocks" when the block height was such that the next block created would finalize the transaction. Inserted the word "more" and changed the calculation so that the last message would be "Open for 1 more block" to better match user expectations.

If you don't feel invalidating the translations is worth it, let me know and I'll back that part of the change out.

Display tx nLockTime correctly when set to block #

Previously when a transaction was set to lock at a specific block the
calculation was reversed, returning a negative number. This broke the UI
and caused it to display %n in place of the actual number.

In addition the previous calculation would display "Open for 0 blocks"
when the block height was such that the next block created would
finalize the transaction. Inserted the word "more" and changed the
calculation so that the last message would be "Open for 1 more block" to
better match user expectations.

10046e27db

BitcoinPullTester commented at 9:48 AM on January 9, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/10046e27dbc10270f59385231736da2a9a327a8f for binaries and test log.
laanwj commented at 10:49 AM on January 9, 2013: member

Ack
Diapolo commented at 2:12 PM on January 9, 2013: none

ACK
gavinandresen referenced this in commit e4f2b6b08f on Jan 14, 2013
gavinandresen merged this on Jan 14, 2013
gavinandresen closed this on Jan 14, 2013
petertodd deleted the branch on Jan 14, 2013
laudney referenced this in commit 56e54689a8 on Mar 19, 2014
owlhooter referenced this in commit 1deab35186 on Oct 11, 2018
DrahtBot locked this on Sep 8, 2021

Contributors