Remove fClient #2161

pull sipa wants to merge 1 commits into bitcoin:master from sipa:noclient changing 3 files +14 −33
  1. sipa commented at 6:42 PM on January 9, 2013: member

    Client (SPV) mode never got implemented entirely, and whatever part was already working, is likely not been tested (or even executed at all) for the past two years. This removes it entirely.

    If we want an SPV implementation, I think we should first get the block chain data structures to be encapsulated in a class implementing a standard interface, and then writing an alternate implementation with SPV semantics.

  2. BitcoinPullTester commented at 7:02 PM on January 9, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/74102ce089021edd05214c2f0c19b96b11659fc3 for binaries and test log.

  3. gavinandresen commented at 8:57 PM on January 9, 2013: contributor

    ACK, but I think you should collapse the empty curly braces.

  4. Remove fClient
    Client (SPV) mode never got implemented entirely, and whatever part was already
    working, is likely not been tested (or even executed at all) for the past two
    years. This removes it entirely.
    
    If we want an SPV implementation, I think we should first get the block chain
    data structures to be encapsulated in a class implementing a standard interface,
    and then writing an alternate implementation with SPV semantics.
    c2b72ba27f
  5. sipa commented at 9:34 PM on January 9, 2013: member
  6. jgarzik commented at 9:41 PM on January 9, 2013: contributor

    ACK

  7. jgarzik commented at 9:42 PM on January 9, 2013: contributor

    I was thinking that we should archive satoshi code snippets somewhere, perhaps in contrib/

    He did a bit of fClient work, emailed some code snippets to others, etc. Would be nice to collect the Not Used Yet ones, and not bury them in email boxes or git history.

  8. BitcoinPullTester commented at 9:45 PM on January 9, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c2b72ba27f0b41d15c70818cb974d4fe7188d17c for binaries and test log.

  9. gavinandresen commented at 7:41 PM on January 14, 2013: contributor

    @jgarzik : the fClient work is in the 'blockheaders' branch here. The only code snippet I got from Satoshi is now merged (the signature cache).

  10. gavinandresen referenced this in commit 1b72229797 on Jan 14, 2013
  11. gavinandresen merged this on Jan 14, 2013
  12. gavinandresen closed this on Jan 14, 2013

  13. sipa deleted the branch on May 3, 2013
  14. laudney referenced this in commit b7d554dc3e on Mar 19, 2014
  15. owlhooter referenced this in commit 050cabdf52 on Oct 11, 2018
  16. guruvan referenced this in commit 2ccfffc87d on Nov 8, 2018
  17. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 09:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me