[0.21] Introduce DeferredSignatureChecker and have SignatureExtractorClass subclass it #21640

1. 
   achow101 commented at 10:32 pm on April 8, 2021: member

   Backport of #21166
2. Introduce DeferringSignatureChecker and inherit with SignatureExtractor

   Introduces a DeferringSignatureChecker which simply takes a
   BaseSignatureChecker and passes through everything.
   SignatureExtractorChecker now subclasses DeferringSignatureChecker. This
   allows for all BaseSignatureChecker functions to be implemented for
   SignatureExtractorChecker, while allowing for future signature checkers
   which opreate similarly to SignatureExtractorChecker.
   
   Github-Pull: #21166
   Rebased-From: 6965456c10c9c4025c71c5e24fa5b27b15e5933a

   7de019bc61
3. Test that signrawtx works when a signed CSV and CLTV inputs are present

   Github-Pull: #21166
   Rebased-From: a97a9298cea085858e1a65a5e9b20d7a9e0f7303

   f79189ca54
4. fanquake added the label Backport on Apr 8, 2021
5. fanquake added the label Wallet on Apr 8, 2021
6. fanquake added this to the milestone 0.21.1 on Apr 8, 2021
7. 
   MarcoFalke commented at 7:09 am on April 9, 2021: member

   checked this is a clean cherry-pick did not review ACK f79189ca54524881d52b91679eb9035d6718ce01 🐖

   Signature:

    0-----BEGIN PGP SIGNED MESSAGE-----
    1Hash: SHA512
    2
    3checked this is a clean cherry-pick did not review ACK f79189ca54524881d52b91679eb9035d6718ce01 🐖
    4-----BEGIN PGP SIGNATURE-----
    5
    6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
    7pUhRWAv9ERGSxYEqH7POd+OTvHKZUkcwliybNR3w9C4ausjLhOuAGAx5JCKpFpOm
    8E1OtdbkTqwtmbprauz+h2FJpED5z7wNg+jWb9GEAE4CImgi76qoWvTcwD7L9rNTi
    9PqglbeoNfyfeSSEEcumNKrcR1TNR7V5wewGiexQsvrsWh9+/wyX8yWUBl8ymsGVR
   10tz5CFn58GRVAVpCZmzQ7aHPQAorDMXt1xLvAdmlM4VG70mN7F8Y4WhOzpMtzDelo
   11n9hf2y9RogdaKW3Jt2681sLkTWmcX7zSQjZgCM7I+NGHIUUzV7wZ7vkBBqboJrWo
   12Nom/xsFqMCFd71fvokboKIcU8r7okIbcZJ89l8gfyAD1e6oOfofIU9Ct96QHCzCg
   13BIZWroZM/3/6xqZcWvukLTWLDJ0GrYHx+hGBn57t3DM7bhWLigQrP8Acv1mBWeTx
   14ZeFIqvgFCP1Wq/9QkX8ZVlZq0Ld65gzIaagWx0xgNUtl9TIn6aCCLSBoTH/yEcQL
   15II/vxIuw
   16=K+0J
   17-----END PGP SIGNATURE-----
   

   Timestamp of file with hash e7ba304a85b944cadba0e04ee2a28cc21f95216aebcef175aa42c97cc0e2ad55 -

8. fanquake requested review from instagibbs on Apr 11, 2021
9. RonSherfey approved
10. instagibbs approved
11. 
    instagibbs commented at 0:42 am on April 12, 2021: member

    ACK https://github.com/bitcoin/bitcoin/pull/21640/commits/f79189ca54524881d52b91679eb9035d6718ce01
12. fanquake merged this on Apr 12, 2021
13. fanquake closed this on Apr 12, 2021

    ---

14. DrahtBot locked this on Aug 18, 2022

Contributors
achow101 MarcoFalke RonSherfey instagibbs

Labels
Wallet Backport

Milestone
0.21.1