-daemonwait change to -daemon #21646

1. 
   AlbanAndrieu commented at 9:39 PM on April 9, 2021: none

   -daemonwait change to -daemon

   Bugfix for Ubuntu 20.04 (systemd)

   Tested with : /lib/systemd/system/bitcoind.service

   [Service] ExecStart=/usr/local/bin/bitcoind -daemon \ -pid=/run/bitcoind/bitcoind.pid \ -conf=/etc/bitcoin/bitcoin.conf \ -datadir=/var/lib/bitcoind

   sudo systemctl daemon-reload sudo systemctl start bitcoind

   bitcoin has been built by hand which explain the change to /usr/local/bin/bitcoind when I did my test

   <!-- Reviewable:start -->

   ---

   This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>

   <!-- Reviewable:end -->

2. -daemonwait change to -daemon 26c83f34a2
3. DrahtBot added the label Scripts and tools on Apr 9, 2021
4. fanquake requested review from laanwj on Apr 10, 2021
5. 
   hebasto commented at 1:19 PM on April 10, 2021: member

   @AlbanAndrieu

   What bug exactly is fixed by this PR?

6. 
   AlbanAndrieu commented at 8:51 PM on April 10, 2021: none

   systemd not starting for bitcoin-core on Ubuntu 20.

7. 
   hebasto commented at 3:42 AM on April 11, 2021: member

   @AlbanAndrieu

   systemd not starting for bitcoin-core on Ubuntu 20.

   What is the version of bitcoin-core you are running?

8. 
   laanwj commented at 10:07 AM on April 12, 2021: member

   Can you show a) debug.log excerpt b) the journalctl -u bitcoind -p debug output for using -daemonwait?

   Note that -daemonwait is new functionality that is not currently in any release. The documentation on the master branch matches the master branch, if you are using 0.21.x, use the documentation on the 0.21 branch instead.

   NACK on the code change, the path forward is to fix daemonwait (if it is broken) not to revert the documentation change.

9. 
   AlbanAndrieu commented at 11:45 AM on April 12, 2021: none

   I am using master. If daemonwait is a new which is matching master branch. Forget about my PR. They might be another issue indeed.

10. AlbanAndrieu closed this on Apr 12, 2021

    ---

11. 
    laanwj commented at 12:12 PM on April 12, 2021: member

    It would still be useful to know what issue you are running into.

12. 
    AlbanAndrieu commented at 1:30 PM on April 12, 2021: none

    Yes, when I will get time to have a deeper look. Then I will create another Pull Request

13. DrahtBot locked this on Aug 18, 2022

Review Requested
laanwj