ci: Fix previous releases cache order #21653

1. 
   MarcoFalke commented at 11:56 am on April 11, 2021: member
2. ci: Fix previous releases cache order

   The order was broken in commit ffff4e7373f7c1260e6a8347b4ea1a99db4fff76

   fa4f0b301b
3. 
   MarcoFalke commented at 11:56 am on April 11, 2021: member

   Reported in #21619 (comment) by @hebasto . Thanks!
4. fanquake added the label Tests on Apr 11, 2021
5. 
   hebasto commented at 4:00 pm on April 11, 2021: member

   Concept ACK fa4f0b301ba5c07f1271fa7129d07683014d169b.

   Does the populated cache prevent from downloading releases again: https://github.com/bitcoin/bitcoin/blob/f6c44e999b7d1d9a0de5d678ac8f1679aa271f65/ci/test/05_before_script.sh#L58-L60?

   Maybe the populate_script field could be useful?

6. 
   MarcoFalke commented at 4:04 pm on April 12, 2021: member

   Not sure what you mean. The cache is populated and everything is green: https://cirrus-ci.com/task/6695630107049984?logs=previous_releases#L2
7. 
   MarcoFalke commented at 4:05 pm on April 12, 2021: member

   It is also greeen without cache: https://cirrus-ci.com/task/5560067312320512?logs=previous_releases#L1
8. 
   hebasto commented at 4:34 pm on April 12, 2021: member

   Not sure what you mean.

   Just trying to answer to myself “What is the role of the previous releases cache in the CI setup? Speedup what?”

9. 
   laanwj commented at 6:59 pm on April 12, 2021: member

   I think the idea of the cache is to avoid downloading the previous releases from bitcoincore.org every test run?
10. 
    hebasto commented at 7:15 pm on April 12, 2021: member

    I think the idea of the cache is to avoid downloading the previous releases from bitcoincore.org every test run?

    Agree. But currently it does not work like that.

11. 
    MarcoFalke commented at 4:47 am on April 13, 2021: member

    It does:

    0Releases directory: /tmp/cirrus-build/releases/x86_64-pc-linux-gnu
    1Using cached v0.15.2
    2Using cached v0.16.3
    3Using cached v0.17.2
    4Using cached v0.18.1
    5Using cached v0.19.1
    

    https://cirrus-ci.com/task/6695630107049984?logs=ci#L1993

12. 
    hebasto commented at 9:59 am on April 13, 2021: member

    It does:

    Right. It is responsibility of test/get_previous_releases.py.

13. hebasto approved
14. 
    hebasto commented at 10:00 am on April 13, 2021: member

    ACK fa4f0b301ba5c07f1271fa7129d07683014d169b
15. MarcoFalke merged this on Apr 13, 2021
16. MarcoFalke closed this on Apr 13, 2021

    ---

17. MarcoFalke deleted the branch on Apr 13, 2021
18. sidhujag referenced this in commit 1dc8e0649f on Apr 13, 2021
19. DrahtBot locked this on Aug 18, 2022

Contributors
MarcoFalke hebasto laanwj

Labels
Tests