qa: Test default include_mempool value of gettxout #21712

pull promag wants to merge 1 commits into bitcoin:master from promag:2021-04-gettxout changing 1 files +2 −0

promag commented at 10:47 PM on April 16, 2021: member

With the following diff the functional test would pass. Fix by testing the default value.

--- a/src/rpc/blockchain.cpp
+++ b/src/rpc/blockchain.cpp
@@ -1142,7 +1142,7 @@ static RPCHelpMan gettxout()
     uint256 hash(ParseHashV(request.params[0], "txid"));
     int n = request.params[1].get_int();
     COutPoint out(hash, n);
-    bool fMempool = true;
+    bool fMempool = false;
     if (!request.params[2].isNull())
         fMempool = request.params[2].get_bool();

qa: Test default include_mempool value of gettxout 44dab423eb
DrahtBot added the label Tests on Apr 16, 2021
MarcoFalke commented at 5:50 AM on April 17, 2021: member

cr ACK 44dab423eb88dbf854d22f2991e79c828ffac0f2
MarcoFalke merged this on Apr 17, 2021
MarcoFalke closed this on Apr 17, 2021
sidhujag referenced this in commit 7ea7530b74 on Apr 17, 2021
promag deleted the branch on Apr 19, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

promag

MarcoFalke

Labels

Tests