make database init messages more valuable #2172

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:init_messages changing 1 files +6 −4

Diapolo commented at 10:22 PM on January 11, 2013: none
- it was bad, that quite some messages were just talking about a database, I think a user should know, if we are talking about wallet db or block/coin db
- also adds a new init message for "Verifying block database integrity..."
in src/init.cpp:None in d6916b3112 outdated
```
 751 | @@ -752,10 +752,12 @@ bool AppInit2()
 752 |          pblocktree->WriteReindexing(true);
 753 |  
 754 |      if (!LoadBlockIndex())
 755 | -        return InitError(_("Error loading block/coin databases"));
 756 | +        return InitError(_("Error loading block/coin database"));
```
laanwj commented at 9:47 AM on January 13, 2013:

What about "Error loading block index" (that's what the code says at least)?

Diapolo commented at 9:51 AM on January 13, 2013:

We had that error message you mention before and IMO it was too generic. I guess that is why @sipa chose block/coin DB.

laanwj commented at 9:59 AM on January 13, 2013:

Okay, it's fine then...

sipa commented at 5:03 PM on January 13, 2013:

It's technically two databases, and the problem may be in either or the combination of them. But being correct is probably more confusing and less useful for users. Perhaps we should simply use "block database".

Diapolo commented at 8:17 PM on January 13, 2013:

Good thing about just block database is it won't be larger than our splash screen ^^. I'll update this.
laanwj commented at 9:59 AM on January 13, 2013: member

ACK

make database init messages more valuable

- it was bad, that quite some messages were just talking about a database,
  I think a user should know, if we are talking about wallet db or
  block/coin db
- also adds a new init message for "Verifying block database integrity..."

06494cabb4

Diapolo commented at 8:24 PM on January 13, 2013: none

Updated to use just block database (instead block/coin database) to be better understandable for our users.
BitcoinPullTester commented at 11:05 PM on January 13, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/06494cabb48f005f058cc8e6f6b1b33ee1464e8b for binaries and test log.
sipa commented at 8:14 PM on January 14, 2013: member

ACK
gavinandresen referenced this in commit c83c3cbe97 on Jan 14, 2013
gavinandresen merged this on Jan 14, 2013
gavinandresen closed this on Jan 14, 2013
laudney referenced this in commit cf19f738f7 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors