Error messages for invalid address #21741

issue ghost opened this issue on April 21, 2021

ghost commented at 2:23 AM on April 21, 2021: none
Can we add more information in error messages for invalid address especially the errors mentioned in PR: https://github.com/bitcoin/bitcoin/pull/20832/

Example:

Change https://github.com/bitcoin/bitcoin/blob/f385ad765174afb02e60900581612a19c143cf83/src/key_io.cpp#L103

To
```
error_str = "Invalid prefix for Bech32 address. Valid Bech32 address starts with `bc1` (mainnet) or `tb1` (testnet)";
```
Context: https://github.com/bitcoin-core/gui/pull/280#issuecomment-820957002
unknown added the label Feature on Apr 21, 2021
tylerchambers commented at 1:54 PM on April 21, 2021: contributor

concept ack. error messages should be human readable and actionable. this is a good improvement.
kristapsk commented at 1:19 PM on April 25, 2021: contributor

Concept ACK
brunoerg commented at 10:23 PM on April 29, 2021: contributor

Concept ACK
vincenzopalazzo commented at 10:48 PM on May 4, 2021: none

Concept ack.
ghost commented at 1:12 AM on June 13, 2021: none

4 Concept ACKs for this issue and few reviews in PR: #21755

Will be helpful if you could comment on changes proposed in https://github.com/bitcoin/bitcoin/pull/21755/commits/af9979837d1a9d4844d2701f4eeb7aed353d8af9
brunoerg commented at 2:25 AM on June 13, 2021: contributor

Going to review soon.
maflcko commented at 3:27 PM on August 11, 2022: member

Not sure what the status is. I guess someone needs to rebase #21755?
glozow closed this on Mar 13, 2023
bitcoin locked this on Mar 12, 2024

Contributors

Labels

Linked (view graph)

#20832 rpc: Better error messages for invalid addresses #21755 Add more info about prefix in error message for invalid address #26514 Improve address decoding errors