gui: Node appears as `Unroutable` in peers list

benthecarman commented at 4:08 am on April 22, 2021: contributor

This is using the bitcoin-s node, I am unsure if this is something wrong on our end, or on bitcoin core’s end. Messages are able to be passed back and forth just fine. This is shown for the node running on the local computer and one on a separate computer.

sipa commented at 4:10 am on April 22, 2021: member

This is expected, albeit confusing. It just means that node can’t be reached from the internet (127.0.0.1 is a non-public IP).

benthecarman commented at 4:11 am on April 22, 2021: contributor

This is expected, albeit confusing. It just means that node can’t be reached from the internet (127.0.0.1 is a non-public IP).

How about for the Type? (This is a neutrino node)

sipa commented at 4:12 am on April 22, 2021: member

What type?

benthecarman commented at 4:14 am on April 22, 2021: contributor

What type?

MarcoFalke commented at 6:01 am on April 22, 2021: member

Incoming peers don’t have a type (other than “incoming”). Is this elided? What version are you using?

jonatack commented at 7:55 am on April 22, 2021: member

Right, inbound peers have a connection direction but not type yet, as we can’t infer full relay or block relay status from fRelay / fRelayTxes (Wants Tx Relay in the GUI peer details area or RPC getpeerinfo relaytxes). Discussion here: https://github.com/bitcoin-core/gui/pull/201. These changes were made in January and aren’t in a release yet.

benthecarman commented at 2:33 pm on April 22, 2021: contributor

Incoming peers don’t have a type (other than “incoming”). Is this elided? What version are you using?

This is on e7776e20ed0ddf41d15b3d2df87a92ea6666226c

MarcoFalke commented at 3:39 pm on April 22, 2021: member

Was this bug introduced in https://github.com/bitcoin-core/gui/commit/6fc72bd6f030c8b49e8b9f68188413766a239d73 ?

See also the tested ACKs, which show the empty string here: https://github.com/bitcoin-core/gui/pull/179#issuecomment-780585528

MarcoFalke added this to the milestone 22.0 on Apr 22, 2021

MarcoFalke added the label GUI on Apr 22, 2021

MarcoFalke renamed this:
~~Node appears as `Unroutable` in peers list~~
gui: Node appears as `Unroutable` in peers list
on Apr 22, 2021

MarcoFalke added the label Bug on Apr 22, 2021

jonatack commented at 3:54 pm on April 22, 2021: member

What different behavior are you expecting?

jonatack commented at 4:03 pm on April 22, 2021: member

ISTM this is the expected behavior and the issue can be closed.

MarcoFalke commented at 5:41 pm on April 22, 2021: member

I think the type shouldn’t be empty string but “Inbound”, no?

jonatack commented at 6:08 pm on April 22, 2021: member

We do the same with -netinfo after this topic was discussed in January; direction and type are different columns. For users, inbound/outbound is a direction. I proposed a sortable “Direction” column immediately next to the “Type” column to display Inbound/Outbound rather than the current arrows, it had an enthusiastic reception with ACKs by @hebasto and @jarolrod IIRC, but was opposed by another contributor. I could propose it again, e.g. like https://github.com/bitcoin-core/gui/pull/179#pullrequestreview-564896296 and https://github.com/bitcoin-core/gui/pull/179#pullrequestreview-564822423.

MarcoFalke commented at 8:25 pm on April 22, 2021: member

Ok, closing for now.

If this is an issue, it might be good to file this in the gui repo instead.

MarcoFalke closed this on Apr 22, 2021

MarcoFalke removed this from the milestone 22.0 on Apr 22, 2021

MarcoFalke removed the label Bug on Apr 22, 2021

jonatack commented at 8:30 pm on April 22, 2021: member

Yes, I’ll have a look at this tomorrow over on the GUI repo. Edit: done, hopefully https://github.com/bitcoin-core/gui/pull/289 makes this clearer.

DrahtBot locked this on Aug 18, 2022

gui: Node appears as Unroutable in peers list #21747

gui: Node appears as `Unroutable` in peers list #21747