followups: Various potential improvements arising out of chainman-deglobalizing review #21766

1. 
   dongcarl commented at 8:06 pm on April 23, 2021: contributor

   There are a few potential improvements mentioned by various reviewers of the chainman-deglobalizing work that are deserving of a tracking ticket, but are perhaps either not crucial to the main thrust of the work or the flaws already existed before the work. Let’s discuss and collate them here so that we don’t lose track of them!

   1. m_chain methods should perhaps require holding cs_main
      • #21391 (review)
   2. Ensure*() in src/rpc should be called at the top of functions to fail as early as possible
      • #21391 (review)
      • #21391 (review)
      • #21391 (review)
   3. IncrementExtraNonce does not need cs_main, and the locking scope can be limited
      • #21391 (review)
   4. CoinsDB.Cursor() passes ownership to caller and should return a std::unique_ptr
      • #21391 (review)
   5. Call to GetNetworkHashPS in getnetworkhashps contains many operators, which may increase risk of precedence bugs
      • #21391 (review)
   6. Avoid repeated calls to ActiveChain() where appropriate
      • #21270 (review)
   7. Review whether or not m_blockman member of ChainstateManager needs cs_main to be accessed
      • Various
   8. Review whether or not to support running bitcoin without a chainman
      • #21767 (review)
   9. Investigate how indexing interacts with CChainState
      • #21767 (review)

   Please feel free to comment here for extra ones I’ve missed!

2. maflcko referenced this in commit f63fc53c2a on Jun 1, 2021
3. fanquake referenced this in commit a55904a80c on Jun 12, 2021
4. 
   jnewbery commented at 4:22 pm on June 16, 2021: contributor

   Concept ACK. Please tag me in any PR you open.
5. 
   maflcko commented at 5:51 am on June 17, 2021: member

   4 is addressed in #22263 (can be checked off in OP?)
6. maflcko referenced this in commit 7317e14a44 on Jun 23, 2021
7. sidhujag referenced this in commit 2dabf43c8f on Jun 24, 2021
8. knst referenced this in commit 1dc8f30a96 on Nov 28, 2023
9. knst referenced this in commit 3c189e5fcc on Nov 30, 2023
10. UdjinM6 referenced this in commit 9db6927f05 on Nov 30, 2023
11. PastaPastaPasta referenced this in commit 52c8ef2feb on Dec 4, 2023
12. 
    willcl-ark commented at 9:55 am on January 25, 2024: contributor

    Going to close this tracking issue as all of the changes listed in OP are now merged.
13. willcl-ark closed this on Jan 25, 2024

    ---

Contributors
dongcarl jnewbery maflcko willcl-ark