Bitcoin-Qt: move num TX label to debug window #2177

pull Diapolo wants to merge 2 commits into bitcoin:master from Diapolo:unique_tx_IDs changing 7 files +65 −41

Diapolo commented at 4:06 PM on January 14, 2013: none
- Bitcoin-Qt: remove num transactions from overviewpage
- Bitcoin-Qt: add wallet category and num unique tx IDs in dbg window
-- this adds a new Wallet category to the debug window and implements a label which contains the current unique transaction ID count from the wallet (wallet model access is added to RPCConsole class) -- layout was converted from table to form and a spacer removed -- I also added an initialisation of the model variables in RPCConsole class, these were missing before

I had the idea because of issue #2175 and it also seems nice to be able to access walletmodel from RPCConsole for further additions to the debug window.
laanwj commented at 4:12 PM on January 14, 2013: member

I didn't include any wallet statistics in the debug window (and didn't pass the walletmodel in) on purpose: to make it independent of any wallet, for example when multiple wallet support is added.

Then again, if you think this is useful, these kind of things could be shown per open wallet, i guess...
BitcoinPullTester commented at 4:27 PM on January 14, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/326db1531320092191baa7a9e391404c3c8e8dc4 for binaries and test log.
BitcoinPullTester commented at 3:27 AM on January 24, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/326db1531320092191baa7a9e391404c3c8e8dc4 for binaries and test log.
laanwj commented at 8:48 AM on March 29, 2013: member

Btw, can anyone come up with something fun to add in the overview page? We're making it emptier and emptier,

Maybe a graph or visualization or something? Or a minigame? (j/k on that last one)
Diapolo commented at 8:40 PM on March 29, 2013: none

@laanwj Agreed, the overview page could get some more details or new stuff... I have no great idea yet.
schildbach commented at 9:33 PM on March 29, 2013: contributor

Less is more imho.
Diapolo commented at 9:14 AM on March 30, 2013: none

@schildbach Your vote here, Just remove or move to debug-window?
Bitcoin-Qt: remove num transactions from overviewpage 9be6c8b8a9
schildbach commented at 9:29 AM on March 30, 2013: contributor

The main point is getting rid of useless (for the normal usecase) / confusing info on the main screen.

Imho it can be useful on the debug window, but even then I'd make it more clear that there are different ways to count transactions so the user needs to know which metric this is.
Diapolo commented at 9:45 AM on March 30, 2013: none

The unique transaction IDs counts the IDs only once e.g. payments to yourself generate 2 transactions, but both share the same transaction ID. How is that metric called then ;)?

Bitcoin-Qt: add wallet category and num unique tx IDs in dbg window

- this adds a new Wallet category to the debug window and implements a
  label which contains the current unique transaction ID count from the
  wallet (wallet model access is added to RPCConsole class)
- layout was converted from table to form and a spacer removed
- I also added an initialisation of the model variables in RPCConsole
  class, these were missing before

4483117312

schildbach commented at 9:51 AM on March 30, 2013: contributor

"Number of unique transactions" would make a good label for that imho. And I guess that's the number most developers (= users of the debug screen) will be interested in.
laanwj commented at 5:36 AM on March 31, 2013: member

I'm still for completely removing it, for the sake of minimalism (and due to conflicts with multiple wallet support).
Diapolo closed this on Apr 1, 2013
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#2175 "Number of transactions" sometimes does not match number of entries in transactions list #2433 Remove transaction count from overview page