This PR removes unnecessary flags verification since its value has been fixed (3).
test: remove flags verification since it has a fixed value #21784
pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2021-04-segwit-test changing 1 files +9 −11-
brunoerg commented at 12:53 AM on April 27, 2021: member
-
test: remove flags verification since it has a fixed value 5eb807e6f3
- fanquake added the label Tests on Apr 27, 2021
-
MarcoFalke commented at 6:22 AM on April 27, 2021: member
It might be better to add a comment that the function body is copied 1-1 from somewhere else (and thus shouldn't be changed)
-
brunoerg commented at 2:46 PM on April 27, 2021: member
@MarcoFalke why? is this a pattern?
-
MarcoFalke commented at 4:50 PM on April 27, 2021: member
Yes, I believe this is the witness serialize pattern that Bitcoin Core uses in the source code and tests.
-
laanwj commented at 2:49 PM on June 7, 2021: member
It looks like there is no agreement to make this change. So closing.
- laanwj closed this on Jun 7, 2021
- DrahtBot locked this on Aug 18, 2022
Contributors
Labels