index: Avoid async shutdown on init error #21796

1. 
   MarcoFalke commented at 11:34 am on April 28, 2021: member

   An async shutdown during init is confusing when a simple boolean return value can be used for a synchronous shutdown.

   This also changes the error message on stderr from:

   0Error: A fatal internal error occurred, see debug.log for details
   1Error: A fatal internal error occurred, see debug.log for details
   

   To:

   0Error: basic block filter index best block of the index goes beyond pruned data. Please disable the index or reindex (which will download the whole blockchain again)
   

2. DrahtBot added the label UTXO Db and Indexes on Apr 28, 2021
3. 
   DrahtBot commented at 4:02 pm on April 28, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #21866 ([Bundle 7/7] validation: Farewell, global Chainstate! by dongcarl)
   • #21767 ([Bundle 6/n] Prune g_chainman usage in auxiliary modules by dongcarl)
   • #19064 (refactor: Cleanup thread ctor calls by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   laanwj commented at 2:34 pm on May 5, 2021: member

   Code review ACK—however this introduces two warnings here locally:

   0…/bitcoin/src/test/coinstatsindex_tests.cpp:35:5: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]                                                       
   1    coin_stats_index.Start();                                                                                     
   2    ^~~~~~~~~~~~~~~~~~~~~~                          
   31 warning generated.            
   4…/bitcoin/src/init.cpp:1566:9: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]                                                                          
   5        g_coin_stats_index->Start();                   
   6        ^~~~~~~~~~~~~~~~~~~~~~~~~                
   71 warning generated.  
   

5. MarcoFalke force-pushed on May 5, 2021
6. DrahtBot added the label Needs rebase on May 12, 2021
7. index: Avoid async shutdown on init error faad68fcd4
8. MarcoFalke force-pushed on May 12, 2021
9. 
   MarcoFalke commented at 8:48 am on May 12, 2021: member

   Rebased due to change in adjacent line
10. DrahtBot removed the label Needs rebase on May 12, 2021
11. 
    laanwj commented at 12:54 pm on May 12, 2021: member

    Code review ACK faad68fcd440e77e61a5a1560471417dd984e390
12. laanwj merged this on May 12, 2021
13. laanwj closed this on May 12, 2021

    ---

14. MarcoFalke deleted the branch on May 12, 2021
15. sidhujag referenced this in commit f7405ffcea on May 12, 2021
16. domob1812 referenced this in commit 8e3af343f6 on May 17, 2021
17. gwillen referenced this in commit e56472be53 on Jun 1, 2022
18. DrahtBot locked this on Aug 16, 2022

Contributors
MarcoFalke DrahtBot laanwj

Labels
UTXO Db and Indexes