Remove -deprecatedrpc=addresses flag and corresponding code/logic #21797

1. 
   mjdietzx commented at 2:36 pm on April 28, 2021: contributor

   The following RPCs: gettxout, getrawtransaction, decoderawtransaction, decodescript, gettransaction, and REST endpoints: /rest/tx, /rest/getutxos, /rest/block deprecated the following fields (which are no longer returned in the responses by default): addresses, reqSigs. The -deprecatedrpc=addresses flag must be passed for these fields to be included in the RPC response. This flag/option will be available until v23, at which point the deprecation will be removed entirely. Note that these fields are attributes of the scriptPubKey object returned in the RPC response. However, in the response of decodescript these fields are top-level attributes, and included again as attributes of the scriptPubKey object.

   The original issue #20102 was resolved in this PR #20286, and from v23 (“addresses” and “reqSigs” deprecated) “ExtractDestinations” should be removed.

2. 
   mjdietzx commented at 2:40 pm on April 28, 2021: contributor

   Intent is to add this issue to milestone 23.0. Not sure how to do this or if I’m able to
3. MarcoFalke added this to the milestone 23.0 on Apr 28, 2021
4. 
   MarcoFalke commented at 4:14 pm on April 28, 2021: member

   Branch-off will be in about 60 days (#20851), after which this patch can be merged. Do you want to address this issue yourself or did you file this for someone else to pick up?
5. 
   mjdietzx commented at 4:17 pm on April 28, 2021: contributor

   I’d be happy to address the issue myself. Just figured I’d create an issue to make sure it isn’t forgotten. Anyways I’ll aim to have it ready around branch-off and open the PR then
6. 
   MarcoFalke commented at 7:58 am on August 6, 2021: member

   @mjdietzx Are you still working on this?
7. 
   mjdietzx commented at 2:30 pm on August 6, 2021: contributor

   Yessir, thanks for the heads up. Just opened the PR 😁
8. meshcollider closed this on Sep 28, 2021

   ---

9. DrahtBot locked this on Oct 30, 2022

Contributors
mjdietzx MarcoFalke

Milestone
23.0