Fix #21448
test: Fix feature_config_args.py intermittent issue #21814
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2104-testInt3 changing 1 files +2 −0-
MarcoFalke commented at 8:50 AM on April 30, 2021: member
-
test: Fix feature_config_args.py intermittent issue fab1eb65b1
- fanquake added the label Tests on Apr 30, 2021
-
jonatack commented at 9:04 AM on April 30, 2021: member
Concept ACK, interesting solution.
-
MarcoFalke commented at 9:14 AM on April 30, 2021: member
Yeah, this relies on the "synchronisation-effect" of
assert_debug_log, which I generally dislike because it makes tests harder to read. Though, I couldn't find another solution without modifying bitcoind. -
laanwj commented at 2:41 PM on May 5, 2021: member
Code review ACK fab1eb65b196d62466fdc2ed319ffa19d3560a0c
I don't have any problem using
assert_debug_logfor synchronization. Maybe it could be more apparent by having an explicitly named function (or add a comment?) that synchronizes on a debug log message, but I like using a trigger on process output for synchronization instead of say, polling RPC in a loop. - MarcoFalke merged this on May 5, 2021
- MarcoFalke closed this on May 5, 2021
- MarcoFalke deleted the branch on May 5, 2021
- sidhujag referenced this in commit f502389a98 on May 5, 2021
- gwillen referenced this in commit ad61a8e5bf on Jun 1, 2022
- DrahtBot locked this on Aug 16, 2022
Contributors
Labels