doc: fixup -coinstatsindex help, update bitcoin.conf and files.md #21818

1. 
   jonatack commented at 6:25 pm on April 30, 2021: member
2. doc: add coinstatsindex to bitcoin.conf e041ee0a80
3. DrahtBot added the label Docs on Apr 30, 2021
4. 
   hebasto commented at 6:46 pm on April 30, 2021: member

   It’d be nice to update the doc/files.md as well:

   https://github.com/bitcoin/bitcoin/blob/2b45cf0bcdb3d2c1de46899e30885c953b57b475/src/index/coinstatsindex.cpp#L100

5. 
   jonatack commented at 7:21 pm on April 30, 2021: member

   Good idea @hebasto. Thanks, done.
6. jonatack renamed this:
   doc: fixup -coinstatsindex help, update bitcoin.conf
   doc: fixup -coinstatsindex help, update bitcoin.conf and files.md
   on Apr 30, 2021
7. 
   benthecarman commented at 10:24 pm on April 30, 2021: contributor

   CR-ACK 15796fb87a2f03edc94668eeedaef5249c319f44
8. in src/init.cpp:387 in 15796fb87a outdated

   383@@ -384,7 +384,7 @@ void SetupServerArgs(NodeContext& node)
   384 #endif
   385     argsman.AddArg("-blockreconstructionextratxn=<n>", strprintf("Extra transactions to keep in memory for compact block reconstructions (default: %u)", DEFAULT_BLOCK_RECONSTRUCTION_EXTRA_TXN), ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
   386     argsman.AddArg("-blocksonly", strprintf("Whether to reject transactions from network peers. Automatic broadcast and rebroadcast of any transactions from inbound peers is disabled, unless the peer has the 'forcerelay' permission. RPC transactions are not affected. (default: %u)", DEFAULT_BLOCKSONLY), ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
   387-    argsman.AddArg("-coinstatsindex", strprintf("Maintain coinstats index used by the gettxoutset RPC (default: %u)", DEFAULT_COINSTATSINDEX), ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
   

   ---

   ---

   

   MarcoFalke commented at 7:22 am on May 1, 2021:

   test/functional/rpc_blockchain.py: # muhash should not be included in gettxoutset unless requested.

   ---

   

   MarcoFalke commented at 7:23 am on May 1, 2021:

   (same mistake in the test, that can be fixed as well)

   ---

   

   jonatack commented at 11:58 am on May 1, 2021:

   updating
9. in share/examples/bitcoin.conf:149 in 15796fb87a outdated

   141@@ -142,8 +142,11 @@
   142 # both prior transactions and several dozen future transactions.
   143 #keypool=100
   144 
   145+# Maintain coinstats index used by the gettxoutsetinfo RPC (default: 0).
   146+#coinstatsindex=1
   147+
   148 # Enable pruning to reduce storage requirements by deleting old blocks.
   149-# This mode is incompatible with -txindex and -rescan.
   150+# This mode is incompatible with -txindex, -coinstatsindex and -rescan.
   

   ---

   ---

   

   MarcoFalke commented at 7:23 am on May 1, 2021:

   This is wrong. Indexes are compatible with pruning, if done right.

   ---

   

   jonatack commented at 11:40 am on May 1, 2021:

   If I understand correctly, @fjahr is working on that but for the moment it isn’t the case yet

   src/init.cpp#L403

   0    argsman.AddArg("-prune=<n>", strprintf("Reduce storage requirements by enabling pruning (deleting) of old blocks. This allows the pruneblockchain RPC to be called to delete specific blocks, and enables automatic pruning of old blocks if a target size in MiB is provided.
   1            This mode is incompatible with -txindex, -coinstatsindex and -rescan. "
   2            "Warning: Reverting this setting requires re-downloading the entire blockchain. "
   3            "(default: 0 = disable pruning blocks, 1 = allow manual pruning via RPC, >=%u = automatically prune block files to stay under the specified target size in MiB)", MIN_DISK_SPACE_FOR_BLOCK_FILES / 
   

   src/init.cpp#L888

   0    // If using block pruning, then disallow txindex and coinstatsindex
   1    if (args.GetArg("-prune", 0)) {
   2        if (args.GetBoolArg("-txindex", DEFAULT_TXINDEX))
   3            return InitError(_("Prune mode is incompatible with -txindex."));
   4        if (args.GetBoolArg("-coinstatsindex", DEFAULT_COINSTATSINDEX))
   5            return InitError(_("Prune mode is incompatible with -coinstatsindex."));
   6    }
   

   ---

   

   MarcoFalke commented at 11:51 am on May 1, 2021:

   I presumed that #15946 changed this for all index types, but maybe I am mistaken.

   ---

   

   jonatack commented at 11:55 am on May 1, 2021:

   In principle it seems it should be doable: https://github.com/bitcoin/bitcoin/pull/19521/#discussion_r603607663 (not sure this GitHub link is working so provided in code markdown too)

   https://github.com/bitcoin/bitcoin/pull/19521/#discussion_r603607663

10. doc: fix -coinstatsindex help, and test/rpc touchups 5d1050f516
11. doc: add indexes/coinstats/db/ to files.md 54133c59b8
12. jonatack force-pushed on May 1, 2021
13. 
    Sjors commented at 12:23 pm on May 1, 2021: member

    utACK 54133c59b80ccac85eaebb0668cd2f0fe360b323
14. 
    MarcoFalke commented at 4:27 pm on May 1, 2021: member

    cr ACK 54133c59b80ccac85eaebb0668cd2f0fe360b323
15. 
    clarkmoody commented at 4:40 pm on May 1, 2021: none

    utACK 54133c5
16. fanquake merged this on May 2, 2021
17. fanquake closed this on May 2, 2021

    ---

18. jonatack deleted the branch on May 2, 2021
19. sidhujag referenced this in commit f43e19f0f3 on May 2, 2021
20. gwillen referenced this in commit 3c9222f410 on Jun 1, 2022
21. Fabcien referenced this in commit fab6ec9148 on Jun 13, 2022
22. Fabcien referenced this in commit 80020c9a97 on Jun 13, 2022
23. DrahtBot locked this on Aug 16, 2022

Contributors
jonatack hebasto benthecarman MarcoFalke Sjors clarkmoody

Labels
Docs