doc: Add info about supported format for URI #21819

pull ghost wants to merge 1 commits into bitcoin:master from changing 1 files +1 −1

ghost commented at 6:46 PM on April 30, 2021: none
- Bitcoin Core only supports valid bitcoin address for URI and nothing else
- Only first example will work from BIP 21 and others will give error (Check PR: https://github.com/bitcoin-core/gui/pull/280 or #21755 for new error messages being discussed)

Add info about supported format for URI

+ Bitcoin Core only supports valid bitcoin `address` for URI
+ Only first example will work from BIP 21 and others will give error

945b034eab

ghost commented at 6:46 PM on April 30, 2021: none

PR #176 mentioned for BIP 21 has no commits so maybe we can also add/replace it with https://github.com/bitcoin/bitcoin/commit/70f55355e29c8e45b607e782c5d76609d23cc858
DrahtBot added the label Docs on Apr 30, 2021

in doc/bips.md:8 in 945b034eab

   4 | @@ -5,7 +5,7 @@ BIPs that are implemented by Bitcoin Core (up-to-date up to **v22.0**):
   5 |  * [`BIP 13`](https://github.com/bitcoin/bips/blob/master/bip-0013.mediawiki): The address format for P2SH addresses has been implemented since **v0.6.0** ([PR #669](https://github.com/bitcoin/bitcoin/pull/669)).
   6 |  * [`BIP 14`](https://github.com/bitcoin/bips/blob/master/bip-0014.mediawiki): The subversion string is being used as User Agent since **v0.6.0** ([PR #669](https://github.com/bitcoin/bitcoin/pull/669)).
   7 |  * [`BIP 16`](https://github.com/bitcoin/bips/blob/master/bip-0016.mediawiki): The pay-to-script-hash evaluation rules have been implemented since **v0.6.0**, and took effect on *April 1st 2012* ([PR #748](https://github.com/bitcoin/bitcoin/pull/748)).
   8 | -* [`BIP 21`](https://github.com/bitcoin/bips/blob/master/bip-0021.mediawiki): The URI format for Bitcoin payments has been implemented since **v0.6.0** ([PR #176](https://github.com/bitcoin/bitcoin/pull/176)).
   9 | +* [`BIP 21`](https://github.com/bitcoin/bips/blob/master/bip-0021.mediawiki): The URI format for Bitcoin payments has been implemented since **v0.6.0** ([PR #176](https://github.com/bitcoin/bitcoin/pull/176)). Only address is supported in URI as mentioned in first [example](https://github.com/bitcoin/bips/blob/master/bip-0021.mediawiki#examples).

Rspigler commented at 10:54 PM on April 30, 2021:

nit: "Only [the] address is supported in [the] URI as mentioned in [the] first example"

unknown commented at 2:07 AM on May 2, 2021:

"[the] address" or "[an] address" or "[a] Bitcoin address"?

Rspigler commented at 4:03 AM on May 2, 2021: contributor

I tested here: https://github.com/bitcoin-core/gui/pull/280#issuecomment-830664559 and a label was still present for a URI with a valid address
ghost commented at 5:05 AM on May 2, 2021: none

I tested here: bitcoin-core/gui#280 (comment) and a label was still present for a URI with a valid address

I just tried 4 examples in v0.21.1 and they are working. Will close this PR and respond in https://github.com/bitcoin-core/gui/pull/280 after testing.
unknown closed this on May 2, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

ghost

Rspigler

Labels

Docs

Linked (view graph)

#21755 Add more info about prefix in error message for invalid address