scripted-diff: Replace three dots with ellipsis in the UI strings #21836

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:210502-ellipsis changing 19 files +58 −58
  1. hebasto commented at 7:11 pm on May 2, 2021: member

    This PR is split from #21463. The change was suggested on Transifex.com, and it does not touch LogPrint and LogPrintf calls.

    The only comment on #21463 was:

    Mind that these messages also end up in the log. In principle the log is already UTF-8 (as are all strings and text in bitcoind). But, just noting, that it might make browsing the log a less pleasant experience on systems with misconfigured locale like some BSDs by default.

  2. scripted-diff: Replace three dots with ellipsis in the UI strings
    -BEGIN VERIFY SCRIPT-
    sed -i -E -e 's/\.\.\."\)(\.|,|\)| )/…"\)\1/' -- $(git ls-files -- 'src' ':(exclude)src/qt/bitcoinstrings.cpp')
    sed -i -e 's/\.\.\.\\"/…\\"/' src/qt/sendcoinsdialog.cpp
    sed -i -e 's|\.\.\.</string>|…</string>|' src/qt/forms/*.ui
    sed -i -e 's|\.\.\.)</string>|…)</string>|' src/qt/forms/sendcoinsdialog.ui
    -END VERIFY SCRIPT-
    d66f283ac0
  3. hebasto force-pushed on May 2, 2021
  4. DrahtBot added the label GUI on May 2, 2021
  5. DrahtBot added the label P2P on May 2, 2021
  6. DrahtBot added the label Refactoring on May 2, 2021
  7. DrahtBot added the label RPC/REST/ZMQ on May 2, 2021
  8. DrahtBot added the label Validation on May 2, 2021
  9. DrahtBot added the label Wallet on May 2, 2021
  10. DrahtBot commented at 11:15 pm on May 2, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #21827 (Display progress of LoadBlockDB() on splash screen by rebroad)
    • #21789 (refactor: Remove ::Params() global from CChainState by MarcoFalke)
    • #20773 (refactor: split CWallet::Create by S3RK)
    • #15719 (Wallet passive startup by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  11. DrahtBot commented at 9:31 am on May 3, 2021: member

    🕵️ @sipa has been requested to review this pull request as specified in the REVIEWERS file.

  12. kiminuo commented at 2:15 pm on May 3, 2021: contributor

    Concept ACK, it’s much nicer!

    Went line by line and it looks correct to me.

  13. laanwj removed the label P2P on May 4, 2021
  14. laanwj removed the label RPC/REST/ZMQ on May 4, 2021
  15. laanwj removed the label Refactoring on May 4, 2021
  16. laanwj removed the label Validation on May 4, 2021
  17. laanwj removed the label Wallet on May 4, 2021
  18. laanwj commented at 2:54 pm on May 4, 2021: member

    ACK d66f283ac07edce432b964f7f814631f5a5bc33b We do want to do an English translation update after this to prevent people from wasting time translating the old messages.

    and it does not touch LogPrint and LogPrintf calls.

    Still, InitMessages end up in the log. I don’t see it as a blocking issue if no one else does though my comment was just a remark.

  19. kristapsk commented at 11:15 am on May 5, 2021: contributor
    What are the benefits of this? Just looking nicer (which is discutable too)?
  20. kiminuo commented at 11:23 am on May 5, 2021: contributor

    What are the benefits of this? Just looking nicer (which is discutable too)?

    For many people there will be zero benefit. It depends on audience. Either you care about typography or you don’t.

    Anyway, when I open randomly a few applications on my computer, ellipses are used in dialogs and menus often so Bitcoin Core will look like other applications do which is a good thing I think.

  21. hebasto commented at 11:41 am on May 5, 2021: member

    What are the benefits of this? Just looking nicer (which is discutable too)?

    As stated in the pr description, this change was suggested by translators on Transifex.com (you could see open issues there).

    I personally did not make any research on this topic. I assume that translators could be more experienced than me on it :)

  22. laanwj commented at 11:50 am on May 5, 2021: member

    It just seems to be the way to do it nowadays (in the age of unicode). It’s intended as ELLIPSIS, there’s a dedicated character for it which is better than using three separate dots. This means the rendering engine has more meta-information about how to display it. It’s definitely a very minor thing though and if it becomes controversial in the least we should close this.

    Edit: I guess for accessibility it is also marginally important as a hint, instead of the text to speech can interpret it semantically.

  23. laanwj merged this on May 10, 2021
  24. laanwj closed this on May 10, 2021

  25. laanwj referenced this in commit 99e98084fc on May 10, 2021
  26. hebasto deleted the branch on May 10, 2021
  27. sidhujag referenced this in commit ea390afbd7 on May 10, 2021
  28. laanwj referenced this in commit c34a49f77f on May 17, 2021
  29. hebasto referenced this in commit 6d1d33d334 on May 17, 2021
  30. rebroad referenced this in commit 3ad5199c31 on Jun 23, 2021
  31. janus referenced this in commit 0753b9384a on Oct 29, 2021
  32. gwillen referenced this in commit 400268064d on Jun 1, 2022
  33. DrahtBot locked this on Aug 18, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-31 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me