Send fewer feefilter messages (avoid the wobbling number issue) #21841

1. 
   rebroad commented at 10:36 am on May 3, 2021: contributor

   This is a simpler replacement for #21805. The only change now to the current functionality is that it requires that the actual (i.e. not rounded up or down) minrelayfee has changed since the last sent feefilter message.

   This helps increase privacy (by not sending repeated messages above and below the actual, thereby revealing the actual), and reduces network traffic (due to fewer messages).

   This pull will make almost no functional changes without #21618 given that it’s extremely rare that the actual minrelayfee will remain constant, so it’s safe to merge, and will be there for privacy safety in the event that a pull is later merged which encourages the minrelayfee to remain constant.

   TODO - need to fix the test that is failing as soon as I work out how to run the test - can someone comment with this info please?

2. fanquake added the label P2P on May 3, 2021
3. rebroad closed this on May 3, 2021

   ---

4. rebroad reopened this on May 3, 2021

   ---

5. rebroad marked this as a draft on May 3, 2021
6. 
   0xB10C commented at 7:37 am on May 5, 2021: member

   TODO - need to fix the test that is failing as soon as I work out how to run the test - can someone comment with this info please?

   e.g. with test/functional/test_runner.py p2p_feefilter.py. See test#running-the-tests for details.

7. Send fewer feefilter messages (avoid the wobbling number issue) 9c0fec5f0f
8. rebroad force-pushed on May 16, 2021
9. 
   rebroad commented at 7:37 am on May 16, 2021: contributor

   I’ve changed the algorithm - simpler - it only sends a new feefilter if the current rounded filter (so still giving privacy) is closer to the current filter than the last sent one was.
10. 
    DrahtBot commented at 4:14 am on May 19, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #21992 (p2p: Remove -feefilter option by amadeuszpawlik)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. 
    MarcoFalke commented at 11:46 am on October 22, 2021: member

    Closing for now. The tests failed, this needs rebase and there hasn’t been any activity for months.

    You can leave a comment if you want this to be reopened. (Or create a new pull, since there haven’t been any comments here). Though, please make sure the code is passing tests and is ready for review.

12. MarcoFalke closed this on Oct 22, 2021

    ---

13. DrahtBot locked this on Oct 30, 2022

Contributors
rebroad 0xB10C DrahtBot MarcoFalke

Labels
P2P