Sanitize fee rates (user input) #21893

issue MarcoFalke opened this issue on May 9, 2021

MarcoFalke commented at 9:00 AM on May 9, 2021: member
It would be nice to sanitize fee rates from user input.

For example the block min fee rate is simply parsed as int64_t value. As fee rates are multiplied by the package size, this can easily lead to overflow.
```
    if (gArgs.IsArgSet("-blockmintxfee") && ParseMoney(gArgs.GetArg("-blockmintxfee", ""), n)) {
```
Assuming a maximum transaction size of at most 4MvB, this would give an upper bound for the fee rate of ~46116 BTC/kvB. Though, any fee rate larger than 1 BTC/kvB is probably nonsense and should be rejected early on startup.
MarcoFalke added the label Feature on May 9, 2021
ghost commented at 10:43 AM on May 9, 2021: none

Concept ACK. Always good to sanitize user input.
jonatack commented at 11:13 AM on May 9, 2021: contributor

Yes. Sanitizing port numbers from user input is on my list as a follow-up to #21328, so if no one picks this up I might. Of course, someone else can pick up either of those too.
aureleoules commented at 9:23 AM on September 16, 2022: member

I believe this is fixed with #22220.
MarcoFalke closed this on Sep 16, 2022
MarcoFalke commented at 10:03 AM on September 16, 2022: member

No, the integer overflow should still exists, see also #22044 (comment)
fanquake referenced this in commit 5fc3939850 on Oct 12, 2022
bitcoin locked this on Sep 16, 2023

Contributors

Labels