Enable reading of pchCommand before Complete() #21896

issue rebroad opened this issue on May 9, 2021
  1. rebroad commented at 10:59 AM on May 9, 2021: contributor

    I always found it useful to be able to see what message was incoming from another node as soon as the header had been received, but since #16202 it no longer appears to be possible to discern the pchCommand until the complete message has been received.

    Is there a way to determine the message as soon as the header has been received? This could be useful functionality in order to be able to reduce bandwidth, and for logging and debugging.

  2. rebroad added the label Feature on May 9, 2021
  3. rebroad renamed this:
    Unable to GetCommand() before Complete()
    Enable reading of pchCommand() before Complete()
    on May 9, 2021
  4. rebroad renamed this:
    Enable reading of pchCommand() before Complete()
    Enable reading of pchCommand before Complete()
    on May 9, 2021
  5. MarcoFalke commented at 12:11 PM on May 9, 2021: member

    This could be useful functionality in order to be able to reduce bandwidth, and for logging and debugging.

    The message type is already logged, so I am not sure what you are asking for. Also how would this save bandwidth?

  6. rebroad commented at 9:49 PM on May 16, 2021: contributor

    especially during IBD blocks can come in very slowly from peers. without being able to know what a message is until we've downloaded it, it makes it difficult to know if a peer is stalling block download / IBD, as a block may be coming in, but take a while to download each block. When it was possible to process the message header before the message arrived, I was using this to work out the stallers in a better way than the current stall logic.

  7. fanquake closed this on Aug 13, 2022

  8. bitcoin locked this on Aug 13, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me