- add check to verify if an URI is valid
Bitcoin-Qt: extend parseBitcoinURI() pre-check #2193
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:Qt_parseBitcoinURI changing 1 files +2 −1-
Diapolo commented at 5:49 PM on January 20, 2013: none
-
BitcoinPullTester commented at 6:22 PM on January 20, 2013: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/5950fc1c72c91cfdea238853065c0d4f6c8dac38 for binaries and test log.
This could happen for one of several reasons:
- It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
- It does not build on either Linux i386 or Win32 (via MinGW cross compile)
- The test suite fails on either Linux i386 or Win32
- The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
-
Diapolo commented at 6:35 PM on January 20, 2013: none
Seems this breaks the URI tests. I suppose we are allowing URIs, which contain no query?
-
446cbf5fe9
Bitcoin-Qt: extend parseBitcoinURI() pre-check
- add check to verify if an URI is valid
-
BitcoinPullTester commented at 7:08 AM on January 21, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/446cbf5fe9384f0e49397e2bb7a9db1005476f56 for binaries and test log.
-
laanwj commented at 11:39 AM on January 21, 2013: member
I don't think a query is necessary. BIP 21 is the authorative source on what URIs we should accept or reject, maybe check there.
-
-
laanwj commented at 3:10 PM on January 21, 2013: member
Ok, ACK
- gavinandresen referenced this in commit ea0a2b18f2 on Jan 21, 2013
- gavinandresen merged this on Jan 21, 2013
- gavinandresen closed this on Jan 21, 2013
- laudney referenced this in commit 360ae59198 on Mar 19, 2014
- sidhujag referenced this in commit a3941f445e on Jul 31, 2018
- DrahtBot locked this on Sep 8, 2021
Contributors