RPC/blockchain: getblockchaininfo: Include versionbits signalling details during LOCKED_IN #21934

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:rpc_getblockchaininfo_lockedin_statistics changing 1 files +12 −11

luke-jr commented at 7:31 PM on May 12, 2021: member

While the signal has no effect during LOCKED_IN, the bit is still defined and recommended for measuring uptake. Makes sense to expose statistics too.
RPC/blockchain: getblockchaininfo: Include versionbits signalling details during LOCKED_IN 2b19f3443e
laanwj added the label RPC/REST/ZMQ on May 12, 2021
Sjors commented at 4:19 PM on May 21, 2021: member

Concept ACK

According to BIP 9 (as well as BIP 8):

Miners should continue setting the bit in LOCKED_IN phase so uptake is visible, though this has no effect on consensus rules.

I'm probably going to be lazy and test this if taproot locks in :-)
DrahtBot commented at 4:18 AM on May 22, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #22016 by Sjors
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
unknown approved
unknown commented at 3:57 PM on May 22, 2021: none

ACK https://github.com/bitcoin/bitcoin/pull/21934/commits/2b19f3443efc9e7868746ea1c603b1027d822f32
theStack commented at 4:09 PM on May 24, 2021: member

Concept ACK

in src/rpc/blockchain.cpp:1380 in 2b19f3443e

1376 | @@ -1377,23 +1377,24 @@ static void BIP9SoftForkDescPushBack(const CBlockIndex* active_chain_tip, UniVal
1377 |      case ThresholdState::ACTIVE: bip9.pushKV("status", "active"); break;
1378 |      case ThresholdState::FAILED: bip9.pushKV("status", "failed"); break;
1379 |      }
1380 | -    if (ThresholdState::STARTED == thresholdState)
1381 | -    {
1382 | +    const bool has_signal = (ThresholdState::STARTED == thresholdState || ThresholdState::LOCKED_IN == thresholdState);

Sjors commented at 9:49 AM on June 16, 2021:

may_signal?

Sjors approved

Sjors commented at 10:01 AM on June 16, 2021: member

tACK 2b19f34

Would be nice to add a test in rpc_blockchain.py

Result for getblockchaininfo (partial):

{
  "chain": "main",
  "blocks": 687794,
  "headers": 687794,
  "bestblockhash": "00000000000000000005ffb3c10a9c4f049cdc1b399431ba9c56ea36d7e5351f",
  "softforks": {
   "taproot": {
      "type": "bip9",
      "bip9": {
        "status": "locked_in",
        "bit": 2,
        "start_time": 1619222400,
        "timeout": 1628640000,
        "since": 687456,
        "statistics": {
          "period": 2016,
          "elapsed": 339,
          "count": 338
        },
        "min_activation_height": 709632
      },
      "active": false
    }
  }
}

luke-jr referenced this in commit 3e557107aa on Jun 27, 2021
theStack approved

theStack commented at 1:30 PM on July 20, 2021: member

Tested ACK 2b19f3443efc9e7868746ea1c603b1027d822f32

Master/PR branch diff of getblockchaininfo (mainnet) "segwit" soft-fork section output:

@@ -2,11 +2,16 @@
       "type": "bip9",
       "bip9": {
         "status": "locked_in",
+        "bit": 2,
         "start_time": 1619222400,
         "timeout": 1628640000,
         "since": 687456,
+        "statistics": {
+          "period": 2016,
+          "elapsed": 2007,
+          "count": 2002
+        },
         "min_activation_height": 709632
       },
       "active": false
     }

MarcoFalke commented at 2:40 PM on July 20, 2021: member

review-only ACK 2b19f3443efc9e7868746ea1c603b1027d822f32

Didn't think whether this makes sense, as I likely won't use it.
MarcoFalke merged this on Jul 21, 2021
MarcoFalke closed this on Jul 21, 2021
sidhujag referenced this in commit 5517ebafb4 on Jul 23, 2021
romanz referenced this in commit 007c9f6cd0 on Jul 29, 2021
romanz referenced this in commit 65388515ad on Jan 8, 2022
RCasatta referenced this in commit 11fcfcf3af on Jan 10, 2022
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

RPC/blockchain: getblockchaininfo: Include versionbits signalling details during LOCKED_IN #21934

Conflicts