build: Silence lupdate "unknown namespace/class" warnings #21983

This PR removes multiple "Qualifying with unknown namespace/class" warnings in make -C src translate output. Also all of the lupdate options are moved before input files (as documented).

The remaining warnings are fixed in Qt 5.12.2 (see QTBUG-42736).

ping @laanwj

Not seeing any difference in make translate output here:

--- /tmp/1	2021-05-17 15:42:52.430558446 +0200
+++ /tmp/2	2021-05-17 15:41:43.643123828 +0200
@@ -1,5 +1,5 @@
 cd …/bitcoin/src; XGETTEXT=/usr/bin/xgettext COPYRIGHT_HOLDERS="The %s developers" /usr/bin/python3.8 ../share/qt/extract_strings_qt.py addrdb.cpp addrman.cpp banman.cpp blockencodings.cpp blockfilter.cpp chain.cpp consensus/tx_verify.cpp dbwrapper.cpp flatfile.cpp httprpc.cpp httpserver.cpp i2p.cpp index/base.cpp index/blockfilterindex.cpp index/coinstatsindex.cpp index/txindex.cpp init.cpp mapport.cpp miner.cpp net.cpp net_processing.cpp node/blockstorage.cpp node/coin.cpp node/coinstats.cpp node/context.cpp node/interfaces.cpp node/psbt.cpp node/transaction.cpp node/ui_interface.cpp noui.cpp policy/fees.cpp policy/rbf.cpp policy/settings.cpp pow.cpp rest.cpp rpc/blockchain.cpp rpc/mining.cpp rpc/misc.cpp rpc/net.cpp rpc/rawtransaction.cpp rpc/server.cpp script/sigcache.cpp shutdown.cpp signet.cpp timedata.cpp torcontrol.cpp txdb.cpp txmempool.cpp txorphanage.cpp txrequest.cpp validation.cpp validationinterface.cpp versionbits.cpp addrdb.h addrman.h attributes.h banman.h base58.h bech32.h blockencodings.h blockfilter.h bloom.h chain.h chainparams.h chainparamsbase.h chainparamsseeds.h checkqueue.h clientversion.h coins.h compat.h compat/assumptions.h compat/byteswap.h compat/cpuid.h compat/endian.h compat/sanity.h compressor.h consensus/consensus.h consensus/tx_check.h consensus/tx_verify.h core_io.h core_memusage.h cuckoocache.h dbwrapper.h external_signer.h flatfile.h fs.h httprpc.h httpserver.h i2p.h index/base.h index/blockfilterindex.h index/coinstatsindex.h index/disktxpos.h index/txindex.h indirectmap.h init.h init/common.h interfaces/chain.h interfaces/echo.h interfaces/handler.h interfaces/init.h interfaces/ipc.h interfaces/node.h interfaces/wallet.h key.h key_io.h logging.h logging/timer.h mapport.h memusage.h merkleblock.h miner.h net.h net_permissions.h net_processing.h net_types.h netaddress.h netbase.h netmessagemaker.h node/blockstorage.h node/coin.h node/coinstats.h node/context.h node/psbt.h node/transaction.h node/ui_interface.h node/utxo_snapshot.h noui.h outputtype.h policy/feerate.h policy/fees.h policy/policy.h policy/rbf.h policy/settings.h pow.h protocol.h psbt.h random.h randomenv.h reverse_iterator.h rpc/blockchain.h rpc/client.h rpc/mining.h rpc/net.h rpc/protocol.h rpc/rawtransaction_util.h rpc/register.h rpc/request.h rpc/server.h rpc/util.h scheduler.h script/descriptor.h script/keyorigin.h script/sigcache.h script/sign.h script/signingprovider.h script/standard.h shutdown.h signet.h streams.h support/allocators/secure.h support/allocators/zeroafterfree.h support/cleanse.h support/events.h support/lockedpool.h sync.h threadinterrupt.h threadsafety.h timedata.h torcontrol.h txdb.h txmempool.h txorphanage.h txrequest.h undo.h util/asmap.h util/bip32.h util/bytevectorhash.h util/check.h util/epochguard.h util/error.h util/fees.h util/getuniquepath.h util/golombrice.h util/hash_type.h util/hasher.h util/macros.h util/message.h util/moneystr.h util/rbf.h util/readwritefile.h util/settings.h util/sock.h util/spanparsing.h util/string.h util/system.h util/thread.h util/threadnames.h util/time.h util/tokenpipe.h util/trace.h util/translation.h util/ui_change_type.h util/url.h util/vector.h validation.h validationinterface.h versionbits.h versionbitsinfo.h wallet/bdb.h wallet/coincontrol.h wallet/coinselection.h wallet/context.h wallet/crypter.h wallet/db.h wallet/dump.h wallet/external_signer_scriptpubkeyman.h wallet/feebumper.h wallet/fees.h wallet/ismine.h wallet/load.h wallet/rpcwallet.h wallet/salvage.h wallet/scriptpubkeyman.h wallet/sqlite.h wallet/wallet.h wallet/walletdb.h wallet/wallettool.h wallet/walletutil.h walletinitinterface.h warnings.h zmq/zmqabstractnotifier.h zmq/zmqnotificationinterface.h zmq/zmqpublishnotifier.h zmq/zmqrpc.h zmq/zmqutil.h wallet/init.cpp  wallet/coincontrol.cpp wallet/context.cpp wallet/crypter.cpp wallet/db.cpp wallet/dump.cpp wallet/external_signer_scriptpubkeyman.cpp wallet/feebumper.cpp wallet/fees.cpp wallet/interfaces.cpp wallet/load.cpp wallet/rpcdump.cpp wallet/rpcwallet.cpp wallet/scriptpubkeyman.cpp wallet/wallet.cpp wallet/walletdb.cpp wallet/walletutil.cpp wallet/coinselection.cpp addrdb.h addrman.h attributes.h banman.h base58.h bech32.h blockencodings.h blockfilter.h bloom.h chain.h chainparams.h chainparamsbase.h chainparamsseeds.h checkqueue.h clientversion.h coins.h compat.h compat/assumptions.h compat/byteswap.h compat/cpuid.h compat/endian.h compat/sanity.h compressor.h consensus/consensus.h consensus/tx_check.h consensus/tx_verify.h core_io.h core_memusage.h cuckoocache.h dbwrapper.h external_signer.h flatfile.h fs.h httprpc.h httpserver.h i2p.h index/base.h index/blockfilterindex.h index/coinstatsindex.h index/disktxpos.h index/txindex.h indirectmap.h init.h init/common.h interfaces/chain.h interfaces/echo.h interfaces/handler.h interfaces/init.h interfaces/ipc.h interfaces/node.h interfaces/wallet.h key.h key_io.h logging.h logging/timer.h mapport.h memusage.h merkleblock.h miner.h net.h net_permissions.h net_processing.h net_types.h netaddress.h netbase.h netmessagemaker.h node/blockstorage.h node/coin.h node/coinstats.h node/context.h node/psbt.h node/transaction.h node/ui_interface.h node/utxo_snapshot.h noui.h outputtype.h policy/feerate.h policy/fees.h policy/policy.h policy/rbf.h policy/settings.h pow.h protocol.h psbt.h random.h randomenv.h reverse_iterator.h rpc/blockchain.h rpc/client.h rpc/mining.h rpc/net.h rpc/protocol.h rpc/rawtransaction_util.h rpc/register.h rpc/request.h rpc/server.h rpc/util.h scheduler.h script/descriptor.h script/keyorigin.h script/sigcache.h script/sign.h script/signingprovider.h script/standard.h shutdown.h signet.h streams.h support/allocators/secure.h support/allocators/zeroafterfree.h support/cleanse.h support/events.h support/lockedpool.h sync.h threadinterrupt.h threadsafety.h timedata.h torcontrol.h txdb.h txmempool.h txorphanage.h txrequest.h undo.h util/asmap.h util/bip32.h util/bytevectorhash.h util/check.h util/epochguard.h util/error.h util/fees.h util/getuniquepath.h util/golombrice.h util/hash_type.h util/hasher.h util/macros.h util/message.h util/moneystr.h util/rbf.h util/readwritefile.h util/settings.h util/sock.h util/spanparsing.h util/string.h util/system.h util/thread.h util/threadnames.h util/time.h util/tokenpipe.h util/trace.h util/translation.h util/ui_change_type.h util/url.h util/vector.h validation.h validationinterface.h versionbits.h versionbitsinfo.h wallet/bdb.h wallet/coincontrol.h wallet/coinselection.h wallet/context.h wallet/crypter.h wallet/db.h wallet/dump.h wallet/external_signer_scriptpubkeyman.h wallet/feebumper.h wallet/fees.h wallet/ismine.h wallet/load.h wallet/rpcwallet.h wallet/salvage.h wallet/scriptpubkeyman.h wallet/sqlite.h wallet/wallet.h wallet/walletdb.h wallet/wallettool.h wallet/walletutil.h walletinitinterface.h warnings.h zmq/zmqabstractnotifier.h zmq/zmqnotificationinterface.h zmq/zmqpublishnotifier.h zmq/zmqrpc.h zmq/zmqutil.h wallet/sqlite.cpp wallet/bdb.cpp wallet/salvage.cpp base58.cpp bech32.cpp bloom.cpp chainparams.cpp coins.cpp compressor.cpp core_read.cpp core_write.cpp external_signer.cpp init/common.cpp key.cpp key_io.cpp merkleblock.cpp netaddress.cpp netbase.cpp net_permissions.cpp outputtype.cpp policy/feerate.cpp policy/policy.cpp protocol.cpp psbt.cpp rpc/rawtransaction_util.cpp rpc/external_signer.cpp rpc/util.cpp scheduler.cpp script/descriptor.cpp script/sign.cpp script/signingprovider.cpp script/standard.cpp versionbitsinfo.cpp warnings.cpp addrdb.h addrman.h attributes.h banman.h base58.h bech32.h blockencodings.h blockfilter.h bloom.h chain.h chainparams.h chainparamsbase.h chainparamsseeds.h checkqueue.h clientversion.h coins.h compat.h compat/assumptions.h compat/byteswap.h compat/cpuid.h compat/endian.h compat/sanity.h compressor.h consensus/consensus.h consensus/tx_check.h consensus/tx_verify.h core_io.h core_memusage.h cuckoocache.h dbwrapper.h external_signer.h flatfile.h fs.h httprpc.h httpserver.h i2p.h index/base.h index/blockfilterindex.h index/coinstatsindex.h index/disktxpos.h index/txindex.h indirectmap.h init.h init/common.h interfaces/chain.h interfaces/echo.h interfaces/handler.h interfaces/init.h interfaces/ipc.h interfaces/node.h interfaces/wallet.h key.h key_io.h logging.h logging/timer.h mapport.h memusage.h merkleblock.h miner.h net.h net_permissions.h net_processing.h net_types.h netaddress.h netbase.h netmessagemaker.h node/blockstorage.h node/coin.h node/coinstats.h node/context.h node/psbt.h node/transaction.h node/ui_interface.h node/utxo_snapshot.h noui.h outputtype.h policy/feerate.h policy/fees.h policy/policy.h policy/rbf.h policy/settings.h pow.h protocol.h psbt.h random.h randomenv.h reverse_iterator.h rpc/blockchain.h rpc/client.h rpc/mining.h rpc/net.h rpc/protocol.h rpc/rawtransaction_util.h rpc/register.h rpc/request.h rpc/server.h rpc/util.h scheduler.h script/descriptor.h script/keyorigin.h script/sigcache.h script/sign.h script/signingprovider.h script/standard.h shutdown.h signet.h streams.h support/allocators/secure.h support/allocators/zeroafterfree.h support/cleanse.h support/events.h support/lockedpool.h sync.h threadinterrupt.h threadsafety.h timedata.h torcontrol.h txdb.h txmempool.h txorphanage.h txrequest.h undo.h util/asmap.h util/bip32.h util/bytevectorhash.h util/check.h util/epochguard.h util/error.h util/fees.h util/getuniquepath.h util/golombrice.h util/hash_type.h util/hasher.h util/macros.h util/message.h util/moneystr.h util/rbf.h util/readwritefile.h util/settings.h util/sock.h util/spanparsing.h util/string.h util/system.h util/thread.h util/threadnames.h util/time.h util/tokenpipe.h util/trace.h util/translation.h util/ui_change_type.h util/url.h util/vector.h validation.h validationinterface.h versionbits.h versionbitsinfo.h wallet/bdb.h wallet/coincontrol.h wallet/coinselection.h wallet/context.h wallet/crypter.h wallet/db.h wallet/dump.h wallet/external_signer_scriptpubkeyman.h wallet/feebumper.h wallet/fees.h wallet/ismine.h wallet/load.h wallet/rpcwallet.h wallet/salvage.h wallet/scriptpubkeyman.h wallet/sqlite.h wallet/wallet.h wallet/walletdb.h wallet/wallettool.h wallet/walletutil.h walletinitinterface.h warnings.h zmq/zmqabstractnotifier.h zmq/zmqnotificationinterface.h zmq/zmqpublishnotifier.h zmq/zmqrpc.h zmq/zmqutil.h zmq/zmqabstractnotifier.cpp zmq/zmqnotificationinterface.cpp zmq/zmqpublishnotifier.cpp zmq/zmqrpc.cpp zmq/zmqutil.cpp amount.h arith_uint256.cpp arith_uint256.h consensus/merkle.cpp consensus/merkle.h consensus/params.h consensus/tx_check.cpp consensus/validation.h hash.cpp hash.h prevector.h primitives/block.cpp primitives/block.h primitives/transaction.cpp primitives/transaction.h pubkey.cpp pubkey.h script/bitcoinconsensus.cpp script/interpreter.cpp script/interpreter.h script/script.cpp script/script.h script/script_error.cpp script/script_error.h serialize.h span.h tinyformat.h uint256.cpp uint256.h util/strencodings.cpp util/strencodings.h version.h support/lockedpool.cpp chainparamsbase.cpp clientversion.cpp compat/glibcxx_sanity.cpp compat/strnlen.cpp fs.cpp interfaces/echo.cpp interfaces/handler.cpp interfaces/init.cpp logging.cpp random.cpp randomenv.cpp rpc/request.cpp support/cleanse.cpp sync.cpp threadinterrupt.cpp util/asmap.cpp util/bip32.cpp util/bytevectorhash.cpp util/error.cpp util/fees.cpp util/getuniquepath.cpp util/hasher.cpp util/sock.cpp util/system.cpp util/message.cpp util/moneystr.cpp util/rbf.cpp util/readwritefile.cpp util/settings.cpp util/thread.cpp util/threadnames.cpp util/spanparsing.cpp util/strencodings.cpp util/string.cpp util/time.cpp util/tokenpipe.cpp addrdb.h addrman.h attributes.h banman.h base58.h bech32.h blockencodings.h blockfilter.h bloom.h chain.h chainparams.h chainparamsbase.h chainparamsseeds.h checkqueue.h clientversion.h coins.h compat.h compat/assumptions.h compat/byteswap.h compat/cpuid.h compat/endian.h compat/sanity.h compressor.h consensus/consensus.h consensus/tx_check.h consensus/tx_verify.h core_io.h core_memusage.h cuckoocache.h dbwrapper.h external_signer.h flatfile.h fs.h httprpc.h httpserver.h i2p.h index/base.h index/blockfilterindex.h index/coinstatsindex.h index/disktxpos.h index/txindex.h indirectmap.h init.h init/common.h interfaces/chain.h interfaces/echo.h interfaces/handler.h interfaces/init.h interfaces/ipc.h interfaces/node.h interfaces/wallet.h key.h key_io.h logging.h logging/timer.h mapport.h memusage.h merkleblock.h miner.h net.h net_permissions.h net_processing.h net_types.h netaddress.h netbase.h netmessagemaker.h node/blockstorage.h node/coin.h node/coinstats.h node/context.h node/psbt.h node/transaction.h node/ui_interface.h node/utxo_snapshot.h noui.h outputtype.h policy/feerate.h policy/fees.h policy/policy.h policy/rbf.h policy/settings.h pow.h protocol.h psbt.h random.h randomenv.h reverse_iterator.h rpc/blockchain.h rpc/client.h rpc/mining.h rpc/net.h rpc/protocol.h rpc/rawtransaction_util.h rpc/register.h rpc/request.h rpc/server.h rpc/util.h scheduler.h script/descriptor.h script/keyorigin.h script/sigcache.h script/sign.h script/signingprovider.h script/standard.h shutdown.h signet.h streams.h support/allocators/secure.h support/allocators/zeroafterfree.h support/cleanse.h support/events.h support/lockedpool.h sync.h threadinterrupt.h threadsafety.h timedata.h torcontrol.h txdb.h txmempool.h txorphanage.h txrequest.h undo.h util/asmap.h util/bip32.h util/bytevectorhash.h util/check.h util/epochguard.h util/error.h util/fees.h util/getuniquepath.h util/golombrice.h util/hash_type.h util/hasher.h util/macros.h util/message.h util/moneystr.h util/rbf.h util/readwritefile.h util/settings.h util/sock.h util/spanparsing.h util/string.h util/system.h util/thread.h util/threadnames.h util/time.h util/tokenpipe.h util/trace.h util/translation.h util/ui_change_type.h util/url.h util/vector.h validation.h validationinterface.h versionbits.h versionbitsinfo.h wallet/bdb.h wallet/coincontrol.h wallet/coinselection.h wallet/context.h wallet/crypter.h wallet/db.h wallet/dump.h wallet/external_signer_scriptpubkeyman.h wallet/feebumper.h wallet/fees.h wallet/ismine.h wallet/load.h wallet/rpcwallet.h wallet/salvage.h wallet/scriptpubkeyman.h wallet/sqlite.h wallet/wallet.h wallet/walletdb.h wallet/wallettool.h wallet/walletutil.h walletinitinterface.h warnings.h zmq/zmqabstractnotifier.h zmq/zmqnotificationinterface.h zmq/zmqpublishnotifier.h zmq/zmqrpc.h zmq/zmqutil.h util/url.cpp 
-QT_SELECT=qt5 /usr/lib/x86_64-linux-gnu/qt5/bin/lupdate …/bitcoin/src/qt/bitcoinstrings.cpp …/bitcoin/src/qt/forms/addressbookpage.ui …/bitcoin/src/qt/forms/askpassphrasedialog.ui …/bitcoin/src/qt/forms/coincontroldialog.ui …/bitcoin/src/qt/forms/createwalletdialog.ui …/bitcoin/src/qt/forms/editaddressdialog.ui …/bitcoin/src/qt/forms/helpmessagedialog.ui …/bitcoin/src/qt/forms/intro.ui …/bitcoin/src/qt/forms/modaloverlay.ui …/bitcoin/src/qt/forms/openuridialog.ui …/bitcoin/src/qt/forms/optionsdialog.ui …/bitcoin/src/qt/forms/overviewpage.ui …/bitcoin/src/qt/forms/psbtoperationsdialog.ui …/bitcoin/src/qt/forms/receivecoinsdialog.ui …/bitcoin/src/qt/forms/receiverequestdialog.ui …/bitcoin/src/qt/forms/debugwindow.ui …/bitcoin/src/qt/forms/sendcoinsdialog.ui …/bitcoin/src/qt/forms/sendcoinsentry.ui …/bitcoin/src/qt/forms/signverifymessagedialog.ui …/bitcoin/src/qt/forms/transactiondescdialog.ui …/bitcoin/src/qt/bantablemodel.cpp …/bitcoin/src/qt/bitcoin.cpp …/bitcoin/src/qt/bitcoinaddressvalidator.cpp …/bitcoin/src/qt/bitcoinamountfield.cpp …/bitcoin/src/qt/bitcoingui.cpp …/bitcoin/src/qt/bitcoinunits.cpp …/bitcoin/src/qt/clientmodel.cpp …/bitcoin/src/qt/csvmodelwriter.cpp …/bitcoin/src/qt/guiutil.cpp …/bitcoin/src/qt/intro.cpp …/bitcoin/src/qt/modaloverlay.cpp …/bitcoin/src/qt/networkstyle.cpp …/bitcoin/src/qt/notificator.cpp …/bitcoin/src/qt/optionsdialog.cpp …/bitcoin/src/qt/optionsmodel.cpp …/bitcoin/src/qt/peertablemodel.cpp …/bitcoin/src/qt/peertablesortproxy.cpp …/bitcoin/src/qt/platformstyle.cpp …/bitcoin/src/qt/qvalidatedlineedit.cpp …/bitcoin/src/qt/qvaluecombobox.cpp …/bitcoin/src/qt/rpcconsole.cpp …/bitcoin/src/qt/splashscreen.cpp …/bitcoin/src/qt/trafficgraphwidget.cpp …/bitcoin/src/qt/utilitydialog.cpp …/bitcoin/src/qt/winshutdownmonitor.cpp …/bitcoin/src/qt/addressbookpage.cpp …/bitcoin/src/qt/addresstablemodel.cpp …/bitcoin/src/qt/askpassphrasedialog.cpp …/bitcoin/src/qt/coincontroldialog.cpp …/bitcoin/src/qt/coincontroltreewidget.cpp …/bitcoin/src/qt/createwalletdialog.cpp …/bitcoin/src/qt/editaddressdialog.cpp …/bitcoin/src/qt/openuridialog.cpp …/bitcoin/src/qt/overviewpage.cpp …/bitcoin/src/qt/paymentserver.cpp …/bitcoin/src/qt/psbtoperationsdialog.cpp …/bitcoin/src/qt/qrimagewidget.cpp …/bitcoin/src/qt/receivecoinsdialog.cpp …/bitcoin/src/qt/receiverequestdialog.cpp …/bitcoin/src/qt/recentrequeststablemodel.cpp …/bitcoin/src/qt/sendcoinsdialog.cpp …/bitcoin/src/qt/sendcoinsentry.cpp …/bitcoin/src/qt/signverifymessagedialog.cpp …/bitcoin/src/qt/transactiondesc.cpp …/bitcoin/src/qt/transactiondescdialog.cpp …/bitcoin/src/qt/transactionfilterproxy.cpp …/bitcoin/src/qt/transactionrecord.cpp …/bitcoin/src/qt/transactiontablemodel.cpp …/bitcoin/src/qt/transactionview.cpp …/bitcoin/src/qt/walletcontroller.cpp …/bitcoin/src/qt/walletframe.cpp …/bitcoin/src/qt/walletmodel.cpp …/bitcoin/src/qt/walletmodeltransaction.cpp …/bitcoin/src/qt/walletview.cpp …/bitcoin/src/qt/addressbookpage.h …/bitcoin/src/qt/addresstablemodel.h …/bitcoin/src/qt/askpassphrasedialog.h …/bitcoin/src/qt/bantablemodel.h …/bitcoin/src/qt/bitcoinaddressvalidator.h …/bitcoin/src/qt/bitcoinamountfield.h …/bitcoin/src/qt/bitcoin.h …/bitcoin/src/qt/bitcoingui.h …/bitcoin/src/qt/bitcoinunits.h …/bitcoin/src/qt/clientmodel.h …/bitcoin/src/qt/coincontroldialog.h …/bitcoin/src/qt/coincontroltreewidget.h …/bitcoin/src/qt/createwalletdialog.h …/bitcoin/src/qt/csvmodelwriter.h …/bitcoin/src/qt/editaddressdialog.h …/bitcoin/src/qt/guiconstants.h …/bitcoin/src/qt/guiutil.h …/bitcoin/src/qt/intro.h …/bitcoin/src/qt/macdockiconhandler.h …/bitcoin/src/qt/macnotificationhandler.h …/bitcoin/src/qt/macos_appnap.h …/bitcoin/src/qt/modaloverlay.h …/bitcoin/src/qt/networkstyle.h …/bitcoin/src/qt/notificator.h …/bitcoin/src/qt/openuridialog.h …/bitcoin/src/qt/optionsdialog.h …/bitcoin/src/qt/optionsmodel.h …/bitcoin/src/qt/overviewpage.h …/bitcoin/src/qt/paymentserver.h …/bitcoin/src/qt/peertablemodel.h …/bitcoin/src/qt/peertablesortproxy.h …/bitcoin/src/qt/platformstyle.h …/bitcoin/src/qt/psbtoperationsdialog.h …/bitcoin/src/qt/qrimagewidget.h …/bitcoin/src/qt/qvalidatedlineedit.h …/bitcoin/src/qt/qvaluecombobox.h …/bitcoin/src/qt/receivecoinsdialog.h …/bitcoin/src/qt/receiverequestdialog.h …/bitcoin/src/qt/recentrequeststablemodel.h …/bitcoin/src/qt/rpcconsole.h …/bitcoin/src/qt/sendcoinsdialog.h …/bitcoin/src/qt/sendcoinsentry.h …/bitcoin/src/qt/sendcoinsrecipient.h …/bitcoin/src/qt/signverifymessagedialog.h …/bitcoin/src/qt/splashscreen.h …/bitcoin/src/qt/trafficgraphwidget.h …/bitcoin/src/qt/transactiondesc.h …/bitcoin/src/qt/transactiondescdialog.h …/bitcoin/src/qt/transactionfilterproxy.h …/bitcoin/src/qt/transactionoverviewwidget.h …/bitcoin/src/qt/transactionrecord.h …/bitcoin/src/qt/transactiontablemodel.h …/bitcoin/src/qt/transactionview.h …/bitcoin/src/qt/utilitydialog.h …/bitcoin/src/qt/walletcontroller.h …/bitcoin/src/qt/walletframe.h …/bitcoin/src/qt/walletmodel.h …/bitcoin/src/qt/walletmodeltransaction.h …/bitcoin/src/qt/walletview.h …/bitcoin/src/qt/winshutdownmonitor.h …/bitcoin/src/qt/macdockiconhandler.mm …/bitcoin/src/qt/macnotificationhandler.mm …/bitcoin/src/qt/macos_appnap.mm -locations relative -no-obsolete -ts …/bitcoin/src/qt/locale/bitcoin_en.ts
+QT_SELECT=qt5 /usr/lib/x86_64-linux-gnu/qt5/bin/lupdate -no-obsolete -I. -locations relative …/bitcoin/src/qt/bitcoinstrings.cpp …/bitcoin/src/qt/forms/addressbookpage.ui …/bitcoin/src/qt/forms/askpassphrasedialog.ui …/bitcoin/src/qt/forms/coincontroldialog.ui …/bitcoin/src/qt/forms/createwalletdialog.ui …/bitcoin/src/qt/forms/editaddressdialog.ui …/bitcoin/src/qt/forms/helpmessagedialog.ui …/bitcoin/src/qt/forms/intro.ui …/bitcoin/src/qt/forms/modaloverlay.ui …/bitcoin/src/qt/forms/openuridialog.ui …/bitcoin/src/qt/forms/optionsdialog.ui …/bitcoin/src/qt/forms/overviewpage.ui …/bitcoin/src/qt/forms/psbtoperationsdialog.ui …/bitcoin/src/qt/forms/receivecoinsdialog.ui …/bitcoin/src/qt/forms/receiverequestdialog.ui …/bitcoin/src/qt/forms/debugwindow.ui …/bitcoin/src/qt/forms/sendcoinsdialog.ui …/bitcoin/src/qt/forms/sendcoinsentry.ui …/bitcoin/src/qt/forms/signverifymessagedialog.ui …/bitcoin/src/qt/forms/transactiondescdialog.ui …/bitcoin/src/qt/bantablemodel.cpp …/bitcoin/src/qt/bitcoin.cpp …/bitcoin/src/qt/bitcoinaddressvalidator.cpp …/bitcoin/src/qt/bitcoinamountfield.cpp …/bitcoin/src/qt/bitcoingui.cpp …/bitcoin/src/qt/bitcoinunits.cpp …/bitcoin/src/qt/clientmodel.cpp …/bitcoin/src/qt/csvmodelwriter.cpp …/bitcoin/src/qt/guiutil.cpp …/bitcoin/src/qt/intro.cpp …/bitcoin/src/qt/modaloverlay.cpp …/bitcoin/src/qt/networkstyle.cpp …/bitcoin/src/qt/notificator.cpp …/bitcoin/src/qt/optionsdialog.cpp …/bitcoin/src/qt/optionsmodel.cpp …/bitcoin/src/qt/peertablemodel.cpp …/bitcoin/src/qt/peertablesortproxy.cpp …/bitcoin/src/qt/platformstyle.cpp …/bitcoin/src/qt/qvalidatedlineedit.cpp …/bitcoin/src/qt/qvaluecombobox.cpp …/bitcoin/src/qt/rpcconsole.cpp …/bitcoin/src/qt/splashscreen.cpp …/bitcoin/src/qt/trafficgraphwidget.cpp …/bitcoin/src/qt/utilitydialog.cpp …/bitcoin/src/qt/winshutdownmonitor.cpp …/bitcoin/src/qt/addressbookpage.cpp …/bitcoin/src/qt/addresstablemodel.cpp …/bitcoin/src/qt/askpassphrasedialog.cpp …/bitcoin/src/qt/coincontroldialog.cpp …/bitcoin/src/qt/coincontroltreewidget.cpp …/bitcoin/src/qt/createwalletdialog.cpp …/bitcoin/src/qt/editaddressdialog.cpp …/bitcoin/src/qt/openuridialog.cpp …/bitcoin/src/qt/overviewpage.cpp …/bitcoin/src/qt/paymentserver.cpp …/bitcoin/src/qt/psbtoperationsdialog.cpp …/bitcoin/src/qt/qrimagewidget.cpp …/bitcoin/src/qt/receivecoinsdialog.cpp …/bitcoin/src/qt/receiverequestdialog.cpp …/bitcoin/src/qt/recentrequeststablemodel.cpp …/bitcoin/src/qt/sendcoinsdialog.cpp …/bitcoin/src/qt/sendcoinsentry.cpp …/bitcoin/src/qt/signverifymessagedialog.cpp …/bitcoin/src/qt/transactiondesc.cpp …/bitcoin/src/qt/transactiondescdialog.cpp …/bitcoin/src/qt/transactionfilterproxy.cpp …/bitcoin/src/qt/transactionrecord.cpp …/bitcoin/src/qt/transactiontablemodel.cpp …/bitcoin/src/qt/transactionview.cpp …/bitcoin/src/qt/walletcontroller.cpp …/bitcoin/src/qt/walletframe.cpp …/bitcoin/src/qt/walletmodel.cpp …/bitcoin/src/qt/walletmodeltransaction.cpp …/bitcoin/src/qt/walletview.cpp …/bitcoin/src/qt/addressbookpage.h …/bitcoin/src/qt/addresstablemodel.h …/bitcoin/src/qt/askpassphrasedialog.h …/bitcoin/src/qt/bantablemodel.h …/bitcoin/src/qt/bitcoinaddressvalidator.h …/bitcoin/src/qt/bitcoinamountfield.h …/bitcoin/src/qt/bitcoin.h …/bitcoin/src/qt/bitcoingui.h …/bitcoin/src/qt/bitcoinunits.h …/bitcoin/src/qt/clientmodel.h …/bitcoin/src/qt/coincontroldialog.h …/bitcoin/src/qt/coincontroltreewidget.h …/bitcoin/src/qt/createwalletdialog.h …/bitcoin/src/qt/csvmodelwriter.h …/bitcoin/src/qt/editaddressdialog.h …/bitcoin/src/qt/guiconstants.h …/bitcoin/src/qt/guiutil.h …/bitcoin/src/qt/intro.h …/bitcoin/src/qt/macdockiconhandler.h …/bitcoin/src/qt/macnotificationhandler.h …/bitcoin/src/qt/macos_appnap.h …/bitcoin/src/qt/modaloverlay.h …/bitcoin/src/qt/networkstyle.h …/bitcoin/src/qt/notificator.h …/bitcoin/src/qt/openuridialog.h …/bitcoin/src/qt/optionsdialog.h …/bitcoin/src/qt/optionsmodel.h …/bitcoin/src/qt/overviewpage.h …/bitcoin/src/qt/paymentserver.h …/bitcoin/src/qt/peertablemodel.h …/bitcoin/src/qt/peertablesortproxy.h …/bitcoin/src/qt/platformstyle.h …/bitcoin/src/qt/psbtoperationsdialog.h …/bitcoin/src/qt/qrimagewidget.h …/bitcoin/src/qt/qvalidatedlineedit.h …/bitcoin/src/qt/qvaluecombobox.h …/bitcoin/src/qt/receivecoinsdialog.h …/bitcoin/src/qt/receiverequestdialog.h …/bitcoin/src/qt/recentrequeststablemodel.h …/bitcoin/src/qt/rpcconsole.h …/bitcoin/src/qt/sendcoinsdialog.h …/bitcoin/src/qt/sendcoinsentry.h …/bitcoin/src/qt/sendcoinsrecipient.h …/bitcoin/src/qt/signverifymessagedialog.h …/bitcoin/src/qt/splashscreen.h …/bitcoin/src/qt/trafficgraphwidget.h …/bitcoin/src/qt/transactiondesc.h …/bitcoin/src/qt/transactiondescdialog.h …/bitcoin/src/qt/transactionfilterproxy.h …/bitcoin/src/qt/transactionoverviewwidget.h …/bitcoin/src/qt/transactionrecord.h …/bitcoin/src/qt/transactiontablemodel.h …/bitcoin/src/qt/transactionview.h …/bitcoin/src/qt/utilitydialog.h …/bitcoin/src/qt/walletcontroller.h …/bitcoin/src/qt/walletframe.h …/bitcoin/src/qt/walletmodel.h …/bitcoin/src/qt/walletmodeltransaction.h …/bitcoin/src/qt/walletview.h …/bitcoin/src/qt/winshutdownmonitor.h …/bitcoin/src/qt/macdockiconhandler.mm …/bitcoin/src/qt/macnotificationhandler.mm …/bitcoin/src/qt/macos_appnap.mm -ts …/bitcoin/src/qt/locale/bitcoin_en.ts
 …/bitcoin/src/qt/bantablemodel.cpp:85: Qualifying with unknown namespace/class ::BanTableModel
 …/bitcoin/src/qt/bitcoin.cpp:421: Qualifying with unknown namespace/class ::BitcoinApplication
 …/bitcoin/src/qt/bitcoin.cpp:431: Qualifying with unknown namespace/class ::BitcoinApplication

This is on Ubuntu Focal 20.04,

$ lupdate -version
lupdate version 5.12.8

@laanwj

Not seeing any difference in make translate output here:

Sorry for asking, but did you do ./autogen.sh && ./configure after switching to this branch from the master one?

No, but I did verify that the lupdate command line changed (see the diff in previous message). Shouldn't that be enough?

No, but I did verify that the lupdate command line changed (see the diff in previous message). Shouldn't that be enough?

It seems I misunderstand you.

If "output" is the result of make translate in generated and modified files then "Not seeing any difference" is expected. If "output" are messages printed by make translate to console -- "Not seeing any difference" is not what expected as warnings should gone.

That's why I was confused by your comment. Sorry for that.

ACK aa9702b3ae937e72b8c96fb9b12f2db75f7cffc5

This silences the warnings for me on macOS 11.3 clang 12.0.5, these warnings appear harmless.

master:

$ make -C src translate 2>&1 > /dev/null | grep -o "Qualifying with" | wc -l
     
111

pr:

$ make -C src translate 2>&1 > /dev/null | grep -o "Qualifying with" | wc -l

0

If "output" are messages printed by make translate to console -- "Not seeing any difference" is not what expected as warnings should gone.

Correct, with "output" I meant what is printed to stdout/stderr, as this is the motivation for this PR.

There was no change in the amount of warnings for me with or without this PR. I will re-try with explicit autogen.sh and configure.

Re-tracing @jarolrod's steps:

Master without this PR:

$ make -C src translate 2>&1 > /dev/null | grep -o "Qualifying with" | wc -l                                                                                                           
111

Master with this PR (manually forcing ./autogen.sh ./configure):

$ make -C src translate 2>&1 > /dev/null | grep -o "Qualifying with" | wc -l
111

What's your lupdate -version output?

Also re-tracing @jarolrod's steps:

$ lupdate -version
lupdate version 5.12.8
$ which lupdate 
/usr/bin/lupdate

• master:

$ git rev-parse HEAD
7b87fca930ff7129f267906e71be217851146ade
$ ./autogen.sh && ./configure --with-incompatible-bdb
$ make -C src translate 2>&1 > /dev/null | grep -e "Qualifying with" | wc -l  
111

• pr:

$ git rev-parse HEAD
aa9702b3ae937e72b8c96fb9b12f2db75f7cffc5
$ ./autogen.sh && ./configure --with-incompatible-bdb
$ make -C src translate 2>&1 > /dev/null | grep -e "Qualifying with" | wc -l
0

I'm really spooked. Could it have to do with something else, like the order of the input files? Can anyone post their lupdate command line from make V=1 translate please? (with this PR)

$ git rev-parse HEAD
aa9702b3ae937e72b8c96fb9b12f2db75f7cffc5
$ make -C src translate V=1
make: Entering directory '/home/hebasto/GitHub/bitcoin/src'
cd .; XGETTEXT=/usr/bin/xgettext COPYRIGHT_HOLDERS="The %s developers" /usr/bin/python3.8 ../share/qt/extract_strings_qt.py addrdb.cpp addrman.cpp banman.cpp blockencodings.cpp blockfilter.cpp chain.cpp consensus/tx_verify.cpp dbwrapper.cpp flatfile.cpp httprpc.cpp httpserver.cpp i2p.cpp index/base.cpp index/blockfilterindex.cpp index/coinstatsindex.cpp index/txindex.cpp init.cpp mapport.cpp miner.cpp net.cpp net_processing.cpp node/blockstorage.cpp node/coin.cpp node/coinstats.cpp node/context.cpp node/interfaces.cpp node/psbt.cpp node/transaction.cpp node/ui_interface.cpp noui.cpp policy/fees.cpp policy/rbf.cpp policy/settings.cpp pow.cpp rest.cpp rpc/blockchain.cpp rpc/mining.cpp rpc/misc.cpp rpc/net.cpp rpc/rawtransaction.cpp rpc/server.cpp script/sigcache.cpp shutdown.cpp signet.cpp timedata.cpp torcontrol.cpp txdb.cpp txmempool.cpp txorphanage.cpp txrequest.cpp validation.cpp validationinterface.cpp versionbits.cpp addrdb.h addrman.h attributes.h banman.h base58.h bech32.h blockencodings.h blockfilter.h bloom.h chain.h chainparams.h chainparamsbase.h chainparamsseeds.h checkqueue.h clientversion.h coins.h compat.h compat/assumptions.h compat/byteswap.h compat/cpuid.h compat/endian.h compat/sanity.h compressor.h consensus/consensus.h consensus/tx_check.h consensus/tx_verify.h core_io.h core_memusage.h cuckoocache.h dbwrapper.h external_signer.h flatfile.h fs.h httprpc.h httpserver.h i2p.h index/base.h index/blockfilterindex.h index/coinstatsindex.h index/disktxpos.h index/txindex.h indirectmap.h init.h init/common.h interfaces/chain.h interfaces/echo.h interfaces/handler.h interfaces/init.h interfaces/ipc.h interfaces/node.h interfaces/wallet.h key.h key_io.h logging.h logging/timer.h mapport.h memusage.h merkleblock.h miner.h net.h net_permissions.h net_processing.h net_types.h netaddress.h netbase.h netmessagemaker.h node/blockstorage.h node/coin.h node/coinstats.h node/context.h node/psbt.h node/transaction.h node/ui_interface.h node/utxo_snapshot.h noui.h outputtype.h policy/feerate.h policy/fees.h policy/policy.h policy/rbf.h policy/settings.h pow.h protocol.h psbt.h random.h randomenv.h reverse_iterator.h rpc/blockchain.h rpc/client.h rpc/mining.h rpc/net.h rpc/protocol.h rpc/rawtransaction_util.h rpc/register.h rpc/request.h rpc/server.h rpc/util.h scheduler.h script/descriptor.h script/keyorigin.h script/sigcache.h script/sign.h script/signingprovider.h script/standard.h shutdown.h signet.h streams.h support/allocators/secure.h support/allocators/zeroafterfree.h support/cleanse.h support/events.h support/lockedpool.h sync.h threadinterrupt.h threadsafety.h timedata.h torcontrol.h txdb.h txmempool.h txorphanage.h txrequest.h undo.h util/asmap.h util/bip32.h util/bytevectorhash.h util/check.h util/epochguard.h util/error.h util/fees.h util/getuniquepath.h util/golombrice.h util/hash_type.h util/hasher.h util/macros.h util/message.h util/moneystr.h util/rbf.h util/readwritefile.h util/settings.h util/sock.h util/spanparsing.h util/string.h util/system.h util/thread.h util/threadnames.h util/time.h util/tokenpipe.h util/trace.h util/translation.h util/ui_change_type.h util/url.h util/vector.h validation.h validationinterface.h versionbits.h versionbitsinfo.h wallet/bdb.h wallet/coincontrol.h wallet/coinselection.h wallet/context.h wallet/crypter.h wallet/db.h wallet/dump.h wallet/external_signer_scriptpubkeyman.h wallet/feebumper.h wallet/fees.h wallet/ismine.h wallet/load.h wallet/rpcwallet.h wallet/salvage.h wallet/scriptpubkeyman.h wallet/sqlite.h wallet/wallet.h wallet/walletdb.h wallet/wallettool.h wallet/walletutil.h walletinitinterface.h warnings.h zmq/zmqabstractnotifier.h zmq/zmqnotificationinterface.h zmq/zmqpublishnotifier.h zmq/zmqrpc.h zmq/zmqutil.h wallet/init.cpp  wallet/coincontrol.cpp wallet/context.cpp wallet/crypter.cpp wallet/db.cpp wallet/dump.cpp wallet/external_signer_scriptpubkeyman.cpp wallet/feebumper.cpp wallet/fees.cpp wallet/interfaces.cpp wallet/load.cpp wallet/rpcdump.cpp wallet/rpcwallet.cpp wallet/scriptpubkeyman.cpp wallet/wallet.cpp wallet/walletdb.cpp wallet/walletutil.cpp wallet/coinselection.cpp addrdb.h addrman.h attributes.h banman.h base58.h bech32.h blockencodings.h blockfilter.h bloom.h chain.h chainparams.h chainparamsbase.h chainparamsseeds.h checkqueue.h clientversion.h coins.h compat.h compat/assumptions.h compat/byteswap.h compat/cpuid.h compat/endian.h compat/sanity.h compressor.h consensus/consensus.h consensus/tx_check.h consensus/tx_verify.h core_io.h core_memusage.h cuckoocache.h dbwrapper.h external_signer.h flatfile.h fs.h httprpc.h httpserver.h i2p.h index/base.h index/blockfilterindex.h index/coinstatsindex.h index/disktxpos.h index/txindex.h indirectmap.h init.h init/common.h interfaces/chain.h interfaces/echo.h interfaces/handler.h interfaces/init.h interfaces/ipc.h interfaces/node.h interfaces/wallet.h key.h key_io.h logging.h logging/timer.h mapport.h memusage.h merkleblock.h miner.h net.h net_permissions.h net_processing.h net_types.h netaddress.h netbase.h netmessagemaker.h node/blockstorage.h node/coin.h node/coinstats.h node/context.h node/psbt.h node/transaction.h node/ui_interface.h node/utxo_snapshot.h noui.h outputtype.h policy/feerate.h policy/fees.h policy/policy.h policy/rbf.h policy/settings.h pow.h protocol.h psbt.h random.h randomenv.h reverse_iterator.h rpc/blockchain.h rpc/client.h rpc/mining.h rpc/net.h rpc/protocol.h rpc/rawtransaction_util.h rpc/register.h rpc/request.h rpc/server.h rpc/util.h scheduler.h script/descriptor.h script/keyorigin.h script/sigcache.h script/sign.h script/signingprovider.h script/standard.h shutdown.h signet.h streams.h support/allocators/secure.h support/allocators/zeroafterfree.h support/cleanse.h support/events.h support/lockedpool.h sync.h threadinterrupt.h threadsafety.h timedata.h torcontrol.h txdb.h txmempool.h txorphanage.h txrequest.h undo.h util/asmap.h util/bip32.h util/bytevectorhash.h util/check.h util/epochguard.h util/error.h util/fees.h util/getuniquepath.h util/golombrice.h util/hash_type.h util/hasher.h util/macros.h util/message.h util/moneystr.h util/rbf.h util/readwritefile.h util/settings.h util/sock.h util/spanparsing.h util/string.h util/system.h util/thread.h util/threadnames.h util/time.h util/tokenpipe.h util/trace.h util/translation.h util/ui_change_type.h util/url.h util/vector.h validation.h validationinterface.h versionbits.h versionbitsinfo.h wallet/bdb.h wallet/coincontrol.h wallet/coinselection.h wallet/context.h wallet/crypter.h wallet/db.h wallet/dump.h wallet/external_signer_scriptpubkeyman.h wallet/feebumper.h wallet/fees.h wallet/ismine.h wallet/load.h wallet/rpcwallet.h wallet/salvage.h wallet/scriptpubkeyman.h wallet/sqlite.h wallet/wallet.h wallet/walletdb.h wallet/wallettool.h wallet/walletutil.h walletinitinterface.h warnings.h zmq/zmqabstractnotifier.h zmq/zmqnotificationinterface.h zmq/zmqpublishnotifier.h zmq/zmqrpc.h zmq/zmqutil.h wallet/sqlite.cpp wallet/bdb.cpp wallet/salvage.cpp base58.cpp bech32.cpp bloom.cpp chainparams.cpp coins.cpp compressor.cpp core_read.cpp core_write.cpp external_signer.cpp init/common.cpp key.cpp key_io.cpp merkleblock.cpp netaddress.cpp netbase.cpp net_permissions.cpp outputtype.cpp policy/feerate.cpp policy/policy.cpp protocol.cpp psbt.cpp rpc/rawtransaction_util.cpp rpc/external_signer.cpp rpc/util.cpp scheduler.cpp script/descriptor.cpp script/sign.cpp script/signingprovider.cpp script/standard.cpp versionbitsinfo.cpp warnings.cpp addrdb.h addrman.h attributes.h banman.h base58.h bech32.h blockencodings.h blockfilter.h bloom.h chain.h chainparams.h chainparamsbase.h chainparamsseeds.h checkqueue.h clientversion.h coins.h compat.h compat/assumptions.h compat/byteswap.h compat/cpuid.h compat/endian.h compat/sanity.h compressor.h consensus/consensus.h consensus/tx_check.h consensus/tx_verify.h core_io.h core_memusage.h cuckoocache.h dbwrapper.h external_signer.h flatfile.h fs.h httprpc.h httpserver.h i2p.h index/base.h index/blockfilterindex.h index/coinstatsindex.h index/disktxpos.h index/txindex.h indirectmap.h init.h init/common.h interfaces/chain.h interfaces/echo.h interfaces/handler.h interfaces/init.h interfaces/ipc.h interfaces/node.h interfaces/wallet.h key.h key_io.h logging.h logging/timer.h mapport.h memusage.h merkleblock.h miner.h net.h net_permissions.h net_processing.h net_types.h netaddress.h netbase.h netmessagemaker.h node/blockstorage.h node/coin.h node/coinstats.h node/context.h node/psbt.h node/transaction.h node/ui_interface.h node/utxo_snapshot.h noui.h outputtype.h policy/feerate.h policy/fees.h policy/policy.h policy/rbf.h policy/settings.h pow.h protocol.h psbt.h random.h randomenv.h reverse_iterator.h rpc/blockchain.h rpc/client.h rpc/mining.h rpc/net.h rpc/protocol.h rpc/rawtransaction_util.h rpc/register.h rpc/request.h rpc/server.h rpc/util.h scheduler.h script/descriptor.h script/keyorigin.h script/sigcache.h script/sign.h script/signingprovider.h script/standard.h shutdown.h signet.h streams.h support/allocators/secure.h support/allocators/zeroafterfree.h support/cleanse.h support/events.h support/lockedpool.h sync.h threadinterrupt.h threadsafety.h timedata.h torcontrol.h txdb.h txmempool.h txorphanage.h txrequest.h undo.h util/asmap.h util/bip32.h util/bytevectorhash.h util/check.h util/epochguard.h util/error.h util/fees.h util/getuniquepath.h util/golombrice.h util/hash_type.h util/hasher.h util/macros.h util/message.h util/moneystr.h util/rbf.h util/readwritefile.h util/settings.h util/sock.h util/spanparsing.h util/string.h util/system.h util/thread.h util/threadnames.h util/time.h util/tokenpipe.h util/trace.h util/translation.h util/ui_change_type.h util/url.h util/vector.h validation.h validationinterface.h versionbits.h versionbitsinfo.h wallet/bdb.h wallet/coincontrol.h wallet/coinselection.h wallet/context.h wallet/crypter.h wallet/db.h wallet/dump.h wallet/external_signer_scriptpubkeyman.h wallet/feebumper.h wallet/fees.h wallet/ismine.h wallet/load.h wallet/rpcwallet.h wallet/salvage.h wallet/scriptpubkeyman.h wallet/sqlite.h wallet/wallet.h wallet/walletdb.h wallet/wallettool.h wallet/walletutil.h walletinitinterface.h warnings.h zmq/zmqabstractnotifier.h zmq/zmqnotificationinterface.h zmq/zmqpublishnotifier.h zmq/zmqrpc.h zmq/zmqutil.h zmq/zmqabstractnotifier.cpp zmq/zmqnotificationinterface.cpp zmq/zmqpublishnotifier.cpp zmq/zmqrpc.cpp zmq/zmqutil.cpp amount.h arith_uint256.cpp arith_uint256.h consensus/merkle.cpp consensus/merkle.h consensus/params.h consensus/tx_check.cpp consensus/validation.h hash.cpp hash.h prevector.h primitives/block.cpp primitives/block.h primitives/transaction.cpp primitives/transaction.h pubkey.cpp pubkey.h script/bitcoinconsensus.cpp script/interpreter.cpp script/interpreter.h script/script.cpp script/script.h script/script_error.cpp script/script_error.h serialize.h span.h tinyformat.h uint256.cpp uint256.h util/strencodings.cpp util/strencodings.h version.h support/lockedpool.cpp chainparamsbase.cpp clientversion.cpp compat/glibcxx_sanity.cpp compat/strnlen.cpp fs.cpp interfaces/echo.cpp interfaces/handler.cpp interfaces/init.cpp logging.cpp random.cpp randomenv.cpp rpc/request.cpp support/cleanse.cpp sync.cpp threadinterrupt.cpp util/asmap.cpp util/bip32.cpp util/bytevectorhash.cpp util/error.cpp util/fees.cpp util/getuniquepath.cpp util/hasher.cpp util/sock.cpp util/system.cpp util/message.cpp util/moneystr.cpp util/rbf.cpp util/readwritefile.cpp util/settings.cpp util/thread.cpp util/threadnames.cpp util/spanparsing.cpp util/strencodings.cpp util/string.cpp util/time.cpp util/tokenpipe.cpp addrdb.h addrman.h attributes.h banman.h base58.h bech32.h blockencodings.h blockfilter.h bloom.h chain.h chainparams.h chainparamsbase.h chainparamsseeds.h checkqueue.h clientversion.h coins.h compat.h compat/assumptions.h compat/byteswap.h compat/cpuid.h compat/endian.h compat/sanity.h compressor.h consensus/consensus.h consensus/tx_check.h consensus/tx_verify.h core_io.h core_memusage.h cuckoocache.h dbwrapper.h external_signer.h flatfile.h fs.h httprpc.h httpserver.h i2p.h index/base.h index/blockfilterindex.h index/coinstatsindex.h index/disktxpos.h index/txindex.h indirectmap.h init.h init/common.h interfaces/chain.h interfaces/echo.h interfaces/handler.h interfaces/init.h interfaces/ipc.h interfaces/node.h interfaces/wallet.h key.h key_io.h logging.h logging/timer.h mapport.h memusage.h merkleblock.h miner.h net.h net_permissions.h net_processing.h net_types.h netaddress.h netbase.h netmessagemaker.h node/blockstorage.h node/coin.h node/coinstats.h node/context.h node/psbt.h node/transaction.h node/ui_interface.h node/utxo_snapshot.h noui.h outputtype.h policy/feerate.h policy/fees.h policy/policy.h policy/rbf.h policy/settings.h pow.h protocol.h psbt.h random.h randomenv.h reverse_iterator.h rpc/blockchain.h rpc/client.h rpc/mining.h rpc/net.h rpc/protocol.h rpc/rawtransaction_util.h rpc/register.h rpc/request.h rpc/server.h rpc/util.h scheduler.h script/descriptor.h script/keyorigin.h script/sigcache.h script/sign.h script/signingprovider.h script/standard.h shutdown.h signet.h streams.h support/allocators/secure.h support/allocators/zeroafterfree.h support/cleanse.h support/events.h support/lockedpool.h sync.h threadinterrupt.h threadsafety.h timedata.h torcontrol.h txdb.h txmempool.h txorphanage.h txrequest.h undo.h util/asmap.h util/bip32.h util/bytevectorhash.h util/check.h util/epochguard.h util/error.h util/fees.h util/getuniquepath.h util/golombrice.h util/hash_type.h util/hasher.h util/macros.h util/message.h util/moneystr.h util/rbf.h util/readwritefile.h util/settings.h util/sock.h util/spanparsing.h util/string.h util/system.h util/thread.h util/threadnames.h util/time.h util/tokenpipe.h util/trace.h util/translation.h util/ui_change_type.h util/url.h util/vector.h validation.h validationinterface.h versionbits.h versionbitsinfo.h wallet/bdb.h wallet/coincontrol.h wallet/coinselection.h wallet/context.h wallet/crypter.h wallet/db.h wallet/dump.h wallet/external_signer_scriptpubkeyman.h wallet/feebumper.h wallet/fees.h wallet/ismine.h wallet/load.h wallet/rpcwallet.h wallet/salvage.h wallet/scriptpubkeyman.h wallet/sqlite.h wallet/wallet.h wallet/walletdb.h wallet/wallettool.h wallet/walletutil.h walletinitinterface.h warnings.h zmq/zmqabstractnotifier.h zmq/zmqnotificationinterface.h zmq/zmqpublishnotifier.h zmq/zmqrpc.h zmq/zmqutil.h util/url.cpp 
/usr/bin/xgettext: Non-ASCII string at banman.cpp:18.
                   Please specify the source encoding through --from-code.
QT_SELECT=qt5 /usr/lib/x86_64-linux-gnu/qt5/bin/lupdate -no-obsolete -I. -locations relative qt/bitcoinstrings.cpp qt/forms/addressbookpage.ui qt/forms/askpassphrasedialog.ui qt/forms/coincontroldialog.ui qt/forms/createwalletdialog.ui qt/forms/editaddressdialog.ui qt/forms/helpmessagedialog.ui qt/forms/intro.ui qt/forms/modaloverlay.ui qt/forms/openuridialog.ui qt/forms/optionsdialog.ui qt/forms/overviewpage.ui qt/forms/psbtoperationsdialog.ui qt/forms/receivecoinsdialog.ui qt/forms/receiverequestdialog.ui qt/forms/debugwindow.ui qt/forms/sendcoinsdialog.ui qt/forms/sendcoinsentry.ui qt/forms/signverifymessagedialog.ui qt/forms/transactiondescdialog.ui qt/bantablemodel.cpp qt/bitcoin.cpp qt/bitcoinaddressvalidator.cpp qt/bitcoinamountfield.cpp qt/bitcoingui.cpp qt/bitcoinunits.cpp qt/clientmodel.cpp qt/csvmodelwriter.cpp qt/guiutil.cpp qt/intro.cpp qt/modaloverlay.cpp qt/networkstyle.cpp qt/notificator.cpp qt/optionsdialog.cpp qt/optionsmodel.cpp qt/peertablemodel.cpp qt/peertablesortproxy.cpp qt/platformstyle.cpp qt/qvalidatedlineedit.cpp qt/qvaluecombobox.cpp qt/rpcconsole.cpp qt/splashscreen.cpp qt/trafficgraphwidget.cpp qt/utilitydialog.cpp qt/winshutdownmonitor.cpp qt/addressbookpage.cpp qt/addresstablemodel.cpp qt/askpassphrasedialog.cpp qt/coincontroldialog.cpp qt/coincontroltreewidget.cpp qt/createwalletdialog.cpp qt/editaddressdialog.cpp qt/openuridialog.cpp qt/overviewpage.cpp qt/paymentserver.cpp qt/psbtoperationsdialog.cpp qt/qrimagewidget.cpp qt/receivecoinsdialog.cpp qt/receiverequestdialog.cpp qt/recentrequeststablemodel.cpp qt/sendcoinsdialog.cpp qt/sendcoinsentry.cpp qt/signverifymessagedialog.cpp qt/transactiondesc.cpp qt/transactiondescdialog.cpp qt/transactionfilterproxy.cpp qt/transactionrecord.cpp qt/transactiontablemodel.cpp qt/transactionview.cpp qt/walletcontroller.cpp qt/walletframe.cpp qt/walletmodel.cpp qt/walletmodeltransaction.cpp qt/walletview.cpp qt/addressbookpage.h qt/addresstablemodel.h qt/askpassphrasedialog.h qt/bantablemodel.h qt/bitcoinaddressvalidator.h qt/bitcoinamountfield.h qt/bitcoin.h qt/bitcoingui.h qt/bitcoinunits.h qt/clientmodel.h qt/coincontroldialog.h qt/coincontroltreewidget.h qt/createwalletdialog.h qt/csvmodelwriter.h qt/editaddressdialog.h qt/guiconstants.h qt/guiutil.h qt/intro.h qt/macdockiconhandler.h qt/macnotificationhandler.h qt/macos_appnap.h qt/modaloverlay.h qt/networkstyle.h qt/notificator.h qt/openuridialog.h qt/optionsdialog.h qt/optionsmodel.h qt/overviewpage.h qt/paymentserver.h qt/peertablemodel.h qt/peertablesortproxy.h qt/platformstyle.h qt/psbtoperationsdialog.h qt/qrimagewidget.h qt/qvalidatedlineedit.h qt/qvaluecombobox.h qt/receivecoinsdialog.h qt/receiverequestdialog.h qt/recentrequeststablemodel.h qt/rpcconsole.h qt/sendcoinsdialog.h qt/sendcoinsentry.h qt/sendcoinsrecipient.h qt/signverifymessagedialog.h qt/splashscreen.h qt/trafficgraphwidget.h qt/transactiondesc.h qt/transactiondescdialog.h qt/transactionfilterproxy.h qt/transactionoverviewwidget.h qt/transactionrecord.h qt/transactiontablemodel.h qt/transactionview.h qt/utilitydialog.h qt/walletcontroller.h qt/walletframe.h qt/walletmodel.h qt/walletmodeltransaction.h qt/walletview.h qt/winshutdownmonitor.h qt/macdockiconhandler.mm qt/macnotificationhandler.mm qt/macos_appnap.mm -ts ./qt/locale/bitcoin_en.ts
/home/hebasto/GitHub/bitcoin/src/qt/guiutil.cpp:767: Unterminated C++ character
/home/hebasto/GitHub/bitcoin/src/qt/guiutil.cpp:770: Unterminated C++ character
/home/hebasto/GitHub/bitcoin/src/qt/guiutil.cpp:771: Unterminated C++ character
/home/hebasto/GitHub/bitcoin/src/qt/guiutil.cpp:774: Unterminated C++ character
/home/hebasto/GitHub/bitcoin/src/qt/guiutil.cpp:767: Unbalanced opening parenthesis in C++ code (or abuse of the C++ preprocessor)
Updating 'qt/locale/bitcoin_en.ts'...
    Found 892 source text(s) (53 new and 839 already existing)
    Removed 207 obsolete entries
QT_SELECT=qt5 /usr/lib/x86_64-linux-gnu/qt5/bin/lconvert -o ./qt/locale/bitcoin_en.xlf -i ./qt/locale/bitcoin_en.ts
make: Leaving directory '/home/hebasto/GitHub/bitcoin/src'

I figured it out but it is pretty strange: It depends on what directory it is run from. I am using out-of-tree builds so in my case, lupdate is run from an external build directory with absolute paths for all its input files. Say, you have the following script lupdate.sh:

ROOT="$1"
QT_SELECT=qt5 /usr/lib/x86_64-linux-gnu/qt5/bin/lupdate -no-obsolete -I. -locations relative ${ROOT}/src/qt/bitcoinstrings.cpp ${ROOT}/src/qt/forms/addressbookpage.ui ${ROOT}/src/qt/forms/askpassphrasedialog.ui ${ROOT}/src/qt/forms/coincontroldialog.ui ${ROOT}/src/qt/forms/createwalletdialog.ui ${ROOT}/src/qt/forms/editaddressdialog.ui ${ROOT}/src/qt/forms/helpmessagedialog.ui ${ROOT}/src/qt/forms/intro.ui ${ROOT}/src/qt/forms/modaloverlay.ui ${ROOT}/src/qt/forms/openuridialog.ui ${ROOT}/src/qt/forms/optionsdialog.ui ${ROOT}/src/qt/forms/overviewpage.ui ${ROOT}/src/qt/forms/psbtoperationsdialog.ui ${ROOT}/src/qt/forms/receivecoinsdialog.ui ${ROOT}/src/qt/forms/receiverequestdialog.ui ${ROOT}/src/qt/forms/debugwindow.ui ${ROOT}/src/qt/forms/sendcoinsdialog.ui ${ROOT}/src/qt/forms/sendcoinsentry.ui ${ROOT}/src/qt/forms/signverifymessagedialog.ui ${ROOT}/src/qt/forms/transactiondescdialog.ui ${ROOT}/src/qt/bantablemodel.cpp ${ROOT}/src/qt/bitcoin.cpp ${ROOT}/src/qt/bitcoinaddressvalidator.cpp ${ROOT}/src/qt/bitcoinamountfield.cpp ${ROOT}/src/qt/bitcoingui.cpp ${ROOT}/src/qt/bitcoinunits.cpp ${ROOT}/src/qt/clientmodel.cpp ${ROOT}/src/qt/csvmodelwriter.cpp ${ROOT}/src/qt/guiutil.cpp ${ROOT}/src/qt/intro.cpp ${ROOT}/src/qt/modaloverlay.cpp ${ROOT}/src/qt/networkstyle.cpp ${ROOT}/src/qt/notificator.cpp ${ROOT}/src/qt/optionsdialog.cpp ${ROOT}/src/qt/optionsmodel.cpp ${ROOT}/src/qt/peertablemodel.cpp ${ROOT}/src/qt/peertablesortproxy.cpp ${ROOT}/src/qt/platformstyle.cpp ${ROOT}/src/qt/qvalidatedlineedit.cpp ${ROOT}/src/qt/qvaluecombobox.cpp ${ROOT}/src/qt/rpcconsole.cpp ${ROOT}/src/qt/splashscreen.cpp ${ROOT}/src/qt/trafficgraphwidget.cpp ${ROOT}/src/qt/utilitydialog.cpp ${ROOT}/src/qt/winshutdownmonitor.cpp ${ROOT}/src/qt/addressbookpage.cpp ${ROOT}/src/qt/addresstablemodel.cpp ${ROOT}/src/qt/askpassphrasedialog.cpp ${ROOT}/src/qt/coincontroldialog.cpp ${ROOT}/src/qt/coincontroltreewidget.cpp ${ROOT}/src/qt/createwalletdialog.cpp ${ROOT}/src/qt/editaddressdialog.cpp ${ROOT}/src/qt/openuridialog.cpp ${ROOT}/src/qt/overviewpage.cpp ${ROOT}/src/qt/paymentserver.cpp ${ROOT}/src/qt/psbtoperationsdialog.cpp ${ROOT}/src/qt/qrimagewidget.cpp ${ROOT}/src/qt/receivecoinsdialog.cpp ${ROOT}/src/qt/receiverequestdialog.cpp ${ROOT}/src/qt/recentrequeststablemodel.cpp ${ROOT}/src/qt/sendcoinsdialog.cpp ${ROOT}/src/qt/sendcoinsentry.cpp ${ROOT}/src/qt/signverifymessagedialog.cpp ${ROOT}/src/qt/transactiondesc.cpp ${ROOT}/src/qt/transactiondescdialog.cpp ${ROOT}/src/qt/transactionfilterproxy.cpp ${ROOT}/src/qt/transactionrecord.cpp ${ROOT}/src/qt/transactiontablemodel.cpp ${ROOT}/src/qt/transactionview.cpp ${ROOT}/src/qt/walletcontroller.cpp ${ROOT}/src/qt/walletframe.cpp ${ROOT}/src/qt/walletmodel.cpp ${ROOT}/src/qt/walletmodeltransaction.cpp ${ROOT}/src/qt/walletview.cpp ${ROOT}/src/qt/addressbookpage.h ${ROOT}/src/qt/addresstablemodel.h ${ROOT}/src/qt/askpassphrasedialog.h ${ROOT}/src/qt/bantablemodel.h ${ROOT}/src/qt/bitcoinaddressvalidator.h ${ROOT}/src/qt/bitcoinamountfield.h ${ROOT}/src/qt/bitcoin.h ${ROOT}/src/qt/bitcoingui.h ${ROOT}/src/qt/bitcoinunits.h ${ROOT}/src/qt/clientmodel.h ${ROOT}/src/qt/coincontroldialog.h ${ROOT}/src/qt/coincontroltreewidget.h ${ROOT}/src/qt/createwalletdialog.h ${ROOT}/src/qt/csvmodelwriter.h ${ROOT}/src/qt/editaddressdialog.h ${ROOT}/src/qt/guiconstants.h ${ROOT}/src/qt/guiutil.h ${ROOT}/src/qt/intro.h ${ROOT}/src/qt/macdockiconhandler.h ${ROOT}/src/qt/macnotificationhandler.h ${ROOT}/src/qt/macos_appnap.h ${ROOT}/src/qt/modaloverlay.h ${ROOT}/src/qt/networkstyle.h ${ROOT}/src/qt/notificator.h ${ROOT}/src/qt/openuridialog.h ${ROOT}/src/qt/optionsdialog.h ${ROOT}/src/qt/optionsmodel.h ${ROOT}/src/qt/overviewpage.h ${ROOT}/src/qt/paymentserver.h ${ROOT}/src/qt/peertablemodel.h ${ROOT}/src/qt/peertablesortproxy.h ${ROOT}/src/qt/platformstyle.h ${ROOT}/src/qt/psbtoperationsdialog.h ${ROOT}/src/qt/qrimagewidget.h ${ROOT}/src/qt/qvalidatedlineedit.h ${ROOT}/src/qt/qvaluecombobox.h ${ROOT}/src/qt/receivecoinsdialog.h ${ROOT}/src/qt/receiverequestdialog.h ${ROOT}/src/qt/recentrequeststablemodel.h ${ROOT}/src/qt/rpcconsole.h ${ROOT}/src/qt/sendcoinsdialog.h ${ROOT}/src/qt/sendcoinsentry.h ${ROOT}/src/qt/sendcoinsrecipient.h ${ROOT}/src/qt/signverifymessagedialog.h ${ROOT}/src/qt/splashscreen.h ${ROOT}/src/qt/trafficgraphwidget.h ${ROOT}/src/qt/transactiondesc.h ${ROOT}/src/qt/transactiondescdialog.h ${ROOT}/src/qt/transactionfilterproxy.h ${ROOT}/src/qt/transactionoverviewwidget.h ${ROOT}/src/qt/transactionrecord.h ${ROOT}/src/qt/transactiontablemodel.h ${ROOT}/src/qt/transactionview.h ${ROOT}/src/qt/utilitydialog.h ${ROOT}/src/qt/walletcontroller.h ${ROOT}/src/qt/walletframe.h ${ROOT}/src/qt/walletmodel.h ${ROOT}/src/qt/walletmodeltransaction.h ${ROOT}/src/qt/walletview.h ${ROOT}/src/qt/winshutdownmonitor.h ${ROOT}/src/qt/macdockiconhandler.mm ${ROOT}/src/qt/macnotificationhandler.mm ${ROOT}/src/qt/macos_appnap.mm -ts ${ROOT}/src/qt/locale/bitcoin_en.ts

# from the source tree
$ cd …/bitcoin/src
$ lupdate.sh ..
…/bitcoin/src/qt/guiutil.cpp:767: Unterminated C++ character
…/bitcoin/src/qt/guiutil.cpp:770: Unterminated C++ character
…/bitcoin/src/qt/guiutil.cpp:771: Unterminated C++ character
…/bitcoin/src/qt/guiutil.cpp:774: Unterminated C++ character
…/src/qt/guiutil.cpp:767: Unbalanced opening parenthesis in C++ code (or abuse of the C++ preprocessor)
Updating 'qt/locale/bitcoin_en.ts'...
    Found 1048 source text(s) (0 new and 1048 already existing)

# any other directory
$ cd ../build/src
$ lupdate.sh /full/path/to/bitcoin
…/bitcoin/src/qt/bantablemodel.cpp:85: Qualifying with unknown namespace/class ::BanTableModel             
…/bitcoin/src/qt/bitcoin.cpp:421: Qualifying with unknown namespace/class ::BitcoinApplication             
…/bitcoin/src/qt/bitcoin.cpp:431: Qualifying with unknown namespace/class ::BitcoinApplication             
…/bitcoin/src/qt/bitcoingui.cpp:247: Qualifying with unknown namespace/class ::BitcoinGUI             
…/bitcoin/src/qt/bitcoingui.cpp:457: Qualifying with unknown namespace/class ::BitcoinGUI                
…/bitcoin/src/qt/bitcoingui.cpp:547: Qualifying with unknown namespace/class ::BitcoinGUI                
⋮  (lots more!)
Updating '…/bitcoin/src/qt/locale/bitcoin_en.ts'...
    Found 1048 source text(s) (0 new and 1048 already existing)

So I guess the good news is that I can confirm that the change in this PR works, given you're not doing an out-of-tree build :smile: I don't think it matters much: the generated ts is exactly the same.

@laanwj

I figured it out but it is pretty strange: It depends on what directory it is run from. I am using out-of-tree builds so in my case, lupdate is run from an external build directory with absolute paths for all its input files.

I hope it should work now :)

Thanks! It does. Tested ACK 88bdc4d33eaeefb5cfe41bb4aa565c0cb361a982