rpc: bumpfee/psbtbumpfee fixes and updates #22021

1. 
   jonatack commented at 7:39 am on May 22, 2021: member

   Follow-up to #21544 and #20891 for the bumpfee_helper used for RPCs bumpfee and psbtbumpfee:

   • “psbt” field is only returned in psbtbumpfee and not bumpfee
   • bumpfee raises if private keys are disabled, so the txid help “Only returned when wallet private keys are enabled.” no longer makes sense; remove it
   • add missing space in RPC examples (“Bump the fee, get the new transaction’stxid”)
   • update txid/psbt code comments
2. rpc: fix docs for bumpfee psbt update

   - "psbt" field is only returned in psbtbumpfee and not bumpfee
   - bumpfee raises if privkeys are disabled, so drop "Only returned when wallet private keys are enabled."
   - add missing space in RPC example

   5cb7ac23fb
3. rpc: fix code comment for bumpfee/psbtbumpfee output 4f504f826b
4. DrahtBot added the label RPC/REST/ZMQ on May 22, 2021
5. DrahtBot added the label Wallet on May 22, 2021
6. MarcoFalke added the label Docs on May 22, 2021
7. klementtan approved
8. 
   klementtan commented at 6:09 am on May 25, 2021: contributor

   ACK 4f504f8

   Tested with:

   0./src/bitcoin-cli -signet -rpcwallet="" bumpfee 53fd06a174a6ed139844b73be3a8bd9b6984855dafa38edf9732bfe54a77f39e
   1{
   2  "txid": "0bff0a2c14a4d4f624a423d1f5d73dc65f9146d9e33369e8d875c40818d0fff1",
   3  "origfee": 0.00000141,
   4  "fee": 0.00000846,
   5  "errors": [
   6  ]
   7}
   

   0./src/bitcoin-cli -signet -rpcwallet="" psbtbumpfee 0bff0a2c14a4d4f624a423d1f5d73dc65f9146d9e33369e8d875c40818d0fff1
   1{
   2  "psbt": "cHNidP8BAHECAAAAAR0A8Z1EYfhQgM040NV0jx4/HqaOwCrgHIyIFwsrzPttAQAAAAD9////AmFpmAAAAAAAFgAU++0HvESODcYxKB421Oin6aEIIZgQJwAAAAAAABYAFPQLCGC9h0Zg4cuhpOw9XgcTRHVfe5kAAAABAHECAAAAAYV8foL9SnOL/9hhb7NZ9heas723U9rWTPkmfRASfoyVAQAAAAD+////AlFDF0YAAAAAFgAUT4fSzqO0dT+DMENerKXEPmGwGrCAlpgAAAAAABYAFDjxsgPhvMMM7ScaDBw6f0vGwE+A1JIAAAEBH4CWmAAAAAAAFgAUOPGyA+G8wwztJxoMHDp/S8bAT4AiBgMUuxoE+7GyRBT6D75V2c28R544Ee6cUHmpnQhKdaicPxCk/7hAAAAAgAAAAIABAACAACICAxnzEp1IebkClyUdqFBsJi8shT+2JkDmqYvRpdS8XAEOEKT/uEAAAACAAQAAgAQAAIAAAA==",
   3  "origfee": 0.00000846,
   4  "fee": 0.00001551,
   5  "errors": [
   6  ]
   7}
   

    0./src/bitcoin-cli -signet -rpcwallet="" bumpfee
    1...
    2Result:
    3{                    (json object)
    4  "txid" : "hex",    (string) The id of the new transaction.
    5  "origfee" : n,     (numeric) The fee of the replaced transaction.
    6  "fee" : n,         (numeric) The fee of the new transaction.
    7  "errors" : [       (json array) Errors encountered during processing (may be empty).
    8    "str",           (string)
    9    ...
   10  ]
   11}
   12
   13Examples:
   14
   15Bump the fee, get the new transaction's txid
   

9. 
   MarcoFalke commented at 6:59 am on May 25, 2021: member

   Rendered diff:

    0diff --git a/bumpfee b/bumpfee
    1index accdd42..6acef40 100644
    2--- a/bumpfee
    3+++ b/bumpfee
    4@@ -40,8 +40,7 @@ Arguments:
    5 
    6 Result:
    7 {                    (json object)
    8-  "psbt" : "str",    (string) The base64-encoded unsigned PSBT of the new transaction.
    9-  "txid" : "hex",    (string) The id of the new transaction. Only returned when wallet private keys are enabled.
   10+  "txid" : "hex",    (string) The id of the new transaction.
   11   "origfee" : n,     (numeric) The fee of the replaced transaction.
   12   "fee" : n,         (numeric) The fee of the new transaction.
   13   "errors" : [       (json array) Errors encountered during processing (may be empty).
   14@@ -52,5 +51,5 @@ Result:
   15 
   16 Examples:
   17 
   18-Bump the fee, get the new transaction'stxid
   19+Bump the fee, get the new transaction's txid
   20 > bitcoin-cli bumpfee <txid>
   21diff --git a/psbtbumpfee b/psbtbumpfee
   22index ac15520..7e4287c 100644
   23--- a/psbtbumpfee
   24+++ b/psbtbumpfee
   25@@ -52,5 +52,5 @@ Result:
   26 
   27 Examples:
   28 
   29-Bump the fee, get the new transaction'spsbt
   30+Bump the fee, get the new transaction's psbt
   31 > bitcoin-cli psbtbumpfee <txid>
   

10. MarcoFalke merged this on May 25, 2021
11. MarcoFalke closed this on May 25, 2021

    ---

12. jonatack deleted the branch on May 25, 2021
13. sidhujag referenced this in commit ddb28d1120 on May 25, 2021
14. gwillen referenced this in commit 53344c6b08 on Jun 1, 2022
15. DrahtBot locked this on Aug 16, 2022

Contributors
jonatack klementtan MarcoFalke

Labels
Docs Wallet RPC/REST/ZMQ