[WIP] ci: Do not cache depends/sources directory #22058

1. 
   hebasto commented at 1:55 pm on May 25, 2021: member

   Caching the depends/sources directory does not handle a source file update well, and it causes CI job failure.

   See https://cirrus-ci.com/task/5975797421834240:

    0  CXXLD    qt/bitcoin-qt
    1  CXXLD    qt/test/test_bitcoin-qt
    2make[1]: Leaving directory '/tmp/cirrus-ci-build/src'
    3make -C .. bitcoin_qt_apk
    4make[1]: Entering directory '/tmp/cirrus-ci-build/src'
    5tar: ../depends/sources/qtbase-everywhere-src-5.12.11.tar.xz: Not found in archive
    6tar: Exiting with failure status due to previous errors
    7tar: ../depends/sources/qtbase-everywhere-src-5.12.11.tar.xz: Not found in archive
    8tar: Exiting with failure status due to previous errors
    9tar: ../depends/sources/qtbase-everywhere-src-5.12.11.tar.xz: Not found in archive
   10tar: Exiting with failure status due to previous errors
   11mkdir -p qt/android/libs/arm64-v8a
   12cp /tmp/cirrus-ci-build/depends/SDKs/android/ndk/21.1.6352462/toolchains/llvm/prebuilt/linux-x86_64/bin//../sysroot/usr/lib/aarch64-linux-android/libc++_shared.so qt/android/libs/arm64-v8a
   13tar xf ../depends/sources/qtbase-everywhere-src-5.12.10.tar.xz ../depends/sources/qtbase-everywhere-src-5.12.11.tar.xz -C qt/android/src/ src/android/jar/src --strip-components=5
   14tar: ../depends/sources/qtbase-everywhere-src-5.12.11.tar.xz: Not found in archive
   15tar: src/android/jar/src: Not found in archive
   16tar: Exiting with failure status due to previous errors
   17make[1]: *** [Makefile:17975: bitcoin_qt_apk] Error 2
   18make[1]: Leaving directory '/tmp/cirrus-ci-build/src'
   19make: *** [Makefile:11: apk] Error 2
   

2. ci: Do not cache depends/sources directory 61545f6f75
3. fanquake added the label Tests on May 25, 2021
4. 
   laanwj commented at 2:42 pm on May 25, 2021: member

   Does this mean the sources will be re-downloaded for every CI check, which would be kind of wasteful of resources? Couldn’t we make this conditional in some way?
5. MarcoFalke changes_requested
6. 
   MarcoFalke commented at 2:47 pm on May 25, 2021: member

   NACK this patch. This is reverting fa52d7d3adc99c0e716628058b4fd083034d27e0
7. 
   hebasto commented at 2:47 pm on May 25, 2021: member

   Does this mean the sources will be re-downloaded for every CI check, which would be kind of wasteful of resources?

   The depends_sources_cache is used in the only CI job – ARM64 Android APK [focal]

   Couldn’t we make this conditional in some way?

   I really was trying to find such a way. Another option is to invalidate cache via CI Cirrus web console, but it invalidates all caches.

8. hebasto closed this on May 25, 2021

   ---

9. 
   MarcoFalke commented at 2:52 pm on May 25, 2021: member

   It shouldn’t matter if the thing is downloaded from cirrus cache or from the qt website.

   Replacing this with something like this should be just fine:

   0if android:
   1 make download qt && make extract qt
   

10. 
    MarcoFalke commented at 2:54 pm on May 25, 2021: member

    If that is too hard to implement, a hacky emergency workaround could be to change the name of the cirrus task to drop the cache.
11. hebasto deleted the branch on May 25, 2021
12. laanwj referenced this in commit 22b845291c on May 27, 2021
13. sidhujag referenced this in commit 580eedf999 on May 27, 2021
14. DrahtBot locked this on Aug 16, 2022

Contributors
hebasto laanwj MarcoFalke

Labels
Tests