[WIP] ci: Do not cache depends/sources directory #22058

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:210525-cache changing 1 files +0 −2
  1. hebasto commented at 1:55 PM on May 25, 2021: member

    Caching the depends/sources directory does not handle a source file update well, and it causes CI job failure.

    See https://cirrus-ci.com/task/5975797421834240:

      CXXLD    qt/bitcoin-qt
      CXXLD    qt/test/test_bitcoin-qt
    make[1]: Leaving directory '/tmp/cirrus-ci-build/src'
    make -C .. bitcoin_qt_apk
    make[1]: Entering directory '/tmp/cirrus-ci-build/src'
    tar: ../depends/sources/qtbase-everywhere-src-5.12.11.tar.xz: Not found in archive
    tar: Exiting with failure status due to previous errors
    tar: ../depends/sources/qtbase-everywhere-src-5.12.11.tar.xz: Not found in archive
    tar: Exiting with failure status due to previous errors
    tar: ../depends/sources/qtbase-everywhere-src-5.12.11.tar.xz: Not found in archive
    tar: Exiting with failure status due to previous errors
    mkdir -p qt/android/libs/arm64-v8a
    cp /tmp/cirrus-ci-build/depends/SDKs/android/ndk/21.1.6352462/toolchains/llvm/prebuilt/linux-x86_64/bin//../sysroot/usr/lib/aarch64-linux-android/libc++_shared.so qt/android/libs/arm64-v8a
    tar xf ../depends/sources/qtbase-everywhere-src-5.12.10.tar.xz ../depends/sources/qtbase-everywhere-src-5.12.11.tar.xz -C qt/android/src/ src/android/jar/src --strip-components=5
    tar: ../depends/sources/qtbase-everywhere-src-5.12.11.tar.xz: Not found in archive
    tar: src/android/jar/src: Not found in archive
    tar: Exiting with failure status due to previous errors
    make[1]: *** [Makefile:17975: bitcoin_qt_apk] Error 2
    make[1]: Leaving directory '/tmp/cirrus-ci-build/src'
    make: *** [Makefile:11: apk] Error 2
    
  2. ci: Do not cache depends/sources directory 61545f6f75
  3. fanquake added the label Tests on May 25, 2021
  4. laanwj commented at 2:42 PM on May 25, 2021: member

    Does this mean the sources will be re-downloaded for every CI check, which would be kind of wasteful of resources? Couldn't we make this conditional in some way?

  5. MarcoFalke changes_requested
  6. MarcoFalke commented at 2:47 PM on May 25, 2021: member

    NACK this patch. This is reverting fa52d7d3adc99c0e716628058b4fd083034d27e0

  7. hebasto commented at 2:47 PM on May 25, 2021: member

    Does this mean the sources will be re-downloaded for every CI check, which would be kind of wasteful of resources?

    The depends_sources_cache is used in the only CI job -- ARM64 Android APK [focal]

    Couldn't we make this conditional in some way?

    I really was trying to find such a way. Another option is to invalidate cache via CI Cirrus web console, but it invalidates all caches.

  8. hebasto closed this on May 25, 2021

  9. MarcoFalke commented at 2:52 PM on May 25, 2021: member

    It shouldn't matter if the thing is downloaded from cirrus cache or from the qt website.

    Replacing this with something like this should be just fine:

    if android:
     make download qt && make extract qt
    
  10. MarcoFalke commented at 2:54 PM on May 25, 2021: member

    If that is too hard to implement, a hacky emergency workaround could be to change the name of the cirrus task to drop the cache.

  11. hebasto deleted the branch on May 25, 2021
  12. laanwj referenced this in commit 22b845291c on May 27, 2021
  13. sidhujag referenced this in commit 580eedf999 on May 27, 2021
  14. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 03:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me