doc: improve note on choosing posix mingw32 #22088

1. 
   jarolrod commented at 7:33 pm on May 27, 2021: member

   The current windows build doc can lead someone to believe that the step where you must choose the posix mingw32 g++ compiler option is only for Ubuntu 18.04. It is only until you (or just me) go through the cross-compile process and realize that it’s not building because you didn’t set this option on > Ubuntu 18.04. Then you come back and read the footnotes and see: Starting from Ubuntu Xenial 16.04....

   This PR improves this portion of the doc by editing the text around this stage to state “this is now the next step”. We could add a note saying Ubuntu 18.04 and up, but this is redundant as it’s unlikely someone will be using < Ubuntu 18.04 since it’s not officially supported by our build system. While here, some minor fixups and add some more guidance to completing this step.

   Master: render PR: render

2. 
   dongcarl commented at 7:41 pm on May 27, 2021: member

   Huh… Perhaps our configure.ac should also search for x86_64-w64-mingw32-g++-posix first before x86_64-w64-mingw32-g++? Just an idea.
3. in doc/build-windows.md:84 in 6e745eb000 outdated

   80@@ -81,9 +81,26 @@ The first step is to install the mingw-w64 cross-compilation tool chain:
   81 
   82     sudo apt install g++-mingw-w64-x86-64
   83 
   84-Ubuntu Bionic 18.04 <sup>[1](#footnote1)</sup>:
   85+Next, set the default `mingw32 g++` compiler option to POSIX (For Ubuntu Bionic 18.04 and up<sup>[1](#footnote1)</sup>):
   

   ---

   ---

   

   hebasto commented at 7:42 pm on May 27, 2021:

   Why mention “18.04 and up”? If this is Ubuntu-specific, I don’t think anyone uses pre-xenial distros.

   ---

   

   jarolrod commented at 7:47 pm on May 27, 2021:

   true … I guess that part can be dropped, and the note is improved by just saying “this is the next step”

   ---

   

   jarolrod commented at 11:08 pm on May 27, 2021:

   addressed in dafab2b
4. DrahtBot added the label Docs on May 27, 2021
5. doc: improve note on choosing posix mingw32 dafab2b1b3
6. jarolrod force-pushed on May 27, 2021
7. 
   jarolrod commented at 11:06 pm on May 27, 2021: member

   updated from 6e745eb -> dafab2b (pr22088.01 -> pr22088.02, diff)

   Changes:

   • Address @hebasto comment.
     • Drop specifying “Ubuntu 18.04 and up” in favor of just saying “This is the next step”. This is ok to do as it’s unlikely someone will use < Ubuntu 18.04 since it’s not officially supported by our build system.
8. hebasto approved
9. 
   hebasto commented at 5:06 am on May 28, 2021: member

   ACK dafab2b1b37d1966610b2189e71c52e3af38dfaa

   Also, it seems reasonable to s/“both the 32 and 64 bit Mingw-w64 packages install”/“Mingw-w64 package installs”/ in the footnote, don’t it?

10. 
    DrahtBot commented at 3:23 pm on May 28, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #22093 (build: Try posix-specific CXX first for mingw32 host by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. 
    laanwj commented at 3:00 pm on June 2, 2021: member

    Clearly an improvement, agree that it was confusing ACK dafab2b1b37d1966610b2189e71c52e3af38dfaa
12. laanwj merged this on Jun 2, 2021
13. laanwj closed this on Jun 2, 2021

    ---

14. sidhujag referenced this in commit 00cad04faf on Jun 3, 2021
15. gwillen referenced this in commit aca7078cf9 on Jun 1, 2022
16. DrahtBot locked this on Aug 16, 2022

Contributors
jarolrod dongcarl hebasto DrahtBot laanwj

Labels
Docs