Remove `Warning:` from warning message printed for unknown new rules #22102

pull ghost wants to merge 1 commits into bitcoin:master from changing 2 files +3 −3

ghost commented at 3:34 PM on May 30, 2021: none
Reason: I noticed that Warning is printed 2 times in -getinfo while reviewing #21832 (comment)

Same string is used for GUI, log and stderr. If we need to add Warning: in GUI or other place we can always prepend to this string.

CLI:
```
Warnings: Unknown new rules activated (versionbit 28)
```
GUI:
DrahtBot added the label Validation on May 30, 2021
klementtan approved
klementtan commented at 4:49 PM on May 30, 2021: contributor

ACK db99bab

Good catch!
laanwj commented at 12:10 PM on June 7, 2021: member
Yes, it is unnecessary to prepend "warning" to a warning. Code review ACK

Can you please change your git author and committer name in the commits though? It shows as "unknown". Also, please squash the two commits, changing the test and tested code is one atomic change.
```
commit db99bab2d8400e269e5c52cb69c88a7de02470aa (pull/22102/head)
Author:     unknown <prayank…>
AuthorDate: Sun May 30 21:39:36 2021 +0530
Commit:     unknown <prayank…>
CommitDate: Sun May 30 21:39:36 2021 +0530

    change warning message in test
```

Remove `Warning:`

+ Remove `Warning:` from warning message printed for unknown new rules
+ Change warning message in test

Author:    Prayank <prayank@tutanota.de>

6d7e46ce23

DrahtBot commented at 5:03 PM on June 12, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #22229 (test: consolidate to f-strings (part 1) by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
ghost commented at 1:07 AM on June 13, 2021: none

Can you please change your git author and committer name in the commits though? It shows as "unknown". Also, please squash the two commits, changing the test and tested code is one atomic change. @laanwj Done ✔️
MarcoFalke commented at 7:20 AM on June 13, 2021: member

review ACK 6d7e46ce23217da53ff52f535879c393c02fa2b2
MarcoFalke merged this on Jun 13, 2021
MarcoFalke closed this on Jun 13, 2021
sidhujag referenced this in commit 6972699a0e on Jun 13, 2021
gwillen referenced this in commit ae37da1ad8 on Jun 1, 2022
DrahtBot locked this on Aug 16, 2022

Contributors

Labels