doc: Various validation doc fixups #22121

1. 
   MarcoFalke commented at 7:49 am on June 2, 2021: member
2. DrahtBot added the label Validation on Jun 2, 2021
3. 
   DrahtBot commented at 11:07 am on June 2, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19438 (Introduce deploymentstatus by ajtowns)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   MarcoFalke commented at 6:38 am on June 3, 2021: member

   This includes the changes from #21816
5. 
   michaelfolkson commented at 11:06 am on June 3, 2021: contributor

   This appears to be minor typos, rephrasing and a renaming of RewindBlockIndex to NeedsRedownload and BlockMetadataManager to BlockManager. It would be nice for reviewers to have a PR description explaining the context for these renamings rather than needing to explore a chain of PRs to figure it out.

   RewindBlockIndex was removed in #21009 but wasn’t removed from all the comments in that PR.

   I don’t know why BlockMetadataManager was in the comments. It was introduced in #16194 but only in the comments but not the code. It is referred to in #15606 but not introduced in the code.

6. 
   MarcoFalke commented at 11:51 am on June 3, 2021: member

   It seems to be introduced in #15606 but that isn’t merged yet.

   I don’t think this pull introduces it either. It is just another outdated comment (or typo) in the pull description.

7. 
   michaelfolkson commented at 11:53 am on June 3, 2021: contributor

   ACK fac7e42a148897931a9d53ee6e97ec400cfa00b6
8. doc: Various validation doc fixups

   * Rename RewindBlockIndex -> NeedsRedownload (follow-up to commit
     d831e711cab83c70bf2ded62fe33f484844e73dd)
   * Fix typos
   * Inline comments about faking chain data to avoid duplicating them

   fa4245d884
9. MarcoFalke force-pushed on Jun 3, 2021
10. 
    MarcoFalke commented at 11:54 am on June 3, 2021: member

    needing to explore a chain of PRs to figure it out

    Force pushed to mention the commit id in the commit body

11. 
    michaelfolkson commented at 12:39 pm on June 3, 2021: contributor

    Re-ACK fa4245d88409091a3a6115a96a200b70be663725
12. 
    jnewbery commented at 4:12 pm on June 3, 2021: member

    ACK fa4245d884
13. MarcoFalke requested review from jamesob on Jun 4, 2021
14. fanquake merged this on Jun 4, 2021
15. fanquake closed this on Jun 4, 2021

    ---

16. MarcoFalke deleted the branch on Jun 4, 2021
17. 
    jamesob commented at 1:48 pm on June 4, 2021: member

    ACK, thanks!
18. sidhujag referenced this in commit cd2813b519 on Jun 4, 2021
19. gwillen referenced this in commit 5e3a998967 on Jun 1, 2022
20. DrahtBot locked this on Aug 18, 2022

Contributors
MarcoFalke DrahtBot michaelfolkson jnewbery jamesob

Review Requested
jamesob

Labels
Validation