This is confusing and might even slow down the test.
This reverts a change that was added a year ago in d438d60 and then the need for it was removed by 95d5d5e six months ago.
test: Remove unused node from feature_nulldummy #22150
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2106-testFaster changing 1 files +4 −4-
MarcoFalke commented at 1:36 PM on June 4, 2021: member
-
test: Remove unused node from feature_nulldummy fa2b6c62cd
- fanquake added the label Tests on Jun 4, 2021
-
DrahtBot commented at 4:28 PM on June 4, 2021: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
jonatack commented at 8:34 PM on June 4, 2021: member
ACK 346e52afd6d5e317c96fc506bb54cde13e87c8b2 this reverts a change that was added a year ago in d438d60 and then the need for it was removed by 95d5d5e six months ago
(perhaps add this context to the PR description)
-
MarcoFalke commented at 6:40 AM on June 5, 2021: member
Thanks for digging up the context! Added to description.
- MarcoFalke merged this on Jun 5, 2021
- MarcoFalke closed this on Jun 5, 2021
- MarcoFalke deleted the branch on Jun 5, 2021
- sidhujag referenced this in commit 26cdc5ece0 on Jun 6, 2021
- gwillen referenced this in commit 2971071544 on Jun 1, 2022
- DrahtBot locked this on Aug 18, 2022
Contributors
Labels