Follow-up documentation to #22050 that removed support for Tor version 2 hidden services from Bitcoin Core.
doc: update tor.md, release notes with removal of tor v2 support #22172
pull jonatack wants to merge 2 commits into bitcoin:master from jonatack:tor-v2-removal-documentation changing 2 files +18 −3-
jonatack commented at 5:28 PM on June 6, 2021: member
-
doc: update tor.md with removal of tor v2 support 49938eee9c
- DrahtBot added the label Docs on Jun 6, 2021
-
in doc/tor.md:27 in 83d75d21b5 outdated
25 | @@ -18,7 +26,7 @@ information in the debug log about your Tor configuration. 26 | CLI `-addrinfo` returns the number of addresses known to your node per network 27 | type, including Tor v2 and v3. This is useful to see how many onion addresses
jarolrod commented at 7:40 PM on June 6, 2021:Since #22050, and for Bitcoin Core 22.0, our node shouldn't know of Torv2 addresses. So this should be updated.
type. This is useful to see how many onion addresses$ ./src/bitcoin-cli -addrinfo { "addresses_known": { "ipv4": 11975, "ipv6": 2395, "torv2": 0, "torv3": 10, "i2p": 0, "total": 14380 } }
jonatack commented at 8:07 PM on June 6, 2021:Hmm, and there is the same info in the release notes for -addrinfo. For now, -addrinfo returns "torv2" and "torv3", so my thought was that this should be updated when -addrinfo is changed to return only "onion" instead, probably for v23. WDYT? (thanks for having a look!)
jarolrod commented at 8:08 PM on June 6, 2021:yeah, makes sense. Can be left for a followup
jarolrod commented at 8:10 PM on June 6, 2021: memberACK 83d75d21b5d9811cf04cb3c0f51b588a7ec7097e
DrahtBot commented at 10:14 PM on June 6, 2021: member<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #21158 (lib: Add Taproot support to libconsensus by jrawsthorne)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Zero-1729 commented at 5:42 AM on June 7, 2021: contributorACK 83d75d21b5d9811cf04cb3c0f51b588a7ec7097e, looks good.
unknown approvedunknown commented at 7:39 AM on June 7, 2021: noneZero-1729 approvedklementtan approvedklementtan commented at 1:50 PM on June 10, 2021: contributorACK 83d75d2
doc: update release notes with removal of tor v2 support 2ad034a890in doc/release-notes.md:68 in 83d75d21b5 outdated
63 | + v3 only, as the Tor network [dropped support for Tor 64 | + v2](https://blog.torproject.org/v2-deprecation-timeline) with the release of 65 | + Tor version 0.4.6. Henceforth, Bitcoin Core ignores Tor v2 addresses; it 66 | + neither rumors them over the network to other peers nor stores them in memory 67 | + or to `peers.dat`. Tor v2 addresses are ignored by 68 | + `contrib/seeds/generate-seeds.py` and have been removed from the hard-coded
laanwj commented at 9:52 AM on June 12, 2021:I don't think changes to maintainer-facing tools such as
generate-seedsneed to be in the release notes. Not a big deal though.
jonatack force-pushed on Jun 12, 2021laanwj commented at 10:23 AM on June 12, 2021: memberACK 2ad034a89095bc1b148bdeeacfa5b75ec23b8a21
laanwj merged this on Jun 12, 2021laanwj closed this on Jun 12, 2021jonatack deleted the branch on Jun 12, 2021sidhujag referenced this in commit d17f356962 on Jun 13, 2021furszy referenced this in commit c771695563 on Jul 29, 2021furszy referenced this in commit adda20d9ce on Jul 30, 2021furszy referenced this in commit 34b5fc93ef on Jul 31, 2021furszy referenced this in commit 98ac809be2 on Aug 1, 2021furszy referenced this in commit f2f7815d9a on Aug 4, 2021furszy referenced this in commit 698065d4c7 on Aug 5, 2021furszy referenced this in commit 583be45c75 on Aug 8, 2021furszy referenced this in commit 0b5f406248 on Aug 10, 2021gwillen referenced this in commit 150d75939d on Jun 1, 2022DrahtBot locked this on Aug 16, 2022Labels
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 21:14 UTC
More mirrored repositories can be found on mirror.b10c.me