wallet: Do not load external signers wallets when unsupported #22173

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:check-external-signer-flags changing 1 files +7 −0
  1. achow101 commented at 5:54 pm on June 6, 2021: member

    When external signer support is not compiled, do not load external signer wallets.

    Alternative to #22168.

  2. Do not load external signers wallets when unsupported
    When external signer support is not compiled, do not load external
    signer wallets.
    e60cd26ad4
  3. hebasto commented at 5:56 pm on June 6, 2021: member
    Is this a fix for #21919?
  4. achow101 commented at 6:02 pm on June 6, 2021: member

    Is this a fix for #21919?

    It would seem so.

  5. DrahtBot added the label Wallet on Jun 6, 2021
  6. promag commented at 8:26 pm on June 7, 2021: member
    Tested ACK e60cd26ad46559770ad84d2959c9a1742ae8b7a6.
  7. meshcollider added this to the milestone 22.0 on Jun 9, 2021
  8. meshcollider commented at 2:13 am on June 9, 2021: contributor
    Code review ACK e60cd26ad46559770ad84d2959c9a1742ae8b7a6
  9. meshcollider merged this on Jun 9, 2021
  10. meshcollider closed this on Jun 9, 2021

  11. sidhujag referenced this in commit 15f3ffa838 on Jun 9, 2021
  12. Sjors commented at 4:30 pm on June 15, 2021: member
    Thanks. I think the reason why I missed this in #16546 is that I only tested a node downgrade. Earlier versions of Bitcoin Core will stop when they see an unrecognised wallet flag.
  13. gwillen referenced this in commit 0fe87c64ad on Jun 1, 2022
  14. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-04 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me