"Verify message" button doesn't work when invoked recursively #2218

issue schildbach opened this issue on January 26, 2013
  1. schildbach commented at 7:46 AM on January 26, 2013: contributor

    On bitcoin-qt, current master:

    Switch to address book. Select address and click on verify message. Click on "Chose address from the addressbook" icon. Select address and click on Verify message.

    nothing happens

    First of all I'd strongly recommend UIs should not allow for this recursive behaviour in the first place. But hell, if you show the button, I'd expect the Verify dialog to open a second time.

  2. laanwj commented at 7:53 AM on January 26, 2013: member

    That makes sense in a theoretic fashion, however I don't see any use case for opening it twice. Do you?

  3. schildbach commented at 8:14 AM on January 26, 2013: contributor

    As I said, I think the UI is misdesigned. All I'm saying is: There is a button, but nothing happens when clicking on it. If you cannot handle the button, remove it.

  4. laanwj commented at 8:42 AM on January 26, 2013: member

    Ok, agreed then

  5. Diapolo commented at 10:14 AM on January 26, 2013: none

    Perhaps we can tell the addressdialog, that it got opened from sign/verify message dialog and just hide sign/verify stuff then. Or should we only allow the OK button, when addressdialog is opened as seperate dialog?

    Edit: Nice catch, thanks for reporting.

  6. schildbach commented at 12:04 PM on January 26, 2013: contributor

    From a UX perspective, I would remove the "Chose address from the addressbook" button from all dialogs in case that dialog was opened with an address already selected.

  7. Diapolo commented at 1:01 PM on January 26, 2013: none

    I'll take a look :).

  8. Diapolo commented at 6:58 AM on July 23, 2013: none

    @laanwj Can you tag this with GUI?

  9. laanwj commented at 12:48 PM on November 7, 2013: member

    It's no longer possible to invoke it recursively, closing

  10. laanwj closed this on Nov 7, 2013

  11. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 21:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me