validation: Review mutable static local variables in `CChainState` methods #22189

issue dongcarl opened this issue on June 8, 2021
  1. dongcarl commented at 5:29 PM on June 8, 2021: contributor

    Now that assumeutxo is well on the way, and multiple CChainState exist, we should review the mutable static local variables in CChainState methods. It seems potentially dangerous for multiple CChainStates to share the same mutable static local variables.

    In CChainState::FlushStateToDisk: https://github.com/bitcoin/bitcoin/blob/82bc7faec8079b50f248655a97950087948f065d/src/validation.cpp#L2154-L2155

    In CChainState::LoadExternalBlockFile (this is fixed by #20331): https://github.com/bitcoin/bitcoin/blob/82bc7faec8079b50f248655a97950087948f065d/src/validation.cpp#L4286

    ping @jamesob


    Now that I think about it... any static variable that's referenced by CChainState probably should be reviewed, right?

  2. fanquake added the label Validation on Jun 9, 2021
  3. fanquake closed this on Dec 8, 2022

  4. bitcoin locked this on Dec 8, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 21:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me