This commit is a minimal restructuring necessary to support multiple wallets in the UI going forward. Please read https://github.com/CodeShark/bitcoin/blob/5bf2943a81e0937e4be0e8d2c6b4545b8d320cc4/multiwallet-qt.txt for details.
Minimal architectural changes necessary to support multiple wallets in bitcoin-qt #2220
pull CodeShark wants to merge 1 commits into bitcoin:master from CodeShark:multiwallet-qt-no-core changing 11 files +1099 −228-
CodeShark commented at 3:31 PM on January 26, 2013: contributor
-
BitcoinPullTester commented at 3:48 PM on January 26, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4af611676b784df41a9771792e828d62756c448d for binaries and test log.
-
CodeShark commented at 5:25 PM on January 26, 2013: contributor
#2184 already implements dynamic loading and unloading of wallets. But in the interest of incremental commits that are easier to verify, I decided to open this new pull request with the idea of having a discussion on the UI design and merging in these changes first before attempting to merge in #2124 and #2184.
-
BitcoinPullTester commented at 5:47 PM on January 26, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/5bf2943a81e0937e4be0e8d2c6b4545b8d320cc4 for binaries and test log.
-
BitcoinPullTester commented at 3:36 PM on February 5, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ea02ca6e44b089ecdd5395d0255857a1023914e3 for binaries and test log.
-
laanwj commented at 8:08 AM on February 24, 2013: member
Can you rebase this? Now that 0.8.0 final is out, I intend to test and merge it soon.
-
laanwj commented at 4:17 PM on March 22, 2013: member
@CodeShark I still plan to merge this as one of the next things, can you rebase please?
-
CodeShark commented at 4:50 PM on March 22, 2013: contributor
I'm on it...
-
CodeShark commented at 5:40 PM on March 22, 2013: contributor
Let me fix up some whitespace issues before you merge.
-
CodeShark commented at 5:50 PM on March 22, 2013: contributor
Allright, laanwj, it's all yours :) Let me know if you need anything else.
-
jgarzik commented at 6:04 PM on March 22, 2013: contributor
Fix the commit message, please
-
67155d9299
Minimal architectural changes necessary to support multiple wallets in bitcoin-qt
- This commit is a minimal restructuring necessary to support multiple wallets in the UI. Please see multiwallet-qt.txt for details.
-
Diapolo commented at 6:31 PM on March 22, 2013: none
The last rebase includes all current changes, i.e. the header and cpp cleanup pull? Then I'm fine with starting the evolution ^^.
- laanwj referenced this in commit a6d32c94ab on Mar 29, 2013
- laanwj merged this on Mar 29, 2013
- laanwj closed this on Mar 29, 2013
-
laanwj commented at 8:59 AM on March 29, 2013: member
Merged (manually due to slight #include conflict that I introduced by merging another pull)
-
Diapolo commented at 1:45 PM on April 1, 2013: none
@CodeShark Is it intended that bitcoingui.cpp and walletview.cpp seem to have quite much duplicate code in them? It would also be nice, if you could take a look at #2436. I created pulls for some other stuff that was not working, but perhaps there is more. We need to be really careful with such pulls IMHO.
- laudney referenced this in commit 1660ceaf21 on Mar 19, 2014
- laudney referenced this in commit a9cb7d9204 on Mar 19, 2014
- laudney referenced this in commit f6d69b8d70 on Mar 19, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors
Linked (view graph)