duplicate bitdb.Open() in init.cpp needed? #2225

issue Diapolo opened this issue on January 27, 2013

Diapolo commented at 11:48 AM on January 27, 2013: none

We have that call in step 5 here: https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L609

and again in step 7: https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L745

It seems like a duplicate block of code and even we check for if (fDbEnvInit) in .Open(), I'm asking if that could be removed because we don't need it.
sipa commented at 9:22 PM on February 10, 2013: member

This seems strange indeed, certainly now the block chain doesn't need bitdb anymore. @gavinandresen I assume this was added for the wallet salvage code. Is it (still) necessary?
gavinandresen commented at 3:00 PM on February 11, 2013: contributor

Yes, it was added for the wallet salvage code.

I have no idea if it is still necessary, but I plan on spending zero time figuring that out (and testing) because I assume we will be removing our BDB code entirely fairly soon with the upcoming wallet rewrite.
Diapolo commented at 10:46 AM on April 6, 2013: none

A pull for this is open, so closing.
Diapolo closed this on Apr 6, 2013
MarcoFalke locked this on Sep 8, 2021

Contributors