build: Perform boost::process detection with BOOST

laanwj commented at 10:08 am on June 21, 2021: member

Pass boost’s build settings to boost-specific library detection. As boost::process is header-only, setting the CPPFLAGS is enough, there is no need to set LIBS.

Closes #22269.

build: Perform boost::process detection with BOOST_CPPFLAGS

Pass boost's build settings to boost-specific library detection. As
boost::process is header-only, setting the CPPFLAGS is enough, there is
no need to set LIBS.

Closes #22269.

8d87a0c077

laanwj added the label Build system on Jun 21, 2021

laanwj added this to the milestone 22.0 on Jun 21, 2021

MarcoFalke added the label Needs Guix build on Jun 21, 2021

MarcoFalke added the label Needs gitian build on Jun 21, 2021

DrahtBot commented at 5:11 pm on June 21, 2021: member

Guix builds

File	commit 6a67366fdc3e1d383fe7cbfa209d7e85f0d96638(master)	commit 62a677c9ad8702885c78e96acf61ec82e9db13aa(master and this pull)
SKIPATTEST.TAG	`e3b0c44298fc1c14...`	`e3b0c44298fc1c14...`
*.tar.gz	`ed3096aa949f1b56...`	`09ab7371ba18012f...`
guix_build.log	`7920a375a22476b1...`	`96ef752b407daf68...`
guix_build.log.diff		`6eba84a29347b780...`

DrahtBot removed the label Needs Guix build on Jun 21, 2021

DrahtBot commented at 1:54 am on June 22, 2021: member

Gitian builds

File	commit 398dd678338971d2189934713c83c184742f293f(master)	commit 030c99decc37f964c5bc42a7c210bf63c5bdd8ec(master and this pull)
*-osx-unsigned.dmg	`92e2d116b58d4214...`	`b0eab3680b3992e5...`
*-osx64.tar.gz	`02578406a266bd45...`	`adf004565ec5cf57...`
*.tar.gz	`b16fc2a40cba5b8c...`	`a5d540ce0163bf48...`
bitcoin-core-osx-22-res.yml	`f2972b31a41adb54...`	`12ab96996f4f1fa2...`
linux-build.log	`6c8e74cad31e39a3...`	`6a4dad873cf3c729...`
osx-build.log	`bb8f3e7c16328172...`	`3d74c82e6fd2fe54...`
win-build.log	`2eea226b75083143...`	`7b244d60830e6f7f...`
bitcoin-core-osx-22-res.yml.diff		`37bb5243ec83208c...`
linux-build.log.diff		`8aa0e569c5b93f7c...`
osx-build.log.diff		`4f209023899dc278...`
win-build.log.diff		`4ac255f3cbdf36a6...`

DrahtBot removed the label Needs gitian build on Jun 22, 2021

jarolrod commented at 6:36 am on June 23, 2021: member

ACK 8d87a0c0771203b5278251aded23ba0157f0d2d1

Confirming bug #22269 on my FreeBSD 13 machine. This PR fixes the configuration error and allows me to build.

master:

0checking for Boost Process... configure: error: Boost::Process is required for external signer support, but not available!

pr:

0checking for Boost Process... yes

theStack commented at 9:30 am on June 23, 2021: member

With this patch, the boost::process header is now found on my OpenBSD 6.9 machine. Unfortunately, it still fails:

 0configure:31594: checking for Boost Process
 1configure:31609: c++ -std=c++17 -c -g -O2  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -DPROVIDE_FUZZ_MAIN_FUNCTION -I/usr/local/include conftest.cpp >&5
 2In file included from conftest.cpp:79:
 3In file included from /usr/local/include/boost/process.hpp:25:
 4In file included from /usr/local/include/boost/process/group.hpp:32:
 5/usr/local/include/boost/process/detail/posix/wait_group.hpp:38:17: error: no member named 'waitid' in the global namespace
 6        ret = ::waitid(P_PGID, p.grp, &status, WEXITED | WNOHANG);
 7              ~~^
 8/usr/local/include/boost/process/detail/posix/wait_group.hpp:38:24: error: use of undeclared identifier 'P_PGID'
 9        ret = ::waitid(P_PGID, p.grp, &status, WEXITED | WNOHANG);
10                       ^
11/usr/local/include/boost/process/detail/posix/wait_group.hpp:38:48: error: use of undeclared identifier 'WEXITED'
12        ret = ::waitid(P_PGID, p.grp, &status, WEXITED | WNOHANG);
13                                               ^
14/usr/local/include/boost/process/detail/posix/wait_group.hpp:144:17: error: no member named 'waitid' in the global namespace
15        ret = ::waitid(P_PGID, p.grp, &siginfo, WEXITED | WSTOPPED | WNOHANG);
16              ~~^
17/usr/local/include/boost/process/detail/posix/wait_group.hpp:144:24: error: use of undeclared identifier 'P_PGID'
18        ret = ::waitid(P_PGID, p.grp, &siginfo, WEXITED | WSTOPPED | WNOHANG);
19                       ^
20/usr/local/include/boost/process/detail/posix/wait_group.hpp:144:49: error: use of undeclared identifier 'WEXITED'
21        ret = ::waitid(P_PGID, p.grp, &siginfo, WEXITED | WSTOPPED | WNOHANG);
22                                                ^
23/usr/local/include/boost/process/detail/posix/wait_group.hpp:144:59: error: use of undeclared identifier 'WSTOPPED'
24        ret = ::waitid(P_PGID, p.grp, &siginfo, WEXITED | WSTOPPED | WNOHANG);
25                                                          ^
267 errors generated.

It seems like this is an issue with Boost integration in OpenBSD though (which e.g. indeed has no waitid).

theStack approved

theStack commented at 9:50 am on June 23, 2021: member

ACK 8d87a0c0771203b5278251aded23ba0157f0d2d1 (the patch fulfills its purpose and my report above about boost::process failing on OpenBSD is unrelated; OpenBSD users just have to wait untill boost::process integration is fixed)

DrahtBot commented at 3:52 pm on June 23, 2021: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#22320 (build: set minimum required Boost to 1.64.0 by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

laanwj commented at 8:38 am on June 24, 2021: member

It seems like this is an issue with Boost integration in OpenBSD though (which e.g. indeed has no waitid).

Should we recommend --disable-external-signer in doc/build-openbsd.md? Otherwise, the build fails by default there?

laanwj commented at 9:53 am on June 24, 2021: member

Closing in favor of #22320

laanwj closed this on Jun 24, 2021

fanquake referenced this in commit c31161f4f7 on Jun 24, 2021

sidhujag referenced this in commit 82f2101bf7 on Jun 24, 2021

laanwj referenced this in commit e0fe658b86 on Jul 12, 2021

sidhujag referenced this in commit 2c58aa4afc on Jul 14, 2021

DrahtBot locked this on Aug 16, 2022

build: Perform boost::process detection with BOOST_CPPFLAGS #22294

Guix builds

Gitian builds

Conflicts