potential cleanups possible before 0.8 RC #2230

issue sipa opened this issue on January 28, 2013
  1. sipa commented at 4:01 PM on January 28, 2013: member

    Some changes/improvements to code that is new for 0.8 are still possible before doing RCs. These include:

    • Dropping support for the pre-checksum undo file format (#2216)
    • Changing the directory naming scheme. From a discussion on IRC it was apparent that for example the name coins/ was confusing (people thought it was related to the wallet). One suggestion:
      • blocks/undo files remain in blocks/*
      • blktree/ becomes blocks/index/* (so it is intuitively clear it's associated with the blocks directory)
      • coins/ becomes chaindata/
      • optionally: put everything inside a subdirectory blockchain/, and perhaps make it configurable with -blockchaindir=, as it is now independent from the wallet anyway.
    • Adding an automatically generated README in the data directory/directories to explain what the different files/directories contain (suggested by andytoshi on IRC).
    • Calling an ftruncate() (or windows equivalent) on the block files when abandoning them would remove the permanent storage waste caused by pre-allocated padding being left over.
  2. gavinandresen commented at 5:29 PM on January 28, 2013: contributor

    I tagged #2216 for 0.8

    Changing directory naming scheme: yes, I think that should be done now, it will save lots of time explaining in the future. I don't care what the naming scheme is, just pick one and make it so.

    Auto-generated README: I say no, we can do that in a future release. ftruncate() : I say no, disk space is cheap. Time would be better spent testing a more important feature (if we care about disk space, then pruning would be that more important feature; I don't care much about disk space, though).

  3. sipa commented at 9:19 PM on February 10, 2013: member

    #2231 was merged.

  4. sipa closed this on Feb 10, 2013

  5. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 09:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me