test: Add missing syncwithvalidationinterfacequeue in p2p_blockfilters #22311

1. 
   MarcoFalke commented at 5:45 pm on June 22, 2021: member

   The index on the block filters is running in the background on the validation interface. To avoid intermittent test failures, it needs to be synced.

   Also other cleanups.

2. scripted-diff: Renames

   -BEGIN VERIFY SCRIPT-
   
    ren() { sed -i "s/\<$1\>/$2/g" test/functional/p2p_blockfilters.py ; }
   
    # Rename from "node" to "peer" to avoid confusion with self.nodes
    ren node0 peer_0
    ren node1 peer_1
   
    # Remove the confusing "C" prefix
    ren CFiltersClient FiltersClient
   
   -END VERIFY SCRIPT-

   facd97ae0f
3. test: Run pep-8

   Can be reviewed with --word-diff-regex=.

   fa1668bf50
4. test: Misc cleanup

   * Replace wait_until with assert_equal where possible
   * Use send_and_ping helper where possible

   faa211fc6e
5. test: Add missing syncwithvalidationinterfacequeue fadddd13ee
6. DrahtBot added the label Tests on Jun 22, 2021
7. 
   DrahtBot commented at 3:44 pm on June 23, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #20362 (test: Implicitly sync after generate* to preempt races and intermittent test failures by MarcoFalke)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. lsilva01 approved
9. 
   lsilva01 commented at 4:42 pm on June 23, 2021: contributor

   Tested ACK https://github.com/bitcoin/bitcoin/pull/22311/commits/fadddd13eef4428f5fa7237583d4be41a9335cd9 on Ubuntu 20.04
10. MarcoFalke merged this on Jun 24, 2021
11. MarcoFalke closed this on Jun 24, 2021

    ---

12. MarcoFalke deleted the branch on Jun 24, 2021
13. sidhujag referenced this in commit 1435f64799 on Jun 24, 2021
14. luke-jr referenced this in commit 2d36251786 on Jun 27, 2021
15. Fabcien referenced this in commit 5f303546b5 on May 11, 2022
16. Fabcien referenced this in commit 2addcd8036 on May 11, 2022
17. Fabcien referenced this in commit 196f3dd317 on May 11, 2022
18. gwillen referenced this in commit 635abda3e9 on Jun 1, 2022
19. DrahtBot locked this on Aug 16, 2022

Contributors
MarcoFalke DrahtBot lsilva01

Labels
Tests