changes for wait_for_getheaders to include hash_list #22312

pull siv2r wants to merge 1 commits into bitcoin:master from siv2r:modify-wait-getheaders changing 1 files +5 −2
  1. siv2r commented at 6:09 PM on June 22, 2021: none

    Address #18614

    Modified wait_for_getheaders to include block hash in the verification.

    The following function calls of wait_for_getheaders will be changed.

    • self.helper_peer.wait_for_getheaders(timeout=timeout) - (in feature_block.py)
    • peer.wait_for_getheaders(timeout=5) - (in mining_basic.py)
    • self.wait_for_getheaders() - (in p2p_segwit.py)
    • Few more in p2p_sendheaders.py
  2. base changes for wait_for_getheaders d4a95c54fd
  3. siv2r commented at 6:14 PM on June 22, 2021: none

    I have only implemented how a modified version of wait_for_getheaders will look like. I had a brief overview of the get headers bitcoin coin protocol documentation. I am trying to understand terms like block locator

    Are my changes the right way to approach this issue?

  4. DrahtBot added the label Tests on Jun 22, 2021
  5. siv2r commented at 7:09 PM on July 20, 2021: none

    Closing the draft. I will send a PR with a better change later!

  6. siv2r closed this on Jul 20, 2021

  7. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 03:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me